aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGlenn Morris2016-03-16 23:56:32 -0700
committerGlenn Morris2016-03-16 23:56:32 -0700
commit56df61712ac446d3dcd9c897f687cc74a04be314 (patch)
treed94f4478cc6fb5c980f01c77955e897f808cf0f6
parenta1ef911f31b81a47482dca4ea01f2c90442c0724 (diff)
downloademacs-56df61712ac446d3dcd9c897f687cc74a04be314.tar.gz
emacs-56df61712ac446d3dcd9c897f687cc74a04be314.zip
Address compilation warnings due to 2016-01-03 mml refactoring.
* lisp/gnus/mml-sec.el (password-cache, mm-encode): Require. (message-options-get): Autoload. (message-options-set): Declare. (mml-secure-cache-passphrase, mml-secure-passphrase-cache-expiry): Simplify default value. * lisp/gnus/mml-smime.el (message-options-set): Remove declaration. * lisp/gnus/mml1991.el, lisp/gnus/mml2015.el: No longer a need for password-cache.
-rw-r--r--lisp/gnus/mml-sec.el16
-rw-r--r--lisp/gnus/mml-smime.el4
-rw-r--r--lisp/gnus/mml1991.el5
-rw-r--r--lisp/gnus/mml2015.el5
4 files changed, 8 insertions, 22 deletions
diff --git a/lisp/gnus/mml-sec.el b/lisp/gnus/mml-sec.el
index 3ac3da0127d..254c427299e 100644
--- a/lisp/gnus/mml-sec.el
+++ b/lisp/gnus/mml-sec.el
@@ -27,6 +27,8 @@
27 27
28(require 'gnus-util) 28(require 'gnus-util)
29(require 'epg) 29(require 'epg)
30(require 'password-cache)
31(require 'mm-encode)
30 32
31(autoload 'mail-strip-quoted-names "mail-utils") 33(autoload 'mail-strip-quoted-names "mail-utils")
32(autoload 'mml2015-sign "mml2015") 34(autoload 'mml2015-sign "mml2015")
@@ -35,6 +37,7 @@
35(autoload 'mml1991-encrypt "mml1991") 37(autoload 'mml1991-encrypt "mml1991")
36(autoload 'message-fetch-field "message") 38(autoload 'message-fetch-field "message")
37(autoload 'message-goto-body "message") 39(autoload 'message-goto-body "message")
40(autoload 'message-options-get "message")
38(autoload 'mml-insert-tag "mml") 41(autoload 'mml-insert-tag "mml")
39(autoload 'mml-smime-sign "mml-smime") 42(autoload 'mml-smime-sign "mml-smime")
40(autoload 'mml-smime-encrypt "mml-smime") 43(autoload 'mml-smime-encrypt "mml-smime")
@@ -44,6 +47,8 @@
44(autoload 'mml-smime-verify-test "mml-smime") 47(autoload 'mml-smime-verify-test "mml-smime")
45(autoload 'epa--select-keys "epa") 48(autoload 'epa--select-keys "epa")
46 49
50(declare-function message-options-set "message" (symbol value))
51
47(defvar mml-sign-alist 52(defvar mml-sign-alist
48 '(("smime" mml-smime-sign-buffer mml-smime-sign-query) 53 '(("smime" mml-smime-sign-buffer mml-smime-sign-query)
49 ("pgp" mml-pgp-sign-buffer list) 54 ("pgp" mml-pgp-sign-buffer list)
@@ -110,20 +115,15 @@ details."
110 :group 'message 115 :group 'message
111 :type 'boolean) 116 :type 'boolean)
112 117
113(defcustom mml-secure-cache-passphrase 118;; FIXME If it's "NOT recommended", why is it the default?
114 (if (boundp 'password-cache) 119(defcustom mml-secure-cache-passphrase password-cache
115 password-cache
116 t)
117 "If t, cache OpenPGP or S/MIME passphrases inside Emacs. 120 "If t, cache OpenPGP or S/MIME passphrases inside Emacs.
118Passphrase caching in Emacs is NOT recommended. Use gpg-agent instead. 121Passphrase caching in Emacs is NOT recommended. Use gpg-agent instead.
119See Info node `(message) Security'." 122See Info node `(message) Security'."
120 :group 'message 123 :group 'message
121 :type 'boolean) 124 :type 'boolean)
122 125
123(defcustom mml-secure-passphrase-cache-expiry 126(defcustom mml-secure-passphrase-cache-expiry password-cache-expiry
124 (if (boundp 'password-cache-expiry)
125 password-cache-expiry
126 16)
127 "How many seconds the passphrase is cached. 127 "How many seconds the passphrase is cached.
128Whether the passphrase is cached at all is controlled by 128Whether the passphrase is cached at all is controlled by
129`mml-secure-cache-passphrase'." 129`mml-secure-cache-passphrase'."
diff --git a/lisp/gnus/mml-smime.el b/lisp/gnus/mml-smime.el
index 248e63682c8..502c65b2463 100644
--- a/lisp/gnus/mml-smime.el
+++ b/lisp/gnus/mml-smime.el
@@ -356,10 +356,6 @@ Whether the passphrase is cached at all is controlled by
356 356
357(autoload 'mml-compute-boundary "mml") 357(autoload 'mml-compute-boundary "mml")
358 358
359;; We require mm-decode, which requires mm-bodies, which autoloads
360;; message-options-get (!).
361(declare-function message-options-set "message" (symbol value))
362
363(defun mml-smime-epg-sign (cont) 359(defun mml-smime-epg-sign (cont)
364 (let ((inhibit-redisplay t) 360 (let ((inhibit-redisplay t)
365 (boundary (mml-compute-boundary cont))) 361 (boundary (mml-compute-boundary cont)))
diff --git a/lisp/gnus/mml1991.el b/lisp/gnus/mml1991.el
index bb5c940f173..568dc564d91 100644
--- a/lisp/gnus/mml1991.el
+++ b/lisp/gnus/mml1991.el
@@ -25,11 +25,6 @@
25 25
26;;; Code: 26;;; Code:
27 27
28(eval-and-compile
29 (if (locate-library "password-cache")
30 (require 'password-cache)
31 (require 'password)))
32
33(eval-when-compile 28(eval-when-compile
34 (require 'cl) 29 (require 'cl)
35 (require 'mm-util)) 30 (require 'mm-util))
diff --git a/lisp/gnus/mml2015.el b/lisp/gnus/mml2015.el
index e2e99771801..61ca53624d3 100644
--- a/lisp/gnus/mml2015.el
+++ b/lisp/gnus/mml2015.el
@@ -27,11 +27,6 @@
27 27
28;;; Code: 28;;; Code:
29 29
30(eval-and-compile
31 (if (locate-library "password-cache")
32 (require 'password-cache)
33 (require 'password)))
34
35(eval-when-compile (require 'cl)) 30(eval-when-compile (require 'cl))
36(require 'mm-decode) 31(require 'mm-decode)
37(require 'mm-util) 32(require 'mm-util)