aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorEli Zaretskii2012-09-23 19:34:30 +0200
committerEli Zaretskii2012-09-23 19:34:30 +0200
commit5101529e98c333b07d17dc891ba0a2e1669d82ac (patch)
tree44409a84a8695caf7fc4b9efff4cea6187d51d5d
parent2c3ee0ad12e4d516ba2661ffd3ff8b356c7bff4f (diff)
downloademacs-5101529e98c333b07d17dc891ba0a2e1669d82ac.tar.gz
emacs-5101529e98c333b07d17dc891ba0a2e1669d82ac.zip
Clean-up left-overs after 2012-09-23T08:44:20Z!eggert@cs.ucla.edu wrt signal handling.
src/.gdbinit: Set breakpoint on terminate_due_to_signal, not on fatal_error_backtrace. src/w32proc.c (sys_kill): Undo last change: don't do anything when invoked to deliver SIGABRT to our own process. This is now handled by emacs_raise. nt/inc/ms-w32.h (emacs_raise): Redefine to invoke emacs_abort. Fixes: debbugs:12471
-rw-r--r--nt/ChangeLog4
-rw-r--r--nt/inc/ms-w32.h2
-rw-r--r--src/.gdbinit4
-rw-r--r--src/ChangeLog9
-rw-r--r--src/w32proc.c3
5 files changed, 16 insertions, 6 deletions
diff --git a/nt/ChangeLog b/nt/ChangeLog
index c8aadaee911..9f7b4df2e81 100644
--- a/nt/ChangeLog
+++ b/nt/ChangeLog
@@ -1,3 +1,7 @@
12012-09-23 Eli Zaretskii <eliz@gnu.org>
2
3 * inc/ms-w32.h (emacs_raise): Redefine to invoke emacs_abort.
4
12012-09-23 Paul Eggert <eggert@cs.ucla.edu> 52012-09-23 Paul Eggert <eggert@cs.ucla.edu>
2 6
3 Simplify and avoid signal-handling races (Bug#12471). 7 Simplify and avoid signal-handling races (Bug#12471).
diff --git a/nt/inc/ms-w32.h b/nt/inc/ms-w32.h
index ff2ba6f4fd1..107ab6e788b 100644
--- a/nt/inc/ms-w32.h
+++ b/nt/inc/ms-w32.h
@@ -204,7 +204,7 @@ struct sigaction {
204#define signal sys_signal 204#define signal sys_signal
205 205
206/* Internal signals. */ 206/* Internal signals. */
207#define emacs_raise(sig) kill (getpid (), sig) 207#define emacs_raise(sig) emacs_abort()
208 208
209/* termcap.c calls that are emulated. */ 209/* termcap.c calls that are emulated. */
210#define tputs sys_tputs 210#define tputs sys_tputs
diff --git a/src/.gdbinit b/src/.gdbinit
index 74f44cc1007..7a6bfb07fed 100644
--- a/src/.gdbinit
+++ b/src/.gdbinit
@@ -1214,8 +1214,8 @@ show environment DISPLAY
1214show environment TERM 1214show environment TERM
1215 1215
1216# When debugging, it is handy to be able to "return" from 1216# When debugging, it is handy to be able to "return" from
1217# fatal_error_backtrace when an assertion failure is non-fatal. 1217# terminate_due_to_signal when an assertion failure is non-fatal.
1218break fatal_error_backtrace 1218break terminate_due_to_signal
1219 1219
1220# x_error_quitter is defined only on X. But window-system is set up 1220# x_error_quitter is defined only on X. But window-system is set up
1221# only at run time, during Emacs startup, so we need to defer setting 1221# only at run time, during Emacs startup, so we need to defer setting
diff --git a/src/ChangeLog b/src/ChangeLog
index 0329e0c982c..a55a2f5514c 100644
--- a/src/ChangeLog
+++ b/src/ChangeLog
@@ -1,3 +1,12 @@
12012-09-23 Eli Zaretskii <eliz@gnu.org>
2
3 * .gdbinit: Set breakpoint on terminate_due_to_signal, not on
4 fatal_error_backtrace.
5
6 * w32proc.c (sys_kill): Undo last change: don't do anything when
7 invoked to deliver SIGABRT to our own process. This is now
8 handled by emacs_raise.
9
12012-09-23 Juanma Barranquero <lekktu@gmail.com> 102012-09-23 Juanma Barranquero <lekktu@gmail.com>
2 11
3 * w32term.c (w32_read_socket): Remove leftover reference to 12 * w32term.c (w32_read_socket): Remove leftover reference to
diff --git a/src/w32proc.c b/src/w32proc.c
index 26a0925ad87..8dbd063a96b 100644
--- a/src/w32proc.c
+++ b/src/w32proc.c
@@ -1428,9 +1428,6 @@ sys_kill (int pid, int sig)
1428 int need_to_free = 0; 1428 int need_to_free = 0;
1429 int rc = 0; 1429 int rc = 0;
1430 1430
1431 if (pid == getpid () && sig == SIGABRT)
1432 emacs_abort ();
1433
1434 /* Only handle signals that will result in the process dying */ 1431 /* Only handle signals that will result in the process dying */
1435 if (sig != SIGINT && sig != SIGKILL && sig != SIGQUIT && sig != SIGHUP) 1432 if (sig != SIGINT && sig != SIGKILL && sig != SIGQUIT && sig != SIGHUP)
1436 { 1433 {