aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTino Calancha2018-06-03 23:28:14 +0900
committerTino Calancha2018-06-03 23:28:14 +0900
commit50c0624b2aecb9668505eb2cea3f30aecbf6d1ec (patch)
tree2fd3af2490d590854f206b7b33f55f7d7f76ca00
parentdefd53a56c709b8b8c736f0ab3b594490216d300 (diff)
downloademacs-50c0624b2aecb9668505eb2cea3f30aecbf6d1ec.tar.gz
emacs-50c0624b2aecb9668505eb2cea3f30aecbf6d1ec.zip
Backport: Preserve case in query-replace undo
If the user query and replaces 'foo' with 'BAR', then undo must comeback to 'foo', not to 'FOO' (Bug#31073). * lisp/replace.el (perform-replace): Bind nocasify to non-nil value during undo/undo-all actions. * test/lisp/replace-tests.el (query-replace-undo-bug31073): Add test. (cherry picked from commit 32dc0cb1b5ae895d237c7118ccaeb084715934fd)
-rw-r--r--lisp/replace.el1
-rw-r--r--test/lisp/replace-tests.el20
2 files changed, 21 insertions, 0 deletions
diff --git a/lisp/replace.el b/lisp/replace.el
index 6cee2253746..d1eabb035d3 100644
--- a/lisp/replace.el
+++ b/lisp/replace.el
@@ -2576,6 +2576,7 @@ It must return a string."
2576 (let ((stack-idx 0) 2576 (let ((stack-idx 0)
2577 (stack-len (length stack)) 2577 (stack-len (length stack))
2578 (num-replacements 0) 2578 (num-replacements 0)
2579 (nocasify t) ; Undo must preserve case (Bug#31073).
2579 search-string 2580 search-string
2580 next-replacement) 2581 next-replacement)
2581 (while (and (< stack-idx stack-len) 2582 (while (and (< stack-idx stack-len)
diff --git a/test/lisp/replace-tests.el b/test/lisp/replace-tests.el
index 66c68426607..40a1a31cf7c 100644
--- a/test/lisp/replace-tests.el
+++ b/test/lisp/replace-tests.el
@@ -380,4 +380,24 @@ Each element has the format:
380 (should (string= "211" (replace-tests--query-replace-undo))) 380 (should (string= "211" (replace-tests--query-replace-undo)))
381 (should (string= "211" (replace-tests--query-replace-undo 'comma)))) 381 (should (string= "211" (replace-tests--query-replace-undo 'comma))))
382 382
383(ert-deftest query-replace-undo-bug31073 ()
384 "Test for https://debbugs.gnu.org/31073 ."
385 (let ((text "aaa aaa")
386 (count 0))
387 (with-temp-buffer
388 (insert text)
389 (goto-char 1)
390 (cl-letf (((symbol-function 'read-event)
391 (lambda (&rest args)
392 (cl-incf count)
393 (let ((val (pcase count
394 ((or 1 2 3) ?\s) ; replace current and go next
395 (4 ?U) ; undo-all
396 (_ ?q)))) ; exit
397 val))))
398 (perform-replace "a" "B" t nil nil))
399 ;; After undo text must be the same.
400 (should (string= text (buffer-string))))))
401
402
383;;; replace-tests.el ends here 403;;; replace-tests.el ends here