diff options
| author | Paul Eggert | 2013-09-06 17:20:56 -0700 |
|---|---|---|
| committer | Paul Eggert | 2013-09-06 17:20:56 -0700 |
| commit | 4b73fc7347e15f329a9a866f90e4241e064ec66d (patch) | |
| tree | 18db2fdc91a6ae00f11cee6da51a5714fa6f78c4 | |
| parent | 67982e2b74ad72987459a6995f34161053a1dbfb (diff) | |
| download | emacs-4b73fc7347e15f329a9a866f90e4241e064ec66d.tar.gz emacs-4b73fc7347e15f329a9a866f90e4241e064ec66d.zip | |
Port --without-x --enable-gcc-warnings to Fedora 19.
* configure.ac (WERROR_CFLAGS): Omit redundant use of
-Wmissing-field-initializers, -Wswitch, -Wtype-limits,
-Wunused-parameter. If there is no window system, also omit
-Wsuggest-attribute=const and -Wsuggest-attribute=noreturn; this
is needed for Fedora 19.
* src/gfilenotify.c (globals_of_gfilenotify):
Call g_type_init only if using an older glib version that needs it.
| -rw-r--r-- | ChangeLog | 9 | ||||
| -rw-r--r-- | configure.ac | 12 | ||||
| -rw-r--r-- | src/ChangeLog | 6 | ||||
| -rw-r--r-- | src/gfilenotify.c | 2 |
4 files changed, 29 insertions, 0 deletions
| @@ -1,3 +1,12 @@ | |||
| 1 | 2013-09-07 Paul Eggert <eggert@cs.ucla.edu> | ||
| 2 | |||
| 3 | Port --without-x --enable-gcc-warnings to Fedora 19. | ||
| 4 | * configure.ac (WERROR_CFLAGS): Omit redundant use of | ||
| 5 | -Wmissing-field-initializers, -Wswitch, -Wtype-limits, | ||
| 6 | -Wunused-parameter. If there is no window system, also omit | ||
| 7 | -Wsuggest-attribute=const and -Wsuggest-attribute=noreturn; this | ||
| 8 | is needed for Fedora 19. | ||
| 9 | |||
| 1 | 2013-09-05 Dmitry Antipov <dmantipov@yandex.ru> | 10 | 2013-09-05 Dmitry Antipov <dmantipov@yandex.ru> |
| 2 | 11 | ||
| 3 | Make --without-x compatible with --enable-gcc-warnings. | 12 | Make --without-x compatible with --enable-gcc-warnings. |
diff --git a/configure.ac b/configure.ac index cfec49e5645..c7cdc01e3e7 100644 --- a/configure.ac +++ b/configure.ac | |||
| @@ -826,6 +826,13 @@ else | |||
| 826 | # The following line should be removable at some point. | 826 | # The following line should be removable at some point. |
| 827 | nw="$nw -Wsuggest-attribute=pure" | 827 | nw="$nw -Wsuggest-attribute=pure" |
| 828 | 828 | ||
| 829 | # This part is merely for shortening the command line, | ||
| 830 | # since -Wno-FOO needs to be added below regardless. | ||
| 831 | nw="$nw -Wmissing-field-initializers" | ||
| 832 | nw="$nw -Wswitch" | ||
| 833 | nw="$nw -Wtype-limits" | ||
| 834 | nw="$nw -Wunused-parameter" | ||
| 835 | |||
| 829 | # clang is unduly picky about some things. | 836 | # clang is unduly picky about some things. |
| 830 | AC_CACHE_CHECK([whether the compiler is clang], [emacs_cv_clang], | 837 | AC_CACHE_CHECK([whether the compiler is clang], [emacs_cv_clang], |
| 831 | [AC_COMPILE_IFELSE( | 838 | [AC_COMPILE_IFELSE( |
| @@ -1777,6 +1784,11 @@ fi | |||
| 1777 | 1784 | ||
| 1778 | if test "$window_system" = none && test "$gl_gcc_warnings" = yes; then | 1785 | if test "$window_system" = none && test "$gl_gcc_warnings" = yes; then |
| 1779 | # Too many warnings for now. | 1786 | # Too many warnings for now. |
| 1787 | nw= | ||
| 1788 | nw="$nw -Wsuggest-attribute=const" | ||
| 1789 | nw="$nw -Wsuggest-attribute=noreturn" | ||
| 1790 | gl_MANYWARN_COMPLEMENT([WARN_CFLAGS], [$WARN_CFLAGS], [$nw]) | ||
| 1791 | |||
| 1780 | gl_WARN_ADD([-Wno-unused-variable]) | 1792 | gl_WARN_ADD([-Wno-unused-variable]) |
| 1781 | gl_WARN_ADD([-Wno-unused-but-set-variable]) | 1793 | gl_WARN_ADD([-Wno-unused-but-set-variable]) |
| 1782 | gl_WARN_ADD([-Wno-unused-but-set-parameter]) | 1794 | gl_WARN_ADD([-Wno-unused-but-set-parameter]) |
diff --git a/src/ChangeLog b/src/ChangeLog index 7f41abc46bb..7f4c3f731f4 100644 --- a/src/ChangeLog +++ b/src/ChangeLog | |||
| @@ -1,3 +1,9 @@ | |||
| 1 | 2013-09-07 Paul Eggert <eggert@cs.ucla.edu> | ||
| 2 | |||
| 3 | Port --without-x --enable-gcc-warnings to Fedora 19. | ||
| 4 | * gfilenotify.c (globals_of_gfilenotify): | ||
| 5 | Call g_type_init only if using an older glib version that needs it. | ||
| 6 | |||
| 1 | 2013-09-06 Dmitry Antipov <dmantipov@yandex.ru> | 7 | 2013-09-06 Dmitry Antipov <dmantipov@yandex.ru> |
| 2 | 8 | ||
| 3 | * lisp.h (last_glyphless_glyph_frame, last_glyphless_glyph_face_id) | 9 | * lisp.h (last_glyphless_glyph_frame, last_glyphless_glyph_face_id) |
diff --git a/src/gfilenotify.c b/src/gfilenotify.c index 8f13c72df81..7415c3a2413 100644 --- a/src/gfilenotify.c +++ b/src/gfilenotify.c | |||
| @@ -249,7 +249,9 @@ WATCH-DESCRIPTOR should be an object returned by `gfile-add-watch'. */) | |||
| 249 | void | 249 | void |
| 250 | globals_of_gfilenotify (void) | 250 | globals_of_gfilenotify (void) |
| 251 | { | 251 | { |
| 252 | #if ! GLIB_CHECK_VERSION (2, 36, 0) | ||
| 252 | g_type_init (); | 253 | g_type_init (); |
| 254 | #endif | ||
| 253 | watch_list = Qnil; | 255 | watch_list = Qnil; |
| 254 | } | 256 | } |
| 255 | 257 | ||