aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorKatsumi Yamaoka2012-11-14 22:30:25 -0500
committerStefan Monnier2012-11-14 22:30:25 -0500
commit47f01a8af9660c018cafa3a97632c8bcb2417cec (patch)
tree532b557180a4feab0705449901b5a41b59bf9eaa
parenta61428c42db53e4b90d4bf12bb49aeec7abbd13a (diff)
downloademacs-47f01a8af9660c018cafa3a97632c8bcb2417cec.tar.gz
emacs-47f01a8af9660c018cafa3a97632c8bcb2417cec.zip
* lisp/emacs-lisp/advice.el (ad-make-advised-definition): Fix undefined case.
* lisp/emacs-lisp/nadvice.el (advice--make-interactive-form): Fix string-spec case.
-rw-r--r--lisp/ChangeLog7
-rw-r--r--lisp/emacs-lisp/advice.el2
-rw-r--r--lisp/emacs-lisp/nadvice.el2
3 files changed, 9 insertions, 2 deletions
diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index 51efba25f97..dccdc429ebc 100644
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,3 +1,10 @@
12012-11-15 Katsumi Yamaoka <yamaoka@jpl.org>
2
3 * emacs-lisp/nadvice.el (advice--make-interactive-form):
4 Fix string-spec case.
5
6 * emacs-lisp/advice.el (ad-make-advised-definition): Fix undefined case.
7
12012-11-15 Stefan Monnier <monnier@iro.umontreal.ca> 82012-11-15 Stefan Monnier <monnier@iro.umontreal.ca>
2 9
3 * emacs-lisp/nadvice.el: Add buffer-local support to add-function. 10 * emacs-lisp/nadvice.el: Add buffer-local support to add-function.
diff --git a/lisp/emacs-lisp/advice.el b/lisp/emacs-lisp/advice.el
index f9b4491e6e0..b99e614bec5 100644
--- a/lisp/emacs-lisp/advice.el
+++ b/lisp/emacs-lisp/advice.el
@@ -2597,7 +2597,7 @@ in any of these classes."
2597 (ad-has-redefining-advice function)) 2597 (ad-has-redefining-advice function))
2598 (let* ((origdef (ad-real-orig-definition function)) 2598 (let* ((origdef (ad-real-orig-definition function))
2599 ;; Construct the individual pieces that we need for assembly: 2599 ;; Construct the individual pieces that we need for assembly:
2600 (orig-arglist (ad-arglist origdef)) 2600 (orig-arglist (and origdef (ad-arglist origdef)))
2601 (advised-arglist (or (ad-advised-arglist function) 2601 (advised-arglist (or (ad-advised-arglist function)
2602 orig-arglist)) 2602 orig-arglist))
2603 (interactive-form (ad-advised-interactive-form function)) 2603 (interactive-form (ad-advised-interactive-form function))
diff --git a/lisp/emacs-lisp/nadvice.el b/lisp/emacs-lisp/nadvice.el
index 0c3b267f9e1..540e0166ec2 100644
--- a/lisp/emacs-lisp/nadvice.el
+++ b/lisp/emacs-lisp/nadvice.el
@@ -129,7 +129,7 @@ Each element has the form (WHERE BYTECODE STACK) where:
129 ;; FIXME: The calls to interactive-form below load autoloaded functions 129 ;; FIXME: The calls to interactive-form below load autoloaded functions
130 ;; too eagerly. 130 ;; too eagerly.
131 (let ((fspec (cadr (interactive-form function)))) 131 (let ((fspec (cadr (interactive-form function))))
132 (when (eq 'function (car fspec)) ;; Macroexpanded lambda? 132 (when (eq 'function (car-safe fspec)) ;; Macroexpanded lambda?
133 (setq fspec (nth 1 fspec))) 133 (setq fspec (nth 1 fspec)))
134 (if (functionp fspec) 134 (if (functionp fspec)
135 `(funcall ',fspec 135 `(funcall ',fspec