diff options
| author | Alan Mackenzie | 2018-10-23 13:28:19 +0000 |
|---|---|---|
| committer | Alan Mackenzie | 2018-10-23 13:28:19 +0000 |
| commit | 3ce5a6fc36df6e7c590520a1cc64dda948fddf6f (patch) | |
| tree | c2a290c7891a39af37e360a13ba04a0d44eb1eec | |
| parent | a38128561757c82fbd088cba379b7a253558c7f1 (diff) | |
| download | emacs-3ce5a6fc36df6e7c590520a1cc64dda948fddf6f.tar.gz emacs-3ce5a6fc36df6e7c590520a1cc64dda948fddf6f.zip | |
edebug.el: Move window focus switch into edebug-pop-to-buffer
* lisp/emacs-lisp/follow.el (edebug-focus-frame): Remove.
(edebug-pop-to-buffer): Call x-focus-frame for GUI frames.
(edebug-default-enter, edebug--display-1): Replace call to
edebug-focus-frame with x-focus-frame.
(edebug-where, edebug-bounce-point, edebug-visit-eval-list): Remove no longer
needed calls to edebug-focus-frame.
| -rw-r--r-- | lisp/emacs-lisp/edebug.el | 24 |
1 files changed, 9 insertions, 15 deletions
diff --git a/lisp/emacs-lisp/edebug.el b/lisp/emacs-lisp/edebug.el index ce4ed687be4..15f68a62aca 100644 --- a/lisp/emacs-lisp/edebug.el +++ b/lisp/emacs-lisp/edebug.el | |||
| @@ -342,12 +342,6 @@ Return the result of the last expression in BODY." | |||
| 342 | (defconst edebug-trace-buffer "*edebug-trace*" | 342 | (defconst edebug-trace-buffer "*edebug-trace*" |
| 343 | "Name of the buffer to put trace info in.") | 343 | "Name of the buffer to put trace info in.") |
| 344 | 344 | ||
| 345 | (defun edebug-focus-frame (frame) | ||
| 346 | "Switch focus to frame FRAME, if we're in a GUI. | ||
| 347 | Otherwise, do nothing." | ||
| 348 | (unless (memq (framep frame) '(nil t pc)) | ||
| 349 | (x-focus-frame frame))) | ||
| 350 | |||
| 351 | (defun edebug-pop-to-buffer (buffer &optional window) | 345 | (defun edebug-pop-to-buffer (buffer &optional window) |
| 352 | ;; Like pop-to-buffer, but select window where BUFFER was last shown. | 346 | ;; Like pop-to-buffer, but select window where BUFFER was last shown. |
| 353 | ;; Select WINDOW if it is provided and still exists. Otherwise, | 347 | ;; Select WINDOW if it is provided and still exists. Otherwise, |
| @@ -379,6 +373,8 @@ Otherwise, do nothing." | |||
| 379 | (t (split-window (minibuffer-selected-window))))) | 373 | (t (split-window (minibuffer-selected-window))))) |
| 380 | (set-window-buffer window buffer) | 374 | (set-window-buffer window buffer) |
| 381 | (select-window window) | 375 | (select-window window) |
| 376 | (unless (memq (framep (selected-frame)) '(nil t pc)) | ||
| 377 | (x-focus-frame (selected-frame))) | ||
| 382 | (set-window-hscroll window 0)) ;; should this be?? | 378 | (set-window-hscroll window 0)) ;; should this be?? |
| 383 | 379 | ||
| 384 | (defun edebug-get-displayed-buffer-points () | 380 | (defun edebug-get-displayed-buffer-points () |
| @@ -2346,8 +2342,9 @@ and run its entry function, and set up `edebug-before' and | |||
| 2346 | edebug-execution-mode) | 2342 | edebug-execution-mode) |
| 2347 | edebug-next-execution-mode nil) | 2343 | edebug-next-execution-mode nil) |
| 2348 | (edebug-default-enter function args body)) | 2344 | (edebug-default-enter function args body)) |
| 2349 | (if (frame-live-p outside-frame) | 2345 | (if (and (frame-live-p outside-frame) |
| 2350 | (edebug-focus-frame outside-frame)))) | 2346 | (not (memq (framep outside-frame) '(nil t pc)))) |
| 2347 | (x-focus-frame outside-frame)))) | ||
| 2351 | 2348 | ||
| 2352 | (let* ((edebug-data (get function 'edebug)) | 2349 | (let* ((edebug-data (get function 'edebug)) |
| 2353 | (edebug-def-mark (car edebug-data)) ; mark at def start | 2350 | (edebug-def-mark (car edebug-data)) ; mark at def start |
| @@ -2656,7 +2653,8 @@ See `edebug-behavior-alist' for implementations.") | |||
| 2656 | (edebug-eval-display eval-result-list) | 2653 | (edebug-eval-display eval-result-list) |
| 2657 | ;; The evaluation list better not have deleted edebug-window-data. | 2654 | ;; The evaluation list better not have deleted edebug-window-data. |
| 2658 | (select-window (car edebug-window-data)) | 2655 | (select-window (car edebug-window-data)) |
| 2659 | (edebug-focus-frame (window-frame (selected-window))) | 2656 | (if (not (memq (framep (selected-frame)) '(nil t pc))) |
| 2657 | (x-focus-frame (selected-frame))) | ||
| 2660 | (set-buffer edebug-buffer) | 2658 | (set-buffer edebug-buffer) |
| 2661 | 2659 | ||
| 2662 | (setq edebug-buffer-outside-point (point)) | 2660 | (setq edebug-buffer-outside-point (point)) |
| @@ -3027,7 +3025,6 @@ Otherwise, toggle for all windows." | |||
| 3027 | ;;(if edebug-inside-windows | 3025 | ;;(if edebug-inside-windows |
| 3028 | ;; (edebug-set-windows edebug-inside-windows)) | 3026 | ;; (edebug-set-windows edebug-inside-windows)) |
| 3029 | (edebug-pop-to-buffer edebug-buffer) | 3027 | (edebug-pop-to-buffer edebug-buffer) |
| 3030 | (edebug-focus-frame (window-frame (selected-window))) | ||
| 3031 | (goto-char edebug-point)) | 3028 | (goto-char edebug-point)) |
| 3032 | 3029 | ||
| 3033 | (defun edebug-view-outside () | 3030 | (defun edebug-view-outside () |
| @@ -3055,15 +3052,13 @@ before returning. The default is one second." | |||
| 3055 | ;; If the buffer's currently displayed, avoid set-window-configuration. | 3052 | ;; If the buffer's currently displayed, avoid set-window-configuration. |
| 3056 | (save-window-excursion | 3053 | (save-window-excursion |
| 3057 | (edebug-pop-to-buffer edebug-outside-buffer) | 3054 | (edebug-pop-to-buffer edebug-outside-buffer) |
| 3058 | (edebug-focus-frame (window-frame (selected-window))) | ||
| 3059 | (goto-char edebug-outside-point) | 3055 | (goto-char edebug-outside-point) |
| 3060 | (message "Current buffer: %s Point: %s Mark: %s" | 3056 | (message "Current buffer: %s Point: %s Mark: %s" |
| 3061 | (current-buffer) (point) | 3057 | (current-buffer) (point) |
| 3062 | (if (marker-buffer (edebug-mark-marker)) | 3058 | (if (marker-buffer (edebug-mark-marker)) |
| 3063 | (marker-position (edebug-mark-marker)) "<not set>")) | 3059 | (marker-position (edebug-mark-marker)) "<not set>")) |
| 3064 | (sit-for arg) | 3060 | (sit-for arg) |
| 3065 | (edebug-pop-to-buffer edebug-buffer (car edebug-window-data)) | 3061 | (edebug-pop-to-buffer edebug-buffer (car edebug-window-data))))) |
| 3066 | (edebug-focus-frame (window-frame (selected-window)))))) | ||
| 3067 | 3062 | ||
| 3068 | 3063 | ||
| 3069 | ;; Joe Wells, here is a start at your idea of adding a buffer to the internal | 3064 | ;; Joe Wells, here is a start at your idea of adding a buffer to the internal |
| @@ -3885,8 +3880,7 @@ May only be called from within `edebug--recursive-edit'." | |||
| 3885 | "Switch to the evaluation list buffer \"*edebug*\"." | 3880 | "Switch to the evaluation list buffer \"*edebug*\"." |
| 3886 | (interactive) | 3881 | (interactive) |
| 3887 | (edebug-eval-redisplay) | 3882 | (edebug-eval-redisplay) |
| 3888 | (edebug-pop-to-buffer edebug-eval-buffer) | 3883 | (edebug-pop-to-buffer edebug-eval-buffer)) |
| 3889 | (edebug-focus-frame (window-frame (selected-window)))) | ||
| 3890 | 3884 | ||
| 3891 | 3885 | ||
| 3892 | (defun edebug-update-eval-list () | 3886 | (defun edebug-update-eval-list () |