diff options
| author | Lars Ingebrigtsen | 2019-06-13 14:35:30 +0200 |
|---|---|---|
| committer | Lars Ingebrigtsen | 2019-06-13 14:35:30 +0200 |
| commit | 390c8805c2c4e636c12c5c7e892c3c5e481a0256 (patch) | |
| tree | 23db0e0827a1f170b171b4cf22bb51d6c7fa115b | |
| parent | bc7e771f9b1e204efff015464a40c3ee59668fd9 (diff) | |
| download | emacs-390c8805c2c4e636c12c5c7e892c3c5e481a0256.tar.gz emacs-390c8805c2c4e636c12c5c7e892c3c5e481a0256.zip | |
Fix erc-dcc server-close code and fix compilation warning
* lisp/erc/erc-dcc.el (erc-dcc-get-filter): We receive unibyte
data, so no need to convert to unibyte.
(erc-dcc-send-filter): Kill the process before killing the buffer
so that we're not queried about killing the process.
| -rw-r--r-- | lisp/erc/erc-dcc.el | 13 |
1 files changed, 7 insertions, 6 deletions
diff --git a/lisp/erc/erc-dcc.el b/lisp/erc/erc-dcc.el index abc31484f8a..2b6f8c91a63 100644 --- a/lisp/erc/erc-dcc.el +++ b/lisp/erc/erc-dcc.el | |||
| @@ -813,8 +813,8 @@ bytes sent." | |||
| 813 | ?s (number-to-string (- sent-marker (point-min)))) | 813 | ?s (number-to-string (- sent-marker (point-min)))) |
| 814 | (setq erc-dcc-list (delete elt erc-dcc-list)) | 814 | (setq erc-dcc-list (delete elt erc-dcc-list)) |
| 815 | (set-buffer-modified-p nil) | 815 | (set-buffer-modified-p nil) |
| 816 | (kill-buffer (current-buffer)) | 816 | (delete-process proc) |
| 817 | (delete-process proc)) | 817 | (kill-buffer (current-buffer))) |
| 818 | ((<= confirmed-marker sent-marker) | 818 | ((<= confirmed-marker sent-marker) |
| 819 | (while (and (< (- sent-marker confirmed-marker) | 819 | (while (and (< (- sent-marker confirmed-marker) |
| 820 | (or erc-dcc-pump-bytes | 820 | (or erc-dcc-pump-bytes |
| @@ -827,8 +827,8 @@ bytes sent." | |||
| 827 | (marker-position confirmed-marker) | 827 | (marker-position confirmed-marker) |
| 828 | (marker-position sent-marker))) | 828 | (marker-position sent-marker))) |
| 829 | (set-buffer-modified-p nil) | 829 | (set-buffer-modified-p nil) |
| 830 | (kill-buffer (current-buffer)) | 830 | (delete-process proc) |
| 831 | (delete-process proc)))))) | 831 | (kill-buffer (current-buffer))))))) |
| 832 | 832 | ||
| 833 | (defun erc-dcc-display-send (proc) | 833 | (defun erc-dcc-display-send (proc) |
| 834 | (erc-display-message | 834 | (erc-display-message |
| @@ -978,8 +978,9 @@ rather than every 1024 byte block, but nobody seems to care." | |||
| 978 | (let ((inhibit-read-only t) | 978 | (let ((inhibit-read-only t) |
| 979 | received-bytes) | 979 | received-bytes) |
| 980 | (goto-char (point-max)) | 980 | (goto-char (point-max)) |
| 981 | (if str | 981 | (when str |
| 982 | (insert (string-make-unibyte str))) | 982 | (cl-assert (not (multibyte-string-p str))) |
| 983 | (insert str)) | ||
| 983 | 984 | ||
| 984 | (when (> (point-max) erc-dcc-receive-cache) | 985 | (when (> (point-max) erc-dcc-receive-cache) |
| 985 | (erc-dcc-append-contents (current-buffer) erc-dcc-file-name)) | 986 | (erc-dcc-append-contents (current-buffer) erc-dcc-file-name)) |