diff options
| author | Michael Albinus | 2018-04-06 11:49:21 +0200 |
|---|---|---|
| committer | Michael Albinus | 2018-04-06 11:49:21 +0200 |
| commit | 358da4565b589570759ddc9c2d1043405fdbb26e (patch) | |
| tree | 37d7cad51bcc7f0373d90169f0f0be00ff151092 | |
| parent | 10ef466a9eb621a3752de69930fcb14bf1af4887 (diff) | |
| download | emacs-358da4565b589570759ddc9c2d1043405fdbb26e.tar.gz emacs-358da4565b589570759ddc9c2d1043405fdbb26e.zip | |
Make dbus.el fitter for Emacs configured --without-dbus
* lisp/net/dbus.el (dbus-error, dbus-debug): Define if not exist.
* test/lisp/net/secrets-tests.el: Revert 51c8369fa2 and 79a3ad9592.
| -rw-r--r-- | lisp/net/dbus.el | 9 | ||||
| -rw-r--r-- | test/lisp/net/secrets-tests.el | 7 |
2 files changed, 9 insertions, 7 deletions
diff --git a/lisp/net/dbus.el b/lisp/net/dbus.el index f63ab9a15a8..2d9660d127f 100644 --- a/lisp/net/dbus.el +++ b/lisp/net/dbus.el | |||
| @@ -41,9 +41,16 @@ | |||
| 41 | (defvar dbus-message-type-method-return) | 41 | (defvar dbus-message-type-method-return) |
| 42 | (defvar dbus-message-type-error) | 42 | (defvar dbus-message-type-error) |
| 43 | (defvar dbus-message-type-signal) | 43 | (defvar dbus-message-type-signal) |
| 44 | (defvar dbus-debug) | ||
| 45 | (defvar dbus-registered-objects-table) | 44 | (defvar dbus-registered-objects-table) |
| 46 | 45 | ||
| 46 | ;; The following symbols are defined in dbusbind.c. We need them also | ||
| 47 | ;; when Emacs is compiled without D-Bus support. | ||
| 48 | (unless (boundp 'dbus-error) | ||
| 49 | (define-error 'dbus-error "D-Bus error")) | ||
| 50 | |||
| 51 | (unless (boundp 'dbus-debug) | ||
| 52 | (defvar dbus-debug nil)) | ||
| 53 | |||
| 47 | ;; Pacify byte compiler. | 54 | ;; Pacify byte compiler. |
| 48 | (eval-when-compile (require 'cl-lib)) | 55 | (eval-when-compile (require 'cl-lib)) |
| 49 | 56 | ||
diff --git a/test/lisp/net/secrets-tests.el b/test/lisp/net/secrets-tests.el index d0c0d6fe240..dc9c7f1004a 100644 --- a/test/lisp/net/secrets-tests.el +++ b/test/lisp/net/secrets-tests.el | |||
| @@ -20,7 +20,7 @@ | |||
| 20 | ;;; Code: | 20 | ;;; Code: |
| 21 | 21 | ||
| 22 | (require 'ert) | 22 | (require 'ert) |
| 23 | (when (featurep 'dbusbind) (require 'secrets)) | 23 | (require 'secrets) |
| 24 | (require 'notifications) | 24 | (require 'notifications) |
| 25 | 25 | ||
| 26 | ;; We do not want chatty messages. | 26 | ;; We do not want chatty messages. |
| @@ -28,7 +28,6 @@ | |||
| 28 | 28 | ||
| 29 | (ert-deftest secrets-test00-availability () | 29 | (ert-deftest secrets-test00-availability () |
| 30 | "Test availability of Secret Service API." | 30 | "Test availability of Secret Service API." |
| 31 | (skip-unless (featurep 'dbusbind)) | ||
| 32 | :expected-result (if secrets-enabled :passed :failed) | 31 | :expected-result (if secrets-enabled :passed :failed) |
| 33 | (should secrets-enabled) | 32 | (should secrets-enabled) |
| 34 | (should (dbus-ping :session secrets-service)) | 33 | (should (dbus-ping :session secrets-service)) |
| @@ -59,7 +58,6 @@ | |||
| 59 | 58 | ||
| 60 | (ert-deftest secrets-test01-sessions () | 59 | (ert-deftest secrets-test01-sessions () |
| 61 | "Test opening / closing a secrets session." | 60 | "Test opening / closing a secrets session." |
| 62 | (skip-unless (featurep 'dbusbind)) | ||
| 63 | (skip-unless secrets-enabled) | 61 | (skip-unless secrets-enabled) |
| 64 | (skip-unless (secrets-empty-path secrets-session-path)) | 62 | (skip-unless (secrets-empty-path secrets-session-path)) |
| 65 | 63 | ||
| @@ -85,7 +83,6 @@ | |||
| 85 | 83 | ||
| 86 | (ert-deftest secrets-test02-collections () | 84 | (ert-deftest secrets-test02-collections () |
| 87 | "Test creation / deletion a secrets collections." | 85 | "Test creation / deletion a secrets collections." |
| 88 | (skip-unless (featurep 'dbusbind)) | ||
| 89 | (skip-unless secrets-enabled) | 86 | (skip-unless secrets-enabled) |
| 90 | (skip-unless (secrets-empty-path secrets-session-path)) | 87 | (skip-unless (secrets-empty-path secrets-session-path)) |
| 91 | 88 | ||
| @@ -147,7 +144,6 @@ | |||
| 147 | 144 | ||
| 148 | (ert-deftest secrets-test03-items () | 145 | (ert-deftest secrets-test03-items () |
| 149 | "Test creation / deletion a secret item." | 146 | "Test creation / deletion a secret item." |
| 150 | (skip-unless (featurep 'dbusbind)) | ||
| 151 | (skip-unless secrets-enabled) | 147 | (skip-unless secrets-enabled) |
| 152 | (skip-unless (secrets-empty-path secrets-session-path)) | 148 | (skip-unless (secrets-empty-path secrets-session-path)) |
| 153 | 149 | ||
| @@ -189,7 +185,6 @@ | |||
| 189 | 185 | ||
| 190 | (ert-deftest secrets-test04-search () | 186 | (ert-deftest secrets-test04-search () |
| 191 | "Test searching of secret items." | 187 | "Test searching of secret items." |
| 192 | (skip-unless (featurep 'dbusbind)) | ||
| 193 | (skip-unless secrets-enabled) | 188 | (skip-unless secrets-enabled) |
| 194 | (skip-unless (secrets-empty-path secrets-session-path)) | 189 | (skip-unless (secrets-empty-path secrets-session-path)) |
| 195 | 190 | ||