diff options
| author | Glenn Morris | 2013-10-24 19:04:33 -0400 |
|---|---|---|
| committer | Glenn Morris | 2013-10-24 19:04:33 -0400 |
| commit | 357a508109504494cdc4a3fa0c53aca351890026 (patch) | |
| tree | efa328dbca98958a721f529c036c5102f875fed8 | |
| parent | 71e3276bc574257845c81c095d41ed58399089fe (diff) | |
| download | emacs-357a508109504494cdc4a3fa0c53aca351890026.tar.gz emacs-357a508109504494cdc4a3fa0c53aca351890026.zip | |
Avoid non-portable "` ... \"...\" ... `" nesting
* configure.ac:
* Makefile.in (install-arch-indep, install-etcdoc, install-info):
* lib-src/Makefile.in ($(DESTDIR)${archlibdir}):
* nt/Makefile.in ($(DESTDIR)${archlibdir}):
Avoid non-portable "`\" nesting.
| -rw-r--r-- | ChangeLog | 4 | ||||
| -rw-r--r-- | Makefile.in | 17 | ||||
| -rw-r--r-- | configure.ac | 9 | ||||
| -rw-r--r-- | lib-src/ChangeLog | 3 | ||||
| -rw-r--r-- | lib-src/Makefile.in | 3 | ||||
| -rw-r--r-- | nt/ChangeLog | 3 | ||||
| -rw-r--r-- | nt/Makefile.in | 3 |
7 files changed, 33 insertions, 9 deletions
| @@ -1,5 +1,9 @@ | |||
| 1 | 2013-10-24 Glenn Morris <rgm@gnu.org> | 1 | 2013-10-24 Glenn Morris <rgm@gnu.org> |
| 2 | 2 | ||
| 3 | * configure.ac: | ||
| 4 | * Makefile.in (install-arch-indep, install-etcdoc, install-info): | ||
| 5 | Avoid non-portable "`\" nesting. | ||
| 6 | |||
| 3 | * configure.ac (CPPFLAGS) [mingw32]: Use abs_top_srcdir. | 7 | * configure.ac (CPPFLAGS) [mingw32]: Use abs_top_srcdir. |
| 4 | 8 | ||
| 5 | * Makefile.in (abs_top_srcdir): New, set by configure. | 9 | * Makefile.in (abs_top_srcdir): New, set by configure. |
diff --git a/Makefile.in b/Makefile.in index 1a92ca8aaf3..2c854fd9ae0 100644 --- a/Makefile.in +++ b/Makefile.in | |||
| @@ -571,9 +571,11 @@ install-arch-indep: lisp leim install-info install-man ${INSTALL_ARCH_INDEP_EXTR | |||
| 571 | for dir in ${COPYDIR} ; do \ | 571 | for dir in ${COPYDIR} ; do \ |
| 572 | [ -d $${dir} ] || exit 1 ; \ | 572 | [ -d $${dir} ] || exit 1 ; \ |
| 573 | dest="$$1" ; shift ; \ | 573 | dest="$$1" ; shift ; \ |
| 574 | [ -d "$${dest}" ] && \ | 574 | if [ -d "$${dest}" ]; then \ |
| 575 | [ "`cd \"$${dest}\" && /bin/pwd`" = "`cd $${dir} && /bin/pwd`" ] && \ | 575 | exp_dest=`cd "$${dest}" && /bin/pwd`; \ |
| 576 | continue ; \ | 576 | [ "$$exp_dest" = "`cd $${dir} && /bin/pwd`" ] && continue ; \ |
| 577 | else true; \ | ||
| 578 | fi; \ | ||
| 577 | if [ "$${dir}" = "leim/quail" ]; then \ | 579 | if [ "$${dir}" = "leim/quail" ]; then \ |
| 578 | [ "`cd $${dir} && /bin/pwd`" = "`cd ${srcdir}/leim/quail && /bin/pwd`" ] && \ | 580 | [ "`cd $${dir} && /bin/pwd`" = "`cd ${srcdir}/leim/quail && /bin/pwd`" ] && \ |
| 579 | continue ; \ | 581 | continue ; \ |
| @@ -623,7 +625,8 @@ install-arch-indep: lisp leim install-info install-man ${INSTALL_ARCH_INDEP_EXTR | |||
| 623 | cd "$${thisdir}" ; \ | 625 | cd "$${thisdir}" ; \ |
| 624 | cd "$${dir}" || exit 1 ; \ | 626 | cd "$${dir}" || exit 1 ; \ |
| 625 | for f in `find . -name "*.elc" -print`; do \ | 627 | for f in `find . -name "*.elc" -print`; do \ |
| 626 | ${GZIP_PROG} -9n "`echo \"$$f\" | sed 's/.elc$$/.el/'`" ; \ | 628 | f_el=`echo "$$f" | sed 's/.elc$$/.el/'`; \ |
| 629 | ${GZIP_PROG} -9n "$$f_el" ; \ | ||
| 627 | done ; \ | 630 | done ; \ |
| 628 | done ) | 631 | done ) |
| 629 | -chmod -R a+r "$(DESTDIR)${datadir}/emacs/${version}" ${COPYDESTS} | 632 | -chmod -R a+r "$(DESTDIR)${datadir}/emacs/${version}" ${COPYDESTS} |
| @@ -637,7 +640,8 @@ install-arch-indep: lisp leim install-info install-man ${INSTALL_ARCH_INDEP_EXTR | |||
| 637 | install-etcdoc: src install-arch-indep | 640 | install-etcdoc: src install-arch-indep |
| 638 | -unset CDPATH; \ | 641 | -unset CDPATH; \ |
| 639 | umask 022; ${MKDIR_P} "$(DESTDIR)${etcdocdir}" ; \ | 642 | umask 022; ${MKDIR_P} "$(DESTDIR)${etcdocdir}" ; \ |
| 640 | if [ "`cd ./etc; /bin/pwd`" != "`cd \"$(DESTDIR)${etcdocdir}\"; /bin/pwd`" ]; \ | 643 | exp_etcdocdir=`cd "$(DESTDIR)${etcdocdir}"; /bin/pwd`; \ |
| 644 | if [ "`cd ./etc; /bin/pwd`" != "$$exp_etcdocdir" ]; \ | ||
| 641 | then \ | 645 | then \ |
| 642 | docfile="DOC"; \ | 646 | docfile="DOC"; \ |
| 643 | echo "Copying etc/$${docfile} to $(DESTDIR)${etcdocdir} ..." ; \ | 647 | echo "Copying etc/$${docfile} to $(DESTDIR)${etcdocdir} ..." ; \ |
| @@ -650,7 +654,8 @@ install-info: info | |||
| 650 | umask 022; ${MKDIR_P} "$(DESTDIR)${infodir}" | 654 | umask 022; ${MKDIR_P} "$(DESTDIR)${infodir}" |
| 651 | -unset CDPATH; \ | 655 | -unset CDPATH; \ |
| 652 | thisdir=`/bin/pwd`; \ | 656 | thisdir=`/bin/pwd`; \ |
| 653 | if [ "`cd ${srcdir}/info && /bin/pwd`" = "`cd \"$(DESTDIR)${infodir}\" && /bin/pwd`" ]; then \ | 657 | exp_infodir=`cd "$(DESTDIR)${infodir}" && /bin/pwd`; \ |
| 658 | if [ "`cd ${srcdir}/info && /bin/pwd`" = "$$exp_infodir" ]; then \ | ||
| 654 | true; \ | 659 | true; \ |
| 655 | else \ | 660 | else \ |
| 656 | (cd "$(DESTDIR)${infodir}"; \ | 661 | (cd "$(DESTDIR)${infodir}"; \ |
diff --git a/configure.ac b/configure.ac index e73775e69a7..7d8cb8815fd 100644 --- a/configure.ac +++ b/configure.ac | |||
| @@ -78,7 +78,14 @@ dnl I think we have to check, eg, both exec_prefix and bindir, | |||
| 78 | dnl because the latter by default is not yet expanded, but the user | 78 | dnl because the latter by default is not yet expanded, but the user |
| 79 | dnl may have specified a value for it via --bindir. | 79 | dnl may have specified a value for it via --bindir. |
| 80 | dnl Note that abs_srcdir and abs_builddir are not yet defined. :( | 80 | dnl Note that abs_srcdir and abs_builddir are not yet defined. :( |
| 81 | for var in "`pwd`" "`cd \"$srcdir\"; pwd`" "$prefix" "$exec_prefix" \ | 81 | |
| 82 | dnl "`cd \"$srcdir\" is not portable. | ||
| 83 | dnl See autoconf manual "Shell Substitutions": | ||
| 84 | dnl "There is just no portable way to use double-quoted strings inside | ||
| 85 | dnl double-quoted back-quoted expressions (pfew!)." | ||
| 86 | temp_srcdir=`cd "$srcdir"; pwd` | ||
| 87 | |||
| 88 | for var in "`pwd`" "$temp_srcdir" "$prefix" "$exec_prefix" \ | ||
| 82 | "$datarootdir" "$bindir" "$datadir" "$sharedstatedir" "$libexecdir"; do | 89 | "$datarootdir" "$bindir" "$datadir" "$sharedstatedir" "$libexecdir"; do |
| 83 | 90 | ||
| 84 | dnl configure sets LC_ALL=C early on, so this range should work. | 91 | dnl configure sets LC_ALL=C early on, so this range should work. |
diff --git a/lib-src/ChangeLog b/lib-src/ChangeLog index 35672f22d64..44d7260dead 100644 --- a/lib-src/ChangeLog +++ b/lib-src/ChangeLog | |||
| @@ -1,5 +1,8 @@ | |||
| 1 | 2013-10-24 Glenn Morris <rgm@gnu.org> | 1 | 2013-10-24 Glenn Morris <rgm@gnu.org> |
| 2 | 2 | ||
| 3 | * Makefile.in ($(DESTDIR)${archlibdir}): | ||
| 4 | Avoid non-portable "`\" nesting. | ||
| 5 | |||
| 3 | * Makefile.in (abs_top_srcdir): New, set by configure. | 6 | * Makefile.in (abs_top_srcdir): New, set by configure. |
| 4 | 7 | ||
| 5 | 2013-10-23 Glenn Morris <rgm@gnu.org> | 8 | 2013-10-23 Glenn Morris <rgm@gnu.org> |
diff --git a/lib-src/Makefile.in b/lib-src/Makefile.in index 3843f549679..b765668aebc 100644 --- a/lib-src/Makefile.in +++ b/lib-src/Makefile.in | |||
| @@ -234,7 +234,8 @@ $(DESTDIR)${archlibdir}: all | |||
| 234 | @echo | 234 | @echo |
| 235 | @echo "Installing utilities run internally by Emacs." | 235 | @echo "Installing utilities run internally by Emacs." |
| 236 | umask 022; ${MKDIR_P} "$(DESTDIR)${archlibdir}" | 236 | umask 022; ${MKDIR_P} "$(DESTDIR)${archlibdir}" |
| 237 | if [ "`cd \"$(DESTDIR)${archlibdir}\" && /bin/pwd`" != "`/bin/pwd`" ]; then \ | 237 | exp_archlibdir=`cd "$(DESTDIR)${archlibdir}" && /bin/pwd`; \ |
| 238 | if [ "$$exp_archlibdir" != "`/bin/pwd`" ]; then \ | ||
| 238 | for file in ${UTILITIES}; do \ | 239 | for file in ${UTILITIES}; do \ |
| 239 | $(INSTALL_PROGRAM) $(INSTALL_STRIP) $$file "$(DESTDIR)${archlibdir}/$$file" ; \ | 240 | $(INSTALL_PROGRAM) $(INSTALL_STRIP) $$file "$(DESTDIR)${archlibdir}/$$file" ; \ |
| 240 | done ; \ | 241 | done ; \ |
diff --git a/nt/ChangeLog b/nt/ChangeLog index 12389607627..a1cac150cac 100644 --- a/nt/ChangeLog +++ b/nt/ChangeLog | |||
| @@ -1,5 +1,8 @@ | |||
| 1 | 2013-10-24 Glenn Morris <rgm@gnu.org> | 1 | 2013-10-24 Glenn Morris <rgm@gnu.org> |
| 2 | 2 | ||
| 3 | * Makefile.in ($(DESTDIR)${archlibdir}): | ||
| 4 | Avoid non-portable "`\" nesting. | ||
| 5 | |||
| 3 | * Makefile.in (abs_top_srcdir): New, set by configure. | 6 | * Makefile.in (abs_top_srcdir): New, set by configure. |
| 4 | 7 | ||
| 5 | 2013-10-23 Glenn Morris <rgm@gnu.org> | 8 | 2013-10-23 Glenn Morris <rgm@gnu.org> |
diff --git a/nt/Makefile.in b/nt/Makefile.in index 8bd37e7983c..17fef43e26d 100644 --- a/nt/Makefile.in +++ b/nt/Makefile.in | |||
| @@ -144,7 +144,8 @@ $(DESTDIR)${archlibdir}: all | |||
| 144 | @echo | 144 | @echo |
| 145 | @echo "Installing utilities run internally by Emacs." | 145 | @echo "Installing utilities run internally by Emacs." |
| 146 | umask 022; ${MKDIR_P} "$(DESTDIR)${archlibdir}" | 146 | umask 022; ${MKDIR_P} "$(DESTDIR)${archlibdir}" |
| 147 | if [ "`cd \"$(DESTDIR)${archlibdir}\" && /bin/pwd`" != "`/bin/pwd`" ]; then \ | 147 | exp_archlibdir=`cd "$(DESTDIR)${archlibdir}" && /bin/pwd`; \ |
| 148 | if [ "$$exp_archlibdir" != "`/bin/pwd`" ]; then \ | ||
| 148 | for file in ${UTILITIES}; do \ | 149 | for file in ${UTILITIES}; do \ |
| 149 | $(INSTALL_PROGRAM) $(INSTALL_STRIP) $$file "$(DESTDIR)${archlibdir}/$$file" ; \ | 150 | $(INSTALL_PROGRAM) $(INSTALL_STRIP) $$file "$(DESTDIR)${archlibdir}/$$file" ; \ |
| 150 | done ; \ | 151 | done ; \ |