diff options
| author | Stefan Monnier | 2019-01-08 11:28:00 -0500 |
|---|---|---|
| committer | Stefan Monnier | 2019-01-08 11:28:00 -0500 |
| commit | 35224ac3aebd4c55a4cdccea908a62f92aaebf25 (patch) | |
| tree | f81861273b53237d009aa73c576472a653927078 | |
| parent | 55c5e26307a1e8f1fff74415fc560aa172a421cf (diff) | |
| download | emacs-35224ac3aebd4c55a4cdccea908a62f92aaebf25.tar.gz emacs-35224ac3aebd4c55a4cdccea908a62f92aaebf25.zip | |
* lisp/help-fns.el (help--load-prefixes): Demote errors from files.
| -rw-r--r-- | lisp/help-fns.el | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/lisp/help-fns.el b/lisp/help-fns.el index 04bb31485d6..b4e93d36d4c 100644 --- a/lisp/help-fns.el +++ b/lisp/help-fns.el | |||
| @@ -68,6 +68,9 @@ The functions will receive the function name as argument.") | |||
| 68 | 68 | ||
| 69 | (defun help--loaded-p (file) | 69 | (defun help--loaded-p (file) |
| 70 | "Try and figure out if FILE has already been loaded." | 70 | "Try and figure out if FILE has already been loaded." |
| 71 | ;; FIXME: this regexp business is not good enough: for file | ||
| 72 | ;; `toto', it will say `toto' is loaded when in reality it was | ||
| 73 | ;; just cedet/semantic/toto that has been loaded. | ||
| 71 | (or (let ((feature (intern-soft file))) | 74 | (or (let ((feature (intern-soft file))) |
| 72 | (and feature (featurep feature))) | 75 | (and feature (featurep feature))) |
| 73 | (let* ((re (load-history-regexp file)) | 76 | (let* ((re (load-history-regexp file)) |
| @@ -83,11 +86,9 @@ The functions will receive the function name as argument.") | |||
| 83 | (dolist (file files) | 86 | (dolist (file files) |
| 84 | ;; FIXME: Should we scan help-definition-prefixes to remove | 87 | ;; FIXME: Should we scan help-definition-prefixes to remove |
| 85 | ;; other prefixes of the same file? | 88 | ;; other prefixes of the same file? |
| 86 | ;; FIXME: this regexp business is not good enough: for file | ||
| 87 | ;; `toto', it will say `toto' is loaded when in reality it was | ||
| 88 | ;; just cedet/semantic/toto that has been loaded. | ||
| 89 | (unless (help--loaded-p file) | 89 | (unless (help--loaded-p file) |
| 90 | (load file 'noerror 'nomessage))))) | 90 | (with-demoted-errors "while loading: %S" |
| 91 | (load file 'noerror 'nomessage)))))) | ||
| 91 | 92 | ||
| 92 | (defun help--symbol-completion-table (string pred action) | 93 | (defun help--symbol-completion-table (string pred action) |
| 93 | (let ((prefixes (radix-tree-prefixes (help-definition-prefixes) string))) | 94 | (let ((prefixes (radix-tree-prefixes (help-definition-prefixes) string))) |