nav + text edit

2 files changed, 27 insertions, 12 deletions

diff --git a/README.xwidget b/README.xwidget
index 2fdec89deb4..0e1ebbd3e7e 100644
--- a/README.xwidget
+++ b/README.xwidget
@@ -1496,6 +1496,27 @@ hook so anything can filter browser history.
 ** TODO new relative url code sometimes fail
 http://www.dilbert.com
 ** TODO input field enhancements
-- password field
-- textarea 
-
+*** password field. 
+was straightforward
+
+*** textarea 
+less straightforward. I would like it to work like emacs-w3m, where a
+new editing buffer is opened. on c-c, the buffer is closed and the
+browser field updated. however, it's not immediately obvious how to
+store the reference to the field reliably.
+
+furthermore the current code doesn't seem to propagate linefeed
+properly to text areas.
+
+** DONE bug in current navigation handler
+   CLOSED: [2011-11-09 Wed 10:04]
+on www.dn.se
+Debugger entered--Lisp error: (args-out-of-range "http://platform.twitter.com/widgets/hub.html" 54 357)
+  match-string(1 "http://platform.twitter.com/widgets/hub.html")
+  xwidget-webkit-callback(48890368 navigation-policy-decision-requested)
+  xwidget-event-handler()
+  call-interactively(xwidget-event-handler nil nil)
+** TODO how to set the name of a webkit buffer?
+not obvious because, the buffer isn't created immediately and there is
+a callback that sets the buffer name automatically
+** TODO how to find next field in tab order?a
diff --git a/lisp/xwidget.el b/lisp/xwidget.el
index 3f20914f88c..8ed0c72f296 100644
--- a/lisp/xwidget.el
+++ b/lisp/xwidget.el
@@ -166,14 +166,8 @@ defaults to the string looking like a url around the cursor position."
              )
             
             ((eq xwidget-event-type 'navigation-policy-decision-requested)
-             (let ((elmid (progn                   (string-match ".*#\\(.*\\)" strarg)(match-string 1 strarg))))
-                   (message "navigation-policy-decision-requested: '%s' %s"  strarg  elmid       )
-
-                   (if elmid (xwidget-webkit-show-id-or-named-element xwidget elmid))
-                   )
-
-             )
-            ))))
+             (if (string-match ".*#\\(.*\\)" strarg)
+                 (xwidget-webkit-show-id-or-named-element xwidget (match-string 1 strarg))))))))
 
 (define-derived-mode xwidget-webkit-mode
   special-mode "xwidget-webkit" "xwidget webkit view mode"
@@ -254,7 +248,7 @@ Argument STR string."
      (list xww
            (cond ( (equal "text" field-type) (read-string "text:" field-value))
                  ( (equal "password" field-type) (read-passwd "password:" nil field-value))
-                 ( (equal "textarea" field-type) (read-textarea "textarea:" field-value))
+                 ( (equal "textarea" field-type) (read-string "textarea:" field-value))
                  ))))
   (xwidget-webkit-execute-script xw (format "findactiveelement(document).value='%s'" str)))