diff options
| author | Eli Zaretskii | 2016-03-25 10:45:39 +0300 |
|---|---|---|
| committer | Eli Zaretskii | 2016-03-25 10:45:39 +0300 |
| commit | 326c64fcc37cdb31183ec62d5535ec0a52c4738e (patch) | |
| tree | baa97b7ac79e07463c18f74be2a55ccddfc402e2 | |
| parent | 7ab2a9743faca2ddde04ea2e6127badac9ce1bb1 (diff) | |
| download | emacs-326c64fcc37cdb31183ec62d5535ec0a52c4738e.tar.gz emacs-326c64fcc37cdb31183ec62d5535ec0a52c4738e.zip | |
Fix splash screen display at startup
* src/frame.c (DEFAULT_ROWS): Enlarge to 36, so that the initial
window displayed by "emacs -q" has enough space to show the whole
text even if it includes 2 lines talking about recovering crashes
sessions. (Bug#23074)
* lisp/startup.el (use-fancy-splash-screens-p): Fix off-by-one
error when computing the window-height from frame-height.
* etc/NEWS: Mention the change.
| -rw-r--r-- | etc/NEWS | 6 | ||||
| -rw-r--r-- | lisp/startup.el | 10 | ||||
| -rw-r--r-- | src/frame.c | 2 |
3 files changed, 13 insertions, 5 deletions
| @@ -123,6 +123,12 @@ command line when 'initial-buffer-choice' is non-nil. | |||
| 123 | ** The value of 'initial-scratch-message' is now treated as a doc string | 123 | ** The value of 'initial-scratch-message' is now treated as a doc string |
| 124 | and can contain escape sequences for command keys, quotes, and the like. | 124 | and can contain escape sequences for command keys, quotes, and the like. |
| 125 | 125 | ||
| 126 | --- | ||
| 127 | ** The default height of GUI frames was enlarged. | ||
| 128 | This is so there's enough space in the initial window to display the | ||
| 129 | optional text about recovering crashes sessions, without losing the | ||
| 130 | splash image display. | ||
| 131 | |||
| 126 | 132 | ||
| 127 | * Changes in Emacs 25.1 | 133 | * Changes in Emacs 25.1 |
| 128 | 134 | ||
diff --git a/lisp/startup.el b/lisp/startup.el index 15a79f6f5bf..536289c3891 100644 --- a/lisp/startup.el +++ b/lisp/startup.el | |||
| @@ -1890,10 +1890,12 @@ we put it on this frame." | |||
| 1890 | (when frame | 1890 | (when frame |
| 1891 | (let* ((img (create-image (fancy-splash-image-file))) | 1891 | (let* ((img (create-image (fancy-splash-image-file))) |
| 1892 | (image-height (and img (cdr (image-size img nil frame)))) | 1892 | (image-height (and img (cdr (image-size img nil frame)))) |
| 1893 | ;; We test frame-height so that, if the frame is split | 1893 | ;; We test frame-height and not window-height so that, |
| 1894 | ;; by displaying a warning, that doesn't cause the normal | 1894 | ;; if the frame is split by displaying a warning, that |
| 1895 | ;; splash screen to be used. | 1895 | ;; doesn't cause the normal splash screen to be used. |
| 1896 | (frame-height (1- (frame-height frame)))) | 1896 | ;; We subtract 2 from frame-height to account for the |
| 1897 | ;; echo area and the mode line. | ||
| 1898 | (frame-height (- (frame-height frame) 2))) | ||
| 1897 | (> frame-height (+ image-height 19))))))) | 1899 | (> frame-height (+ image-height 19))))))) |
| 1898 | 1900 | ||
| 1899 | 1901 | ||
diff --git a/src/frame.c b/src/frame.c index 7511d5323ca..53ff05965c1 100644 --- a/src/frame.c +++ b/src/frame.c | |||
| @@ -4565,7 +4565,7 @@ On Nextstep, this just calls `ns-parse-geometry'. */) | |||
| 4565 | 4565 | ||
| 4566 | This function does not make the coordinates positive. */ | 4566 | This function does not make the coordinates positive. */ |
| 4567 | 4567 | ||
| 4568 | #define DEFAULT_ROWS 35 | 4568 | #define DEFAULT_ROWS 36 |
| 4569 | #define DEFAULT_COLS 80 | 4569 | #define DEFAULT_COLS 80 |
| 4570 | 4570 | ||
| 4571 | long | 4571 | long |