aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAndré Spiegel2006-01-25 18:58:45 +0000
committerAndré Spiegel2006-01-25 18:58:45 +0000
commit3204f203491a257246d3d8ea2364feb7d3a8ac19 (patch)
tree21a770392885f8d397c2a8a640e2b118e2142915
parent510f6466f331fa1e7d924f41ca5cde1eea430dc6 (diff)
downloademacs-3204f203491a257246d3d8ea2364feb7d3a8ac19.tar.gz
emacs-3204f203491a257246d3d8ea2364feb7d3a8ac19.zip
(vc-user-login-name): Comment out defadvice, it is no longer
necessary.
-rw-r--r--lisp/net/tramp-vc.el37
1 files changed, 20 insertions, 17 deletions
diff --git a/lisp/net/tramp-vc.el b/lisp/net/tramp-vc.el
index 368d85c8e57..b672ada295c 100644
--- a/lisp/net/tramp-vc.el
+++ b/lisp/net/tramp-vc.el
@@ -436,23 +436,26 @@ filename we are thinking about..."
436 (t (error "tramp-handle-vc-user-login-name cannot cope!"))))))) 436 (t (error "tramp-handle-vc-user-login-name cannot cope!")))))))
437 437
438 438
439(defadvice vc-user-login-name 439;; The following defadvice is no longer necessary after changes in VC
440 (around tramp-vc-user-login-name activate) 440;; on 2006-01-25, Andre.
441 "Support for files on remote machines accessed by TRAMP." 441
442 ;; We rely on the fact that `file' is bound when this is called. 442;; (defadvice vc-user-login-name
443 ;; This appears to be the case everywhere in vc.el and vc-hooks.el 443;; (around tramp-vc-user-login-name activate)
444 ;; as of Emacs 20.5. 444;; "Support for files on remote machines accessed by TRAMP."
445 ;; 445;; ;; We rely on the fact that `file' is bound when this is called.
446 ;; CCC TODO there should be a real solution! Talk to Andre Spiegel 446;; ;; This appears to be the case everywhere in vc.el and vc-hooks.el
447 ;; about this. 447;; ;; as of Emacs 20.5.
448 (let ((file (when (boundp 'file) 448;; ;;
449 (symbol-value 'file)))) ;pacify byte-compiler 449;; ;; CCC TODO there should be a real solution! Talk to Andre Spiegel
450 (or (and (stringp file) 450;; ;; about this.
451 (tramp-tramp-file-p file) ; tramp file 451;; (let ((file (when (boundp 'file)
452 (setq ad-return-value 452;; (symbol-value 'file)))) ;pacify byte-compiler
453 (save-match-data 453;; (or (and (stringp file)
454 (tramp-handle-vc-user-login-name uid)))) ; get the owner name 454;; (tramp-tramp-file-p file) ; tramp file
455 ad-do-it))) ; else call the original 455;; (setq ad-return-value
456;; (save-match-data
457;; (tramp-handle-vc-user-login-name uid)))) ; get the owner name
458;; ad-do-it))) ; else call the original
456 459
457(add-hook 'tramp-unload-hook 460(add-hook 'tramp-unload-hook
458 '(lambda () (ad-unadvise 'vc-user-login-name))) 461 '(lambda () (ad-unadvise 'vc-user-login-name)))