aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMarkus Rost2003-01-09 22:32:48 +0000
committerMarkus Rost2003-01-09 22:32:48 +0000
commit2de2cb02c92c915fd9ba9060ff6c63180591af7b (patch)
treecbc5ca2c3334d2ec0bfceb262ed1ea1c37c65351
parent4fdb45538890d6016e38f100ac1567409ef27e90 (diff)
downloademacs-2de2cb02c92c915fd9ba9060ff6c63180591af7b.tar.gz
emacs-2de2cb02c92c915fd9ba9060ff6c63180591af7b.zip
(customize-group, customize-group-other-window):
Remove unnecessary calls to custom-load-symbol. (custom-group-value-create): Load widget deps if state is not hidden. If widget deps are loaded, load them in advance. (custom-menu-create): If widget deps are loaded, load them earlier.
-rw-r--r--lisp/ChangeLog9
-rw-r--r--lisp/cus-edit.el11
2 files changed, 14 insertions, 6 deletions
diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index cd9f05c2579..cff51898e3a 100644
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,3 +1,12 @@
12003-01-09 Markus Rost <rost@math.ohio-state.edu>
2
3 * cus-edit.el (customize-group, customize-group-other-window):
4 Remove unnecessary calls to custom-load-symbol.
5 (custom-group-value-create):
6 Load widget deps if state is not hidden. If widget deps are
7 loaded, load them in advance.
8 (custom-menu-create): If widget deps are loaded, load them earlier.
9
12003-01-09 John Paul Wallington <jpw@shootybangbang.com> 102003-01-09 John Paul Wallington <jpw@shootybangbang.com>
2 11
3 * language/ethio-util.el (ethio-gemination) 12 * language/ethio-util.el (ethio-gemination)
diff --git a/lisp/cus-edit.el b/lisp/cus-edit.el
index 6017e7b9adf..b13c7965882 100644
--- a/lisp/cus-edit.el
+++ b/lisp/cus-edit.el
@@ -874,7 +874,6 @@ then prompt for the MODE to customize."
874 (if (string-equal "" group) 874 (if (string-equal "" group)
875 (setq group 'emacs) 875 (setq group 'emacs)
876 (setq group (intern group)))) 876 (setq group (intern group))))
877 (custom-load-symbol group)
878 (let ((name (format "*Customize Group: %s*" 877 (let ((name (format "*Customize Group: %s*"
879 (custom-unlispify-tag-name group)))) 878 (custom-unlispify-tag-name group))))
880 (if (get-buffer name) 879 (if (get-buffer name)
@@ -898,7 +897,6 @@ then prompt for the MODE to customize."
898 (if (string-equal "" group) 897 (if (string-equal "" group)
899 (setq group 'emacs) 898 (setq group 'emacs)
900 (setq group (intern group)))) 899 (setq group (intern group))))
901 (custom-load-symbol group)
902 (let ((name (format "*Customize Group: %s*" 900 (let ((name (format "*Customize Group: %s*"
903 (custom-unlispify-tag-name group)))) 901 (custom-unlispify-tag-name group))))
904 (if (get-buffer name) 902 (if (get-buffer name)
@@ -3301,6 +3299,8 @@ If GROUPS-ONLY non-nil, return only those members that are groups."
3301 3299
3302(defun custom-group-value-create (widget) 3300(defun custom-group-value-create (widget)
3303 "Insert a customize group for WIDGET in the current buffer." 3301 "Insert a customize group for WIDGET in the current buffer."
3302 (unless (eq (widget-get widget :custom-state) 'hidden)
3303 (custom-load-widget widget))
3304 (let* ((state (widget-get widget :custom-state)) 3304 (let* ((state (widget-get widget :custom-state))
3305 (level (widget-get widget :custom-level)) 3305 (level (widget-get widget :custom-level))
3306 ;; (indent (widget-get widget :indent)) 3306 ;; (indent (widget-get widget :indent))
@@ -3340,7 +3340,6 @@ If GROUPS-ONLY non-nil, return only those members that are groups."
3340 (widget-put widget :buttons buttons)) 3340 (widget-put widget :buttons buttons))
3341 ((eq custom-buffer-style 'tree) 3341 ((eq custom-buffer-style 'tree)
3342 (custom-browse-insert-prefix prefix) 3342 (custom-browse-insert-prefix prefix)
3343 (custom-load-widget widget)
3344 (if (zerop (length members)) 3343 (if (zerop (length members))
3345 (progn 3344 (progn
3346 (custom-browse-insert-prefix prefix) 3345 (custom-browse-insert-prefix prefix)
@@ -3481,7 +3480,6 @@ If GROUPS-ONLY non-nil, return only those members that are groups."
3481 ?\ )) 3480 ?\ ))
3482 ;; Members. 3481 ;; Members.
3483 (message "Creating group...") 3482 (message "Creating group...")
3484 (custom-load-widget widget)
3485 (let* ((members (custom-sort-items members 3483 (let* ((members (custom-sort-items members
3486 custom-buffer-sort-alphabetically 3484 custom-buffer-sort-alphabetically
3487 custom-buffer-order-groups)) 3485 custom-buffer-order-groups))
@@ -3953,13 +3951,14 @@ The menu is in a format applicable to `easy-menu-define'."
3953 t))) 3951 t)))
3954 (if (and (or (not (boundp 'custom-menu-nesting)) 3952 (if (and (or (not (boundp 'custom-menu-nesting))
3955 (>= custom-menu-nesting 0)) 3953 (>= custom-menu-nesting 0))
3956 (< (length (get symbol 'custom-group)) widget-menu-max-size)) 3954 (progn
3955 (custom-load-symbol symbol)
3956 (< (length (get symbol 'custom-group)) widget-menu-max-size)))
3957 (let ((custom-prefix-list (custom-prefix-add symbol 3957 (let ((custom-prefix-list (custom-prefix-add symbol
3958 custom-prefix-list)) 3958 custom-prefix-list))
3959 (members (custom-sort-items (get symbol 'custom-group) 3959 (members (custom-sort-items (get symbol 'custom-group)
3960 custom-menu-sort-alphabetically 3960 custom-menu-sort-alphabetically
3961 custom-menu-order-groups))) 3961 custom-menu-order-groups)))
3962 (custom-load-symbol symbol)
3963 `(,(custom-unlispify-menu-entry symbol t) 3962 `(,(custom-unlispify-menu-entry symbol t)
3964 ,item 3963 ,item
3965 "--" 3964 "--"