aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJoakim Verona2012-07-08 18:34:48 +0200
committerJoakim Verona2012-07-08 18:34:48 +0200
commit239765167f98ef617011040c50ca184d847d0bf9 (patch)
treec45defde3a9e869979d34a0fd82bc3cab7e62028
parente50c9e77aa23f4e95aaac8a492e5aa7fae8f3137 (diff)
downloademacs-239765167f98ef617011040c50ca184d847d0bf9.tar.gz
emacs-239765167f98ef617011040c50ca184d847d0bf9.zip
tiny cosmetic fixes in the C code
-rw-r--r--src/xwidget.c124
1 files changed, 71 insertions, 53 deletions
diff --git a/src/xwidget.c b/src/xwidget.c
index a1659a9911d..9a2c0d38a7b 100644
--- a/src/xwidget.c
+++ b/src/xwidget.c
@@ -370,23 +370,26 @@ xwidget_hide_view (struct xwidget_view *xv)
370} 370}
371 371
372 372
373void xwidget_plug_added(GtkSocket *socket, 373void
374 gpointer user_data) 374xwidget_plug_added(GtkSocket *socket,
375 gpointer user_data)
375{ 376{
376 //hmm this doesnt seem to get called for foreign windows 377 //hmm this doesnt seem to get called for foreign windows
377 printf("xwidget_plug_added\n"); 378 printf("xwidget_plug_added\n");
378} 379}
379 380
380gboolean xwidget_plug_removed(GtkSocket *socket, 381gboolean
381 gpointer user_data) 382xwidget_plug_removed(GtkSocket *socket,
383 gpointer user_data)
382{ 384{
383 printf("xwidget_plug_removed\n"); 385 printf("xwidget_plug_removed\n");
384 return TRUE; /* dont run the default handler because that kills the socket and we want to reuse it*/ 386 return TRUE; /* dont run the default handler because that kills the socket and we want to reuse it*/
385} 387}
386 388
387 389
388void xwidget_slider_changed (GtkRange *range, 390void
389 gpointer user_data) 391xwidget_slider_changed (GtkRange *range,
392 gpointer user_data)
390{ 393{
391 //slider value changed. change value of siblings 394 //slider value changed. change value of siblings
392 //correspondingly. but remember that changing value will again 395 //correspondingly. but remember that changing value will again
@@ -428,7 +431,8 @@ void xwidget_slider_changed (GtkRange *range,
428 431
429/* when the off-screen webkit master view changes this signal is called. 432/* when the off-screen webkit master view changes this signal is called.
430 it copies the bitmap from the off-screen webkit instance */ 433 it copies the bitmap from the off-screen webkit instance */
431gboolean webkit_osr_damage_event_callback (GtkWidget *widget, GdkEventExpose *event, gpointer data) 434gboolean
435webkit_osr_damage_event_callback (GtkWidget *widget, GdkEventExpose *event, gpointer data)
432{ 436{
433 //TODO this is wrong! should just oueu a redraw of onscreen widget 437 //TODO this is wrong! should just oueu a redraw of onscreen widget
434 struct xwidget* xw = (struct xwidget*) g_object_get_data (G_OBJECT (widget), XG_XWIDGET); 438 struct xwidget* xw = (struct xwidget*) g_object_get_data (G_OBJECT (widget), XG_XWIDGET);
@@ -448,7 +452,8 @@ gboolean webkit_osr_damage_event_callback (GtkWidget *widget, GdkEventExpose *ev
448 452
449 453
450 454
451gboolean webkit_osr_key_event_callback (GtkWidget *widget, GdkEventKey *event, gpointer data) 455gboolean
456webkit_osr_key_event_callback (GtkWidget *widget, GdkEventKey *event, gpointer data)
452{ 457{
453 printf("terminating a webkit osr keypress\n"); 458 printf("terminating a webkit osr keypress\n");
454 //TRUE terminate the event here. no paren handlers will be called. but webkit then doesng get the event and it still crashes 459 //TRUE terminate the event here. no paren handlers will be called. but webkit then doesng get the event and it still crashes
@@ -457,7 +462,9 @@ gboolean webkit_osr_key_event_callback (GtkWidget *widget, GdkEventKey *event, g
457} 462}
458 463
459 464
460void store_xwidget_event_string(struct xwidget* xw, char* eventname,char* eventstr){ 465void
466store_xwidget_event_string(struct xwidget* xw, char* eventname,char* eventstr)
467{
461 //refactor attempt 468 //refactor attempt
462 struct input_event event; 469 struct input_event event;
463 Lisp_Object xwl; 470 Lisp_Object xwl;
@@ -475,7 +482,8 @@ void store_xwidget_event_string(struct xwidget* xw, char* eventname,char* events
475} 482}
476 483
477//TODO deprecated, use load-status 484//TODO deprecated, use load-status
478void webkit_osr_document_load_finished_callback (WebKitWebView *webkitwebview, 485void
486webkit_osr_document_load_finished_callback (WebKitWebView *webkitwebview,
479 WebKitWebFrame *arg1, 487 WebKitWebFrame *arg1,
480 gpointer data) 488 gpointer data)
481{ 489{
@@ -488,7 +496,8 @@ void webkit_osr_document_load_finished_callback (WebKitWebView *webkitwebvi
488 "document-load-finished", ""); 496 "document-load-finished", "");
489} 497}
490 498
491gboolean webkit_osr_download_callback (WebKitWebView *webkitwebview, 499gboolean
500webkit_osr_download_callback (WebKitWebView *webkitwebview,
492 WebKitDownload *arg1, 501 WebKitDownload *arg1,
493 gpointer data) 502 gpointer data)
494{ 503{
@@ -506,12 +515,13 @@ gboolean webkit_osr_download_callback (WebKitWebView *webkitwebview,
506 return FALSE; 515 return FALSE;
507} 516}
508 517
509gboolean webkit_osr_mime_type_policy_typedecision_requested_callback(WebKitWebView *webView, 518gboolean
510 WebKitWebFrame *frame, 519webkit_osr_mime_type_policy_typedecision_requested_callback(WebKitWebView *webView,
511 WebKitNetworkRequest *request, 520 WebKitWebFrame *frame,
512 gchar *mimetype, 521 WebKitNetworkRequest *request,
513 WebKitWebPolicyDecision *policy_decision, 522 gchar *mimetype,
514 gpointer user_data) 523 WebKitWebPolicyDecision *policy_decision,
524 gpointer user_data)
515{ 525{
516 printf("mime policy requested\n"); 526 printf("mime policy requested\n");
517 // this function makes webkit send a download signal for all unknown mime types 527 // this function makes webkit send a download signal for all unknown mime types
@@ -525,12 +535,13 @@ gboolean webkit_osr_mime_type_policy_typedecision_requested_callback(WebKitWebV
525} 535}
526 536
527 537
528gboolean webkit_osr_new_window_policy_decision_requested_callback(WebKitWebView *webView, 538gboolean
529 WebKitWebFrame *frame, 539webkit_osr_new_window_policy_decision_requested_callback(WebKitWebView *webView,
530 WebKitNetworkRequest *request, 540 WebKitWebFrame *frame,
531 WebKitWebNavigationAction *navigation_action, 541 WebKitNetworkRequest *request,
532 WebKitWebPolicyDecision *policy_decision, 542 WebKitWebNavigationAction *navigation_action,
533 gpointer user_data) 543 WebKitWebPolicyDecision *policy_decision,
544 gpointer user_data)
534{ 545{
535 struct xwidget* xw = (struct xwidget*) g_object_get_data (G_OBJECT (webView), XG_XWIDGET); 546 struct xwidget* xw = (struct xwidget*) g_object_get_data (G_OBJECT (webView), XG_XWIDGET);
536 printf("webkit_osr_new_window_policy_decision_requested_callback %s\n", 547 printf("webkit_osr_new_window_policy_decision_requested_callback %s\n",
@@ -541,12 +552,13 @@ gboolean webkit_osr_new_window_policy_decision_requested_callback(WebKitWebView
541 return FALSE; 552 return FALSE;
542} 553}
543 554
544gboolean webkit_osr_navigation_policy_decision_requested_callback(WebKitWebView *webView, 555gboolean
545 WebKitWebFrame *frame, 556webkit_osr_navigation_policy_decision_requested_callback(WebKitWebView *webView,
546 WebKitNetworkRequest *request, 557 WebKitWebFrame *frame,
547 WebKitWebNavigationAction *navigation_action, 558 WebKitNetworkRequest *request,
548 WebKitWebPolicyDecision *policy_decision, 559 WebKitWebNavigationAction *navigation_action,
549 gpointer user_data) 560 WebKitWebPolicyDecision *policy_decision,
561 gpointer user_data)
550{ 562{
551 struct xwidget* xw = (struct xwidget*) g_object_get_data (G_OBJECT (webView), XG_XWIDGET); 563 struct xwidget* xw = (struct xwidget*) g_object_get_data (G_OBJECT (webView), XG_XWIDGET);
552 printf("webkit_osr_navigation_policy_decision_requested_callback %s\n", 564 printf("webkit_osr_navigation_policy_decision_requested_callback %s\n",
@@ -577,9 +589,9 @@ xwidget_osr_draw_callback (GtkWidget *widget, cairo_t *cr, gpointer data)
577 589
578 590
579gboolean 591gboolean
580xwidget_osr_button_callback ( GtkWidget *widget, 592xwidget_osr_button_callback (GtkWidget *widget,
581 GdkEvent *event, 593 GdkEvent *event,
582 gpointer user_data) 594 gpointer user_data)
583{ 595{
584 struct xwidget* xw = (struct xwidget*) g_object_get_data (G_OBJECT (widget), XG_XWIDGET); 596 struct xwidget* xw = (struct xwidget*) g_object_get_data (G_OBJECT (widget), XG_XWIDGET);
585 GdkEvent* eventcopy = gdk_event_copy(event); 597 GdkEvent* eventcopy = gdk_event_copy(event);
@@ -593,8 +605,7 @@ int xwidget_view_index=0;
593 605
594/* initializes and does initial placement of an xwidget view on screen */ 606/* initializes and does initial placement of an xwidget view on screen */
595struct xwidget_view* 607struct xwidget_view*
596xwidget_init_view ( 608xwidget_init_view (struct xwidget *xww,
597 struct xwidget *xww,
598 struct glyph_string *s, 609 struct glyph_string *s,
599 int x, int y) 610 int x, int y)
600{ 611{
@@ -847,9 +858,9 @@ if(Qnil == xwidget) {printf("ERROR xwidget nil\n"); return Qnil;}; \
847 }; 858 };
848 859
849 860
850DEFUN ("xwidget-webkit-goto-uri", Fxwidget_webkit_goto_uri, Sxwidget_webkit_goto_uri, 2, 2, 0, 861DEFUN ("xwidget-webkit-goto-uri", Fxwidget_webkit_goto_uri, Sxwidget_webkit_goto_uri,
851 doc: /* webkit goto uri.*/ 862 2, 2, 0,
852 ) 863 doc: /* webkit goto uri.*/)
853 (Lisp_Object xwidget, Lisp_Object uri) 864 (Lisp_Object xwidget, Lisp_Object uri)
854{ 865{
855 WEBKIT_FN_INIT(); 866 WEBKIT_FN_INIT();
@@ -858,9 +869,9 @@ DEFUN ("xwidget-webkit-goto-uri", Fxwidget_webkit_goto_uri, Sxwidget_webkit_got
858} 869}
859 870
860 871
861DEFUN ("xwidget-webkit-execute-script", Fxwidget_webkit_execute_script, Sxwidget_webkit_execute_script, 2, 2, 0, 872DEFUN ("xwidget-webkit-execute-script", Fxwidget_webkit_execute_script, Sxwidget_webkit_execute_script,
862 doc: /* webkit exec js.*/ 873 2, 2, 0,
863 ) 874 doc: /* webkit exec js.*/)
864 (Lisp_Object xwidget, Lisp_Object script) 875 (Lisp_Object xwidget, Lisp_Object script)
865{ 876{
866 WEBKIT_FN_INIT(); 877 WEBKIT_FN_INIT();
@@ -868,9 +879,9 @@ DEFUN ("xwidget-webkit-execute-script", Fxwidget_webkit_execute_script, Sxwidge
868 return Qnil; 879 return Qnil;
869} 880}
870 881
871DEFUN ("xwidget-webkit-get-title", Fxwidget_webkit_get_title, Sxwidget_webkit_get_title, 1, 1, 0, 882DEFUN ("xwidget-webkit-get-title", Fxwidget_webkit_get_title, Sxwidget_webkit_get_title,
872 doc: /* webkit get title. can be used to work around exec method lacks return val*/ 883 1, 1, 0,
873 ) 884 doc: /* webkit get title. can be used to work around exec method lacks return val*/)
874 (Lisp_Object xwidget) 885 (Lisp_Object xwidget)
875{ 886{
876 //TODO support multibyte strings 887 //TODO support multibyte strings
@@ -886,7 +897,8 @@ DEFUN ("xwidget-webkit-get-title", Fxwidget_webkit_get_title, Sxwidget_webkit_g
886} 897}
887 898
888//TODO missnamed 899//TODO missnamed
889DEFUN("xwidget-disable-plugin-for-mime", Fxwidget_disable_plugin_for_mime , Sxwidget_disable_plugin_for_mime, 1,1,0, doc: /* */) 900DEFUN("xwidget-disable-plugin-for-mime", Fxwidget_disable_plugin_for_mime , Sxwidget_disable_plugin_for_mime,
901 1,1,0, doc: /* */)
890 (Lisp_Object mime) 902 (Lisp_Object mime)
891{ 903{
892 WebKitWebPlugin *wp = webkit_web_plugin_database_get_plugin_for_mimetype 904 WebKitWebPlugin *wp = webkit_web_plugin_database_get_plugin_for_mimetype
@@ -902,16 +914,19 @@ DEFUN("xwidget-disable-plugin-for-mime", Fxwidget_disable_plugin_for_mime , Sxwi
902 914
903//attempting a workaround for a webkit offscreen bug 915//attempting a workaround for a webkit offscreen bug
904//TODO verify its still needed 916//TODO verify its still needed
905void gtk_window_get_position (GtkWindow *window, 917void
906 gint *root_x, 918gtk_window_get_position (GtkWindow *window,
907 gint *root_y){ 919 gint *root_x,
920 gint *root_y)
921{
908 printf("my getsize\n"); 922 printf("my getsize\n");
909 *root_x = 0; 923 *root_x = 0;
910 *root_y = 0; 924 *root_y = 0;
911} 925}
912 926
913void 927void
914xwidget_webkit_dom_dump(WebKitDOMNode* parent){ 928xwidget_webkit_dom_dump(WebKitDOMNode* parent)
929{
915 WebKitDOMNodeList* list; 930 WebKitDOMNodeList* list;
916 int i; 931 int i;
917 int length; 932 int length;
@@ -948,9 +963,9 @@ xwidget_webkit_dom_dump(WebKitDOMNode* parent){
948} 963}
949 964
950 965
951DEFUN ("xwidget-webkit-dom-dump", Fxwidget_webkit_dom_dump, Sxwidget_webkit_dom_dump, 1, 1, 0, 966DEFUN ("xwidget-webkit-dom-dump", Fxwidget_webkit_dom_dump, Sxwidget_webkit_dom_dump,
952 doc: /* webkit dom dump*/ 967 1, 1, 0,
953 ) 968 doc: /* webkit dom dump*/)
954 (Lisp_Object xwidget) 969 (Lisp_Object xwidget)
955{ 970{
956 WEBKIT_FN_INIT(); 971 WEBKIT_FN_INIT();
@@ -1309,7 +1324,8 @@ xwidget_spec_value ( Lisp_Object spec, Lisp_Object key,
1309} 1324}
1310 1325
1311 1326
1312void xwidget_view_delete_all_in_window( struct window *w ) 1327void
1328xwidget_view_delete_all_in_window (struct window *w)
1313{ 1329{
1314 struct xwidget_view* xv = NULL; 1330 struct xwidget_view* xv = NULL;
1315 for (int i = 0; i < MAX_XWIDGETS; i++){ 1331 for (int i = 0; i < MAX_XWIDGETS; i++){
@@ -1323,7 +1339,9 @@ void xwidget_view_delete_all_in_window( struct window *w )
1323 1339
1324 1340
1325 1341
1326struct xwidget_view* xwidget_view_lookup(struct xwidget* xw, struct window *w){ 1342struct xwidget_view*
1343xwidget_view_lookup (struct xwidget* xw, struct window *w)
1344{
1327 struct xwidget_view* xv = NULL; 1345 struct xwidget_view* xv = NULL;
1328 for (int i = 0; i < MAX_XWIDGETS; i++){ 1346 for (int i = 0; i < MAX_XWIDGETS; i++){
1329 xv = &xwidget_views[i]; 1347 xv = &xwidget_views[i];