diff options
| author | Dmitry Gutov | 2020-07-06 04:29:52 +0300 |
|---|---|---|
| committer | Dmitry Gutov | 2020-07-06 04:29:52 +0300 |
| commit | 10a0941f4dcc85d95279ae67032ec04463a44d59 (patch) | |
| tree | 644c9a2d94f35cc2443014e58a9c2f27ee405bab | |
| parent | 9f9ce631a2ff44ebcb87b0b1390a21b13665db43 (diff) | |
| download | emacs-10a0941f4dcc85d95279ae67032ec04463a44d59.tar.gz emacs-10a0941f4dcc85d95279ae67032ec04463a44d59.zip | |
; Revert "; Add a note about a bottleneck"
This reverts commit 9f9ce631a2ff44ebcb87b0b1390a21b13665db43.
It's still a bottleneck, but so are mapcar (with its effect on GC) and
concat. So our limits show in several places at once.
| -rw-r--r-- | lisp/progmodes/project.el | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el index 188236427da..08798d86f8e 100644 --- a/lisp/progmodes/project.el +++ b/lisp/progmodes/project.el | |||
| @@ -396,8 +396,6 @@ backend implementation of `project-external-roots'.") | |||
| 396 | (setq files | 396 | (setq files |
| 397 | (mapcar | 397 | (mapcar |
| 398 | (lambda (file) (concat default-directory file)) | 398 | (lambda (file) (concat default-directory file)) |
| 399 | ;; XXX: With large enough project, split-string becomes | ||
| 400 | ;; one of the bottlenecks. | ||
| 401 | (split-string | 399 | (split-string |
| 402 | (apply #'vc-git--run-command-string nil "ls-files" args) | 400 | (apply #'vc-git--run-command-string nil "ls-files" args) |
| 403 | "\0" t))) | 401 | "\0" t))) |