diff options
| author | Juri Linkov | 2014-12-06 01:42:11 +0200 |
|---|---|---|
| committer | Juri Linkov | 2014-12-06 01:42:11 +0200 |
| commit | 0ffa34951a2c45afa7857b7a970459d0189b4313 (patch) | |
| tree | 036fa202a16fed130bf6094ab5398cbec20cd0a1 | |
| parent | 7409a79b1b2acf1229dd763f5eb7b96abc17113a (diff) | |
| download | emacs-0ffa34951a2c45afa7857b7a970459d0189b4313.tar.gz emacs-0ffa34951a2c45afa7857b7a970459d0189b4313.zip | |
Better check for displaying completions near the minibuffer.
* lisp/minibuffer.el (minibuffer-completion-help): Compare
selected-window with minibuffer-window to check whether
completions should be displayed near the minibuffer.
http://lists.gnu.org/archive/html/emacs-devel/2014-12/msg00311.html
Fixes: debbugs:17809
| -rw-r--r-- | lisp/ChangeLog | 7 | ||||
| -rw-r--r-- | lisp/minibuffer.el | 10 |
2 files changed, 10 insertions, 7 deletions
diff --git a/lisp/ChangeLog b/lisp/ChangeLog index 7cbacecd16f..5cc530c42b6 100644 --- a/lisp/ChangeLog +++ b/lisp/ChangeLog | |||
| @@ -1,3 +1,10 @@ | |||
| 1 | 2014-12-05 Juri Linkov <juri@linkov.net> | ||
| 2 | |||
| 3 | * minibuffer.el (minibuffer-completion-help): Compare | ||
| 4 | selected-window with minibuffer-window to check whether | ||
| 5 | completions should be displayed near the minibuffer. (Bug#17809) | ||
| 6 | http://lists.gnu.org/archive/html/emacs-devel/2014-12/msg00311.html | ||
| 7 | |||
| 1 | 2014-12-05 Michael Albinus <michael.albinus@gmx.de> | 8 | 2014-12-05 Michael Albinus <michael.albinus@gmx.de> |
| 2 | 9 | ||
| 3 | * vc/vc-mtn.el (vc-mtn-root): | 10 | * vc/vc-mtn.el (vc-mtn-root): |
diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el index 0bee13b155c..ee97174b0b2 100644 --- a/lisp/minibuffer.el +++ b/lisp/minibuffer.el | |||
| @@ -1815,13 +1815,9 @@ variables.") | |||
| 1815 | ;; Use `display-buffer-below-selected' for inline completions, | 1815 | ;; Use `display-buffer-below-selected' for inline completions, |
| 1816 | ;; but not in the minibuffer (e.g. in `eval-expression') | 1816 | ;; but not in the minibuffer (e.g. in `eval-expression') |
| 1817 | ;; for which `display-buffer-at-bottom' is used. | 1817 | ;; for which `display-buffer-at-bottom' is used. |
| 1818 | ;; Compare `this-command' with `completion-at-point' | 1818 | ,(if (eq (selected-window) (minibuffer-window)) |
| 1819 | ;; since `completion--in-region-1' sets `this-command' | 1819 | 'display-buffer-at-bottom |
| 1820 | ;; to this value for region completion commands. | 1820 | 'display-buffer-below-selected)) |
| 1821 | ,(if (and (eq this-command 'completion-at-point) | ||
| 1822 | (not (minibuffer-selected-window))) | ||
| 1823 | 'display-buffer-below-selected | ||
| 1824 | 'display-buffer-at-bottom)) | ||
| 1825 | (window-height . fit-window-to-buffer)) | 1821 | (window-height . fit-window-to-buffer)) |
| 1826 | nil | 1822 | nil |
| 1827 | ;; Remove the base-size tail because `sort' requires a properly | 1823 | ;; Remove the base-size tail because `sort' requires a properly |