diff options
| author | Stephen Berman | 2013-04-13 16:37:20 +0200 |
|---|---|---|
| committer | Stephen Berman | 2013-04-13 16:37:20 +0200 |
| commit | 0aa3616eed6914d159d1136aaa487ac3b042cf7d (patch) | |
| tree | fa8a8e3f3ba9844d06a39a602e83cf30c31a575e | |
| parent | 8c35e3c3b48cadea093d1a05a4839b9962bcce93 (diff) | |
| download | emacs-0aa3616eed6914d159d1136aaa487ac3b042cf7d.tar.gz emacs-0aa3616eed6914d159d1136aaa487ac3b042cf7d.zip | |
Make `split-window' a non-interactive function.
* doc/lispref/windows.texi (Splitting Windows): Change category of
split-window from a command to a function.
* etc/NEWS: Mention fixing `split-window' to be non-interactive.
* window.el (split-window): Remove interactive form, since as a
command this function is a special case of split-window-below.
Correct doc string.
| -rw-r--r-- | doc/lispref/ChangeLog | 5 | ||||
| -rw-r--r-- | doc/lispref/windows.texi | 4 | ||||
| -rw-r--r-- | etc/ChangeLog | 4 | ||||
| -rw-r--r-- | etc/NEWS | 5 | ||||
| -rw-r--r-- | lisp/ChangeLog | 6 | ||||
| -rw-r--r-- | lisp/window.el | 3 |
6 files changed, 23 insertions, 4 deletions
diff --git a/doc/lispref/ChangeLog b/doc/lispref/ChangeLog index 0bc2b0880b0..f65c2e85461 100644 --- a/doc/lispref/ChangeLog +++ b/doc/lispref/ChangeLog | |||
| @@ -1,3 +1,8 @@ | |||
| 1 | 2013-04-13 Stephen Berman <stephen.berman@gmx.net> | ||
| 2 | |||
| 3 | * windows.texi (Splitting Windows): Change category of | ||
| 4 | split-window from a command to a function. | ||
| 5 | |||
| 1 | 2013-04-06 Chong Yidong <cyd@gnu.org> | 6 | 2013-04-06 Chong Yidong <cyd@gnu.org> |
| 2 | 7 | ||
| 3 | * display.texi (Faces): Minor clarifications. | 8 | * display.texi (Faces): Minor clarifications. |
diff --git a/doc/lispref/windows.texi b/doc/lispref/windows.texi index 792002add81..f2a4b3849dd 100644 --- a/doc/lispref/windows.texi +++ b/doc/lispref/windows.texi | |||
| @@ -717,7 +717,7 @@ window. | |||
| 717 | This section describes functions for creating a new window by | 717 | This section describes functions for creating a new window by |
| 718 | @dfn{splitting} an existing one. | 718 | @dfn{splitting} an existing one. |
| 719 | 719 | ||
| 720 | @deffn Command split-window &optional window size side | 720 | @defun split-window &optional window size side |
| 721 | This function creates a new live window next to the window | 721 | This function creates a new live window next to the window |
| 722 | @var{window}. If @var{window} is omitted or @code{nil}, it defaults | 722 | @var{window}. If @var{window} is omitted or @code{nil}, it defaults |
| 723 | to the selected window. That window is ``split'', and reduced in | 723 | to the selected window. That window is ``split'', and reduced in |
| @@ -767,7 +767,7 @@ called with the arguments @var{window}, @var{size}, and @var{side}, in | |||
| 767 | lieu of the usual action of @code{split-window}. Otherwise, this | 767 | lieu of the usual action of @code{split-window}. Otherwise, this |
| 768 | function obeys the @code{window-atom} or @code{window-side} window | 768 | function obeys the @code{window-atom} or @code{window-side} window |
| 769 | parameter, if any. @xref{Window Parameters}. | 769 | parameter, if any. @xref{Window Parameters}. |
| 770 | @end deffn | 770 | @end defun |
| 771 | 771 | ||
| 772 | As an example, here is a sequence of @code{split-window} calls that | 772 | As an example, here is a sequence of @code{split-window} calls that |
| 773 | yields the window configuration discussed in @ref{Windows and Frames}. | 773 | yields the window configuration discussed in @ref{Windows and Frames}. |
diff --git a/etc/ChangeLog b/etc/ChangeLog index 493095e9621..31d14b96d94 100644 --- a/etc/ChangeLog +++ b/etc/ChangeLog | |||
| @@ -1,3 +1,7 @@ | |||
| 1 | 2013-04-13 Stephen Berman <stephen.berman@gmx.net> | ||
| 2 | |||
| 3 | * NEWS: Mention fixing `split-window' to be non-interactive. | ||
| 4 | |||
| 1 | 2013-04-09 Tassilo Horn <tsdh@gnu.org> | 5 | 2013-04-09 Tassilo Horn <tsdh@gnu.org> |
| 2 | 6 | ||
| 3 | * themes/tsdh-dark-theme.el (tsdh-dark): Add some more faces. | 7 | * themes/tsdh-dark-theme.el (tsdh-dark): Add some more faces. |
| @@ -76,6 +76,11 @@ of the buffer is visible). | |||
| 76 | 76 | ||
| 77 | * Editing Changes in Emacs 24.4 | 77 | * Editing Changes in Emacs 24.4 |
| 78 | 78 | ||
| 79 | ** `split-window' is no longer a command, just a non-interactive function. | ||
| 80 | As a command it was a special case of `split-window-below', and as such | ||
| 81 | superfluous. After being reimplemented in Lisp, its interactive form | ||
| 82 | was mistakenly retained. | ||
| 83 | |||
| 79 | ** New commands `toggle-frame-fullscreen' and `toggle-frame-maximized', | 84 | ** New commands `toggle-frame-fullscreen' and `toggle-frame-maximized', |
| 80 | bound to <f11> and M-<f10>, respectively. | 85 | bound to <f11> and M-<f10>, respectively. |
| 81 | 86 | ||
diff --git a/lisp/ChangeLog b/lisp/ChangeLog index 37e8028c941..9f31cd8228b 100644 --- a/lisp/ChangeLog +++ b/lisp/ChangeLog | |||
| @@ -1,3 +1,9 @@ | |||
| 1 | 2013-04-13 Stephen Berman <stephen.berman@gmx.net> | ||
| 2 | |||
| 3 | * window.el (split-window): Remove interactive form, since as a | ||
| 4 | command this function is a special case of split-window-below. | ||
| 5 | Correct doc string. | ||
| 6 | |||
| 1 | 2013-04-12 Roland Winkler <winkler@gnu.org> | 7 | 2013-04-12 Roland Winkler <winkler@gnu.org> |
| 2 | 8 | ||
| 3 | * faces.el (read-face-name): Do not override value of arg default. | 9 | * faces.el (read-face-name): Do not override value of arg default. |
diff --git a/lisp/window.el b/lisp/window.el index 627b9a425eb..5b001988ddf 100644 --- a/lisp/window.el +++ b/lisp/window.el | |||
| @@ -3686,7 +3686,7 @@ lines or columns tall. If SIZE is negative, make the new window | |||
| 3686 | absolute value can be less than `window-min-height' or | 3686 | absolute value can be less than `window-min-height' or |
| 3687 | `window-min-width'; so this command can make a new window as | 3687 | `window-min-width'; so this command can make a new window as |
| 3688 | small as one line or two columns. SIZE defaults to half of | 3688 | small as one line or two columns. SIZE defaults to half of |
| 3689 | WINDOW's size. Interactively, SIZE is the prefix argument. | 3689 | WINDOW's size. |
| 3690 | 3690 | ||
| 3691 | Optional third argument SIDE nil (or `below') specifies that the | 3691 | Optional third argument SIDE nil (or `below') specifies that the |
| 3692 | new window shall be located below WINDOW. SIDE `above' means the | 3692 | new window shall be located below WINDOW. SIDE `above' means the |
| @@ -3718,7 +3718,6 @@ scrollbars are inherited from WINDOW. If WINDOW is an internal | |||
| 3718 | window, these properties as well as the buffer displayed in the | 3718 | window, these properties as well as the buffer displayed in the |
| 3719 | new window are inherited from the window selected on WINDOW's | 3719 | new window are inherited from the window selected on WINDOW's |
| 3720 | frame. The selected window is not changed by this function." | 3720 | frame. The selected window is not changed by this function." |
| 3721 | (interactive "i") | ||
| 3722 | (setq window (window-normalize-window window)) | 3721 | (setq window (window-normalize-window window)) |
| 3723 | (let* ((side (cond | 3722 | (let* ((side (cond |
| 3724 | ((not side) 'below) | 3723 | ((not side) 'below) |