aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLars Magne Ingebrigtsen2013-12-21 18:54:16 +0100
committerLars Magne Ingebrigtsen2013-12-21 18:54:16 +0100
commit073d5cfd9e1bdc5aafcae04b7a667e4b0c006922 (patch)
tree65680d7899e7aa1142594e96026f71370d33f181
parentdf8b4c35120bcde0ce0b0f39e221033fdde7cd56 (diff)
downloademacs-073d5cfd9e1bdc5aafcae04b7a667e4b0c006922.tar.gz
emacs-073d5cfd9e1bdc5aafcae04b7a667e4b0c006922.zip
* net/shr.el (shr--extract-best-source): Don't bug out on audio elements
That have text inside. Also remove debugging.
-rw-r--r--lisp/ChangeLog5
-rw-r--r--lisp/net/shr.el19
2 files changed, 12 insertions, 12 deletions
diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index 53cd2430519..ea6579209ee 100644
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,3 +1,8 @@
12013-12-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
2
3 * net/shr.el (shr--extract-best-source): Don't bug out on audio
4 elements with text inside. Also remove debugging.
5
12013-12-21 Jan Djärv <jan.h.d@swipnet.se> 62013-12-21 Jan Djärv <jan.h.d@swipnet.se>
2 7
3 * cus-start.el (all): Add ns-use-srgb-colorspace. 8 * cus-start.el (all): Add ns-use-srgb-colorspace.
diff --git a/lisp/net/shr.el b/lisp/net/shr.el
index 4b67bafc5cd..5c30bd8ac67 100644
--- a/lisp/net/shr.el
+++ b/lisp/net/shr.el
@@ -1136,21 +1136,16 @@ The preference is a float determined from `shr-prefer-media-type'."
1136 (setq pref (or pref -1.0)) 1136 (setq pref (or pref -1.0))
1137 (let (new-pref) 1137 (let (new-pref)
1138 (dolist (elem cont) 1138 (dolist (elem cont)
1139 (when (and (listp elem) 1139 (when (and (eq (car elem) 'source)
1140 (not (keywordp (car elem)))) ;; skip attributes 1140 (< pref
1141 (when (and (eq (car elem) 'source) 1141 (setq new-pref
1142 (< pref 1142 (shr--get-media-pref elem))))
1143 (setq new-pref 1143 (setq pref new-pref
1144 (shr--get-media-pref elem)))) 1144 url (cdr (assq :src elem)))
1145 (setq pref new-pref
1146 url (cdr (assq :src elem)))
1147 (message "new %s %s" url pref))
1148 ;; libxml's html parser isn't HTML5 compliant and non terminated 1145 ;; libxml's html parser isn't HTML5 compliant and non terminated
1149 ;; source tags might end up as children. So recursion it is... 1146 ;; source tags might end up as children. So recursion it is...
1150 (dolist (child (cdr elem)) 1147 (dolist (child (cdr elem))
1151 (when (and (listp child) 1148 (when (eq (car child) 'source)
1152 (not (keywordp (car child))) ;; skip attributes
1153 (eq (car child) 'source))
1154 (let ((ret (shr--extract-best-source (list child) url pref))) 1149 (let ((ret (shr--extract-best-source (list child) url pref)))
1155 (when (< pref (cdr ret)) 1150 (when (< pref (cdr ret))
1156 (setq url (car ret) 1151 (setq url (car ret)