diff options
| author | Juri Linkov | 2013-01-09 01:50:40 +0200 |
|---|---|---|
| committer | Juri Linkov | 2013-01-09 01:50:40 +0200 |
| commit | 073ca75ba32d3b14aace7ad51c85f83be09376bd (patch) | |
| tree | 2e39f88ccbef802d194aad2fc6df2eb67ed184c3 | |
| parent | 4bdc352611db6d7e9a11e75693e94dce61377d2e (diff) | |
| download | emacs-073ca75ba32d3b14aace7ad51c85f83be09376bd.tar.gz emacs-073ca75ba32d3b14aace7ad51c85f83be09376bd.zip | |
* lisp/textmodes/flyspell.el (flyspell-incorrect, flyspell-duplicate):
* lisp/progmodes/flymake.el (flymake-errline, flymake-warnline):
Use underline style wave on terminals that support it.
* src/xfaces.c (tty_supports_face_attributes_p): Return 0 for the case
of (supports :underline (:style wave)).
Fixes: debbugs:13000
| -rw-r--r-- | etc/NEWS | 3 | ||||
| -rw-r--r-- | lisp/ChangeLog | 6 | ||||
| -rw-r--r-- | lisp/progmodes/flymake.el | 12 | ||||
| -rw-r--r-- | lisp/textmodes/flyspell.el | 14 | ||||
| -rw-r--r-- | src/ChangeLog | 5 | ||||
| -rw-r--r-- | src/xfaces.c | 2 |
6 files changed, 38 insertions, 4 deletions
| @@ -205,6 +205,9 @@ property using the supplied face spec. | |||
| 205 | *** Face specs set via Custom themes now replace the `defface' spec | 205 | *** Face specs set via Custom themes now replace the `defface' spec |
| 206 | rather than inheriting from it (as do face specs set via Customize). | 206 | rather than inheriting from it (as do face specs set via Customize). |
| 207 | 207 | ||
| 208 | *** New face characteristic (supports :underline (:style wave)) | ||
| 209 | specifies whether or not the terminal can display a wavy line. | ||
| 210 | |||
| 208 | ** time-to-seconds is not obsolete any more. | 211 | ** time-to-seconds is not obsolete any more. |
| 209 | ** New function special-form-p. | 212 | ** New function special-form-p. |
| 210 | ** Docstrings can be made dynamic by adding a `dynamic-docstring-function' | 213 | ** Docstrings can be made dynamic by adding a `dynamic-docstring-function' |
diff --git a/lisp/ChangeLog b/lisp/ChangeLog index 92c071e1776..ba5fc47a0b9 100644 --- a/lisp/ChangeLog +++ b/lisp/ChangeLog | |||
| @@ -1,3 +1,9 @@ | |||
| 1 | 2013-01-08 Juri Linkov <juri@jurta.org> | ||
| 2 | |||
| 3 | * textmodes/flyspell.el (flyspell-incorrect, flyspell-duplicate): | ||
| 4 | * progmodes/flymake.el (flymake-errline, flymake-warnline): | ||
| 5 | Use underline style wave on terminals that support it. (Bug#13000) | ||
| 6 | |||
| 1 | 2013-01-08 Stefan Monnier <monnier@iro.umontreal.ca> | 7 | 2013-01-08 Stefan Monnier <monnier@iro.umontreal.ca> |
| 2 | 8 | ||
| 3 | * emacs-lisp/pcase.el (pcase--split-equal): Also take advantage if | 9 | * emacs-lisp/pcase.el (pcase--split-equal): Also take advantage if |
diff --git a/lisp/progmodes/flymake.el b/lisp/progmodes/flymake.el index 7ca0ececa78..0f92df95a9d 100644 --- a/lisp/progmodes/flymake.el +++ b/lisp/progmodes/flymake.el | |||
| @@ -844,13 +844,21 @@ Return t if it has at least one flymake overlay, nil if no overlay." | |||
| 844 | has-flymake-overlays)) | 844 | has-flymake-overlays)) |
| 845 | 845 | ||
| 846 | (defface flymake-errline | 846 | (defface flymake-errline |
| 847 | '((t :inherit error)) | 847 | '((((supports :underline (:style wave))) |
| 848 | :underline (:style wave :color "Red1")) | ||
| 849 | (t | ||
| 850 | :inherit error)) | ||
| 848 | "Face used for marking error lines." | 851 | "Face used for marking error lines." |
| 852 | :version "24.4" | ||
| 849 | :group 'flymake) | 853 | :group 'flymake) |
| 850 | 854 | ||
| 851 | (defface flymake-warnline | 855 | (defface flymake-warnline |
| 852 | '((t :inherit warning)) | 856 | '((((supports :underline (:style wave))) |
| 857 | :underline (:style wave :color "DarkOrange")) | ||
| 858 | (t | ||
| 859 | :inherit warning)) | ||
| 853 | "Face used for marking warning lines." | 860 | "Face used for marking warning lines." |
| 861 | :version "24.4" | ||
| 854 | :group 'flymake) | 862 | :group 'flymake) |
| 855 | 863 | ||
| 856 | (defun flymake-highlight-line (line-no line-err-info-list) | 864 | (defun flymake-highlight-line (line-no line-err-info-list) |
diff --git a/lisp/textmodes/flyspell.el b/lisp/textmodes/flyspell.el index 7e692960dbc..fe2f808c594 100644 --- a/lisp/textmodes/flyspell.el +++ b/lisp/textmodes/flyspell.el | |||
| @@ -445,13 +445,23 @@ like <img alt=\"Some thing.\">." | |||
| 445 | ;;*---------------------------------------------------------------------*/ | 445 | ;;*---------------------------------------------------------------------*/ |
| 446 | ;;* Highlighting */ | 446 | ;;* Highlighting */ |
| 447 | ;;*---------------------------------------------------------------------*/ | 447 | ;;*---------------------------------------------------------------------*/ |
| 448 | (defface flyspell-incorrect '((t :underline t :inherit error)) | 448 | (defface flyspell-incorrect |
| 449 | '((((supports :underline (:style wave))) | ||
| 450 | :underline (:style wave :color "Red1")) | ||
| 451 | (t | ||
| 452 | :underline t :inherit error)) | ||
| 449 | "Flyspell face for misspelled words." | 453 | "Flyspell face for misspelled words." |
| 454 | :version "24.4" | ||
| 450 | :group 'flyspell) | 455 | :group 'flyspell) |
| 451 | 456 | ||
| 452 | (defface flyspell-duplicate '((t :underline t :inherit warning)) | 457 | (defface flyspell-duplicate |
| 458 | '((((supports :underline (:style wave))) | ||
| 459 | :underline (:style wave :color "DarkOrange")) | ||
| 460 | (t | ||
| 461 | :underline t :inherit warning)) | ||
| 453 | "Flyspell face for words that appear twice in a row. | 462 | "Flyspell face for words that appear twice in a row. |
| 454 | See also `flyspell-duplicate-distance'." | 463 | See also `flyspell-duplicate-distance'." |
| 464 | :version "24.4" | ||
| 455 | :group 'flyspell) | 465 | :group 'flyspell) |
| 456 | 466 | ||
| 457 | (defvar flyspell-overlay nil) | 467 | (defvar flyspell-overlay nil) |
diff --git a/src/ChangeLog b/src/ChangeLog index 9ab201c8be4..c60fa701385 100644 --- a/src/ChangeLog +++ b/src/ChangeLog | |||
| @@ -1,3 +1,8 @@ | |||
| 1 | 2013-01-08 Juri Linkov <juri@jurta.org> | ||
| 2 | |||
| 3 | * xfaces.c (tty_supports_face_attributes_p): Return 0 for the case | ||
| 4 | of (supports :underline (:style wave)). (Bug#13000) | ||
| 5 | |||
| 1 | 2013-01-08 Aaron S. Hawley <aaron.s.hawley@gmail.com> | 6 | 2013-01-08 Aaron S. Hawley <aaron.s.hawley@gmail.com> |
| 2 | 7 | ||
| 3 | * undo.c (Fprimitive_undo): Move to simple.el. | 8 | * undo.c (Fprimitive_undo): Move to simple.el. |
diff --git a/src/xfaces.c b/src/xfaces.c index ed2895c014c..43535b9ea0c 100644 --- a/src/xfaces.c +++ b/src/xfaces.c | |||
| @@ -4877,6 +4877,8 @@ tty_supports_face_attributes_p (struct frame *f, | |||
| 4877 | { | 4877 | { |
| 4878 | if (STRINGP (val)) | 4878 | if (STRINGP (val)) |
| 4879 | return 0; /* ttys can't use colored underlines */ | 4879 | return 0; /* ttys can't use colored underlines */ |
| 4880 | else if (EQ (CAR_SAFE (val), QCstyle) && EQ (CAR_SAFE (CDR_SAFE (val)), Qwave)) | ||
| 4881 | return 0; /* ttys can't use wave underlines */ | ||
| 4880 | else if (face_attr_equal_p (val, def_attrs[LFACE_UNDERLINE_INDEX])) | 4882 | else if (face_attr_equal_p (val, def_attrs[LFACE_UNDERLINE_INDEX])) |
| 4881 | return 0; /* same as default */ | 4883 | return 0; /* same as default */ |
| 4882 | else | 4884 | else |