Improve an error about the message signer

* lisp/gnus/mml-sec.el (mml-secure-epg-sign): Don't suggest setting
  `mml-secure-smime-sign-with-sender' if it's already non-nil.

1 files changed, 9 insertions, 1 deletions

diff --git a/lisp/gnus/mml-sec.el b/lisp/gnus/mml-sec.el
index c7a2d4664e8..a1f5b6386b2 100644
--- a/lisp/gnus/mml-sec.el
+++ b/lisp/gnus/mml-sec.el
@@ -945,7 +945,15 @@ If no one is selected, symmetric encryption will be performed.  "
          (signers (mml-secure-signers context signer-names))
          signature micalg)
     (unless signers
-      (error "Couldn't find any signer names.  Perhaps `mml-secure-smime-sign-with-sender' should be set?"))
+      (let ((maybe-msg
+             (if mml-secure-smime-sign-with-sender
+                 "."
+               "; try setting `mml-secure-smime-sign-with-sender'.")))
+        ;; If `mml-secure-smime-sign-with-sender' is already non-nil
+        ;; then there's no point advising the user to examine it.  If
+        ;; there are any other variables worth examining, please
+        ;; improve this error message by having it mention them.
+        (error "Couldn't find any signer names%s" maybe-msg)))
     (when (eq 'OpenPGP protocol)
       (setf (epg-context-armor context) t)
       (setf (epg-context-textmode context) t)