diff options
| author | Karl Fogel | 2010-07-13 18:09:20 -0400 |
|---|---|---|
| committer | Karl Fogel | 2010-07-13 18:09:20 -0400 |
| commit | 068a0233c700042e117f2ee330e347f00c8cc6e0 (patch) | |
| tree | 58cae66b34bf41d8e53ff74e86ac6ebab7b47f4d | |
| parent | c5622b6fd23d2e2a8d494b9477c2dc79233ba11c (diff) | |
| download | emacs-068a0233c700042e117f2ee330e347f00c8cc6e0.tar.gz emacs-068a0233c700042e117f2ee330e347f00c8cc6e0.zip | |
[[[
* lisp/bookmark.el (bookmark-bmenu-switch-other-window,
bookmark-bmenu-other-window, bookmark-bmenu-2-window): Don't override
ambient binding of `bookmark-automatically-show-annotations'. (Bug #6515)
]]]
=== modified file 'lisp/bookmark.el'
--- lisp/bookmark.el 2010-04-14 15:07:53 +0000
+++ lisp/bookmark.el 2010-06-27 03:40:14 +0000
@@ -1860,8 +1860,7 @@
(pop-up-windows t))
(delete-other-windows)
(switch-to-buffer (other-buffer))
- (let ((bookmark-automatically-show-annotations nil)) ;FIXME: needed?
- (bookmark--jump-via bmrk 'pop-to-buffer))
+ (bookmark--jump-via bmrk 'pop-to-buffer)
(bury-buffer menu)))
@@ -1875,8 +1874,7 @@
"Select this line's bookmark in other window, leaving bookmark menu visible."
(interactive)
(let ((bookmark (bookmark-bmenu-bookmark)))
- (let ((bookmark-automatically-show-annotations t)) ;FIXME: needed?
- (bookmark--jump-via bookmark 'switch-to-buffer-other-window))))
+ (bookmark--jump-via bookmark 'switch-to-buffer-other-window)))
(defun bookmark-bmenu-switch-other-window ()
@@ -1887,8 +1885,7 @@
(pop-up-windows t)
same-window-buffer-names
same-window-regexps)
- (let ((bookmark-automatically-show-annotations t)) ;FIXME: needed?
- (bookmark--jump-via bookmark 'display-buffer))))
+ (bookmark--jump-via bookmark 'display-buffer)))
(defun bookmark-bmenu-other-window-with-mouse (event)
"Select bookmark at the mouse pointer in other window, leaving bookmark menu visible."
=== modified file 'lisp/saveplace.el'
--- lisp/saveplace.el 2010-01-13 08:35:10 +0000
+++ lisp/saveplace.el 2010-02-07 23:14:52 +0000
@@ -213,7 +213,7 @@
(symbol-name coding-system-for-write)))
(let ((print-length nil)
(print-level nil))
- (print save-place-alist (current-buffer)))
+ (pp save-place-alist (current-buffer)))
(let ((version-control
(cond
((null save-place-version-control) nil)
| -rw-r--r-- | lisp/ChangeLog | 6 | ||||
| -rw-r--r-- | lisp/bookmark.el | 2 |
2 files changed, 7 insertions, 1 deletions
diff --git a/lisp/ChangeLog b/lisp/ChangeLog index 3d608bb860b..f7bf7832488 100644 --- a/lisp/ChangeLog +++ b/lisp/ChangeLog | |||
| @@ -1,3 +1,9 @@ | |||
| 1 | 2010-07-13 Karl Fogel <kfogel@red-bean.com> | ||
| 2 | |||
| 3 | * bookmark.el (bookmark-show-annotation): Ensure annotations show, | ||
| 4 | e.g. in Info bookmarks, by using `switch-to-buffer-other-window'. | ||
| 5 | Patch by Thierry Volpiatto (Bug#6444). | ||
| 6 | |||
| 1 | 2010-07-13 Chong Yidong <cyd@stupidchicken.com> | 7 | 2010-07-13 Chong Yidong <cyd@stupidchicken.com> |
| 2 | 8 | ||
| 3 | * frame.el (make-frame): Fix typo in 2010-06-30 change (Bug#6625). | 9 | * frame.el (make-frame): Fix typo in 2010-06-30 change (Bug#6625). |
diff --git a/lisp/bookmark.el b/lisp/bookmark.el index d91c3ca46ee..b0d06f4e555 100644 --- a/lisp/bookmark.el +++ b/lisp/bookmark.el | |||
| @@ -1741,7 +1741,7 @@ if an annotation exists." | |||
| 1741 | ;; (insert (concat "Annotation for bookmark '" bookmark "':\n\n")) | 1741 | ;; (insert (concat "Annotation for bookmark '" bookmark "':\n\n")) |
| 1742 | (insert annotation) | 1742 | (insert annotation) |
| 1743 | (goto-char (point-min)) | 1743 | (goto-char (point-min)) |
| 1744 | (pop-to-buffer old-buf)))))) | 1744 | (switch-to-buffer-other-window old-buf)))))) |
| 1745 | 1745 | ||
| 1746 | 1746 | ||
| 1747 | (defun bookmark-show-all-annotations () | 1747 | (defun bookmark-show-all-annotations () |