aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMichael Albinus2019-04-14 19:53:38 +0200
committerMichael Albinus2019-04-14 19:53:38 +0200
commit05d53d88865d0287412c0f52a421cbf96a4d425d (patch)
treed988342d2fb4e4f34cd7162c39eece086ea39d69
parent98a5958f77f56c3de529fe04d3f1c85c037f49e6 (diff)
downloademacs-05d53d88865d0287412c0f52a421cbf96a4d425d.tar.gz
emacs-05d53d88865d0287412c0f52a421cbf96a4d425d.zip
Some rearragements for remote tests in filenotify-tests.el
* test/lisp/filenotify-tests.el (file-notify--deftest-remote): Change argument list, EXPECTED is not needed. (file-notify-test07-many-events-remote) (file-notify-test09-watched-file-in-watched-dir-remote): Adapt declaration accordingly.
-rw-r--r--test/lisp/filenotify-tests.el16
1 files changed, 8 insertions, 8 deletions
diff --git a/test/lisp/filenotify-tests.el b/test/lisp/filenotify-tests.el
index 842d66d7780..a40dc720786 100644
--- a/test/lisp/filenotify-tests.el
+++ b/test/lisp/filenotify-tests.el
@@ -261,13 +261,13 @@ This returns only for the local case and gfilenotify; otherwise it is nil.
261 (gfile-monitor-name file-notify--test-desc))) 261 (gfile-monitor-name file-notify--test-desc)))
262 (cdr (assq file-notify--test-desc file-notify--test-monitors)))))) 262 (cdr (assq file-notify--test-desc file-notify--test-monitors))))))
263 263
264(defmacro file-notify--deftest-remote (test docstring &optional expected skip) 264(defmacro file-notify--deftest-remote (test docstring &optional unstable)
265 "Define ert `TEST-remote' for remote files." 265 "Define ert `TEST-remote' for remote files.
266If UNSTABLE is non-nil, the test is tagged as `:unstable'."
266 (declare (indent 1)) 267 (declare (indent 1))
267 `(ert-deftest ,(intern (concat (symbol-name test) "-remote")) () 268 `(ert-deftest ,(intern (concat (symbol-name test) "-remote")) ()
268 ,docstring 269 ,docstring
269 :expected-result (or ,expected :passed) 270 :tags (if ,unstable '(:expensive-test :unstable) '(:expensive-test))
270 :tags ,(if skip ''(:expensive-test :unstable) ''(:expensive-test))
271 (let* ((temporary-file-directory 271 (let* ((temporary-file-directory
272 file-notify-test-remote-temporary-file-directory) 272 file-notify-test-remote-temporary-file-directory)
273 (ert-test (ert-get-test ',test)) 273 (ert-test (ert-get-test ',test))
@@ -1203,8 +1203,8 @@ delivered."
1203 1203
1204;; Unpredictable failures, eg https://hydra.nixos.org/build/86016286 1204;; Unpredictable failures, eg https://hydra.nixos.org/build/86016286
1205(file-notify--deftest-remote file-notify-test07-many-events 1205(file-notify--deftest-remote file-notify-test07-many-events
1206 "Check that events are not dropped for remote directories." 1206 "Check that events are not dropped for remote directories."
1207 :passed (getenv "EMACS_HYDRA_CI")) 1207 (getenv "EMACS_HYDRA_CI"))
1208 1208
1209(ert-deftest file-notify-test08-backup () 1209(ert-deftest file-notify-test08-backup ()
1210 "Check that backup keeps file notification." 1210 "Check that backup keeps file notification."
@@ -1421,8 +1421,8 @@ the file watch."
1421 ;; Cleanup. 1421 ;; Cleanup.
1422 (file-notify--test-cleanup))) 1422 (file-notify--test-cleanup)))
1423 1423
1424;(file-notify--deftest-remote file-notify-test09-watched-file-in-watched-dir 1424(file-notify--deftest-remote file-notify-test09-watched-file-in-watched-dir
1425; "Check `file-notify-test09-watched-file-in-watched-dir' for remote files.") 1425 "Check `file-notify-test09-watched-file-in-watched-dir' for remote files." t)
1426 1426
1427(ert-deftest file-notify-test10-sufficient-resources () 1427(ert-deftest file-notify-test10-sufficient-resources ()
1428 "Check that file notification does not use too many resources." 1428 "Check that file notification does not use too many resources."