(dired-create-files): Use dolist.

2 files changed, 40 insertions, 41 deletions

diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index 97e59b46f25..a2c1eb502bf 100644
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,5 +1,7 @@
 2008-03-26  Stefan Monnier  <monnier@iro.umontreal.ca>
 
+        * dired-aux.el (dired-create-files): Use dolist.
+
         * bindings.el (mode-line-change-eol): Use with-selected-window.
 
         * apropos.el (apropos-command): Include macros.
diff --git a/lisp/dired-aux.el b/lisp/dired-aux.el
index 11cf1e184d8..5e27d51a3d9 100644
--- a/lisp/dired-aux.el
+++ b/lisp/dired-aux.el
@@ -1389,51 +1389,48 @@ Special value `always' suppresses confirmation."
         skipped (success-count 0) (total (length fn-list)))
     (let (to overwrite-query
              overwrite-backup-query)    ; for dired-handle-overwrite
-      (mapc
-       (function
-        (lambda (from)
-          (setq to (funcall name-constructor from))
-          (if (equal to from)
-              (progn
-                (setq to nil)
-                (dired-log "Cannot %s to same file: %s\n"
-                           (downcase operation) from)))
-          (if (not to)
-              (setq skipped (cons (dired-make-relative from) skipped))
-            (let* ((overwrite (file-exists-p to))
-                   (dired-overwrite-confirmed   ; for dired-handle-overwrite
-                    (and overwrite
-                         (let ((help-form '(format "\
+      (dolist (from fn-list)
+        (setq to (funcall name-constructor from))
+        (if (equal to from)
+            (progn
+              (setq to nil)
+              (dired-log "Cannot %s to same file: %s\n"
+                         (downcase operation) from)))
+        (if (not to)
+            (setq skipped (cons (dired-make-relative from) skipped))
+          (let* ((overwrite (file-exists-p to))
+                 (dired-overwrite-confirmed ; for dired-handle-overwrite
+                  (and overwrite
+                       (let ((help-form '(format "\
 Type SPC or `y' to overwrite file `%s',
 DEL or `n' to skip to next,
 ESC or `q' to not overwrite any of the remaining files,
 `!' to overwrite all remaining files with no more questions." to)))
-                           (dired-query 'overwrite-query
-                                        "Overwrite `%s'?" to))))
-                   ;; must determine if FROM is marked before file-creator
-                   ;; gets a chance to delete it (in case of a move).
-                   (actual-marker-char
-                    (cond  ((integerp marker-char) marker-char)
-                           (marker-char (dired-file-marker from)) ; slow
-                           (t nil))))
-              (condition-case err
-                  (progn
-                    (funcall file-creator from to dired-overwrite-confirmed)
-                    (if overwrite
-                        ;; If we get here, file-creator hasn't been aborted
-                        ;; and the old entry (if any) has to be deleted
-                        ;; before adding the new entry.
-                        (dired-remove-file to))
-                    (setq success-count (1+ success-count))
-                    (message "%s: %d of %d" operation success-count total)
-                    (dired-add-file to actual-marker-char))
-                (file-error             ; FILE-CREATOR aborted
-                 (progn
-                   (push (dired-make-relative from)
-                         failures)
-                   (dired-log "%s `%s' to `%s' failed:\n%s\n"
-                              operation from to err))))))))
-       fn-list))
+                         (dired-query 'overwrite-query
+                                      "Overwrite `%s'?" to))))
+                 ;; must determine if FROM is marked before file-creator
+                 ;; gets a chance to delete it (in case of a move).
+                 (actual-marker-char
+                  (cond  ((integerp marker-char) marker-char)
+                         (marker-char (dired-file-marker from)) ; slow
+                         (t nil))))
+            (condition-case err
+                (progn
+                  (funcall file-creator from to dired-overwrite-confirmed)
+                  (if overwrite
+                      ;; If we get here, file-creator hasn't been aborted
+                      ;; and the old entry (if any) has to be deleted
+                      ;; before adding the new entry.
+                      (dired-remove-file to))
+                  (setq success-count (1+ success-count))
+                  (message "%s: %d of %d" operation success-count total)
+                  (dired-add-file to actual-marker-char))
+              (file-error               ; FILE-CREATOR aborted
+               (progn
+                 (push (dired-make-relative from)
+                       failures)
+                 (dired-log "%s `%s' to `%s' failed:\n%s\n"
+                            operation from to err))))))))
     (cond
      (dired-create-files-failures
       (setq failures (nconc failures dired-create-files-failures))