aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorStefan Kangas2021-10-05 14:43:11 +0200
committerStefan Kangas2021-10-05 14:45:31 +0200
commitf6901aebad31bce473cf2d438ffec2473d2df05b (patch)
tree8a5c0588a59fc5acb9cca1175823726d522cc51b
parent4103123806311aa42f8ee22082015c0a7c3e30dd (diff)
downloademacs-f6901aebad31bce473cf2d438ffec2473d2df05b.tar.gz
emacs-f6901aebad31bce473cf2d438ffec2473d2df05b.zip
Set advertised calling convention on make-face-* functions
* lisp/faces.el (make-face-bold, make-face-unbold) (make-face-italic, make-face-unitalic, make-face-bold-italic): Use `advertised-calling-convention` to avoid promoting the third _noerror argument; it has been ignored since 1999.
-rw-r--r--lisp/faces.el14
1 files changed, 7 insertions, 7 deletions
diff --git a/lisp/faces.el b/lisp/faces.el
index 302bfa245ec..089cb889090 100644
--- a/lisp/faces.el
+++ b/lisp/faces.el
@@ -861,8 +861,8 @@ is specified, `:italic' is ignored."
861(defun make-face-bold (face &optional frame _noerror) 861(defun make-face-bold (face &optional frame _noerror)
862 "Make the font of FACE be bold, if possible. 862 "Make the font of FACE be bold, if possible.
863FRAME nil or not specified means change face on all frames. 863FRAME nil or not specified means change face on all frames.
864Argument NOERROR is ignored and retained for compatibility.
865Use `set-face-attribute' for finer control of the font weight." 864Use `set-face-attribute' for finer control of the font weight."
865 (declare (advertised-calling-convention (face &optional frame) "29.1"))
866 (interactive (list (read-face-name "Make which face bold" 866 (interactive (list (read-face-name "Make which face bold"
867 (face-at-point t)))) 867 (face-at-point t))))
868 (set-face-attribute face frame :weight 'bold)) 868 (set-face-attribute face frame :weight 'bold))
@@ -870,8 +870,8 @@ Use `set-face-attribute' for finer control of the font weight."
870 870
871(defun make-face-unbold (face &optional frame _noerror) 871(defun make-face-unbold (face &optional frame _noerror)
872 "Make the font of FACE be non-bold, if possible. 872 "Make the font of FACE be non-bold, if possible.
873FRAME nil or not specified means change face on all frames. 873FRAME nil or not specified means change face on all frames."
874Argument NOERROR is ignored and retained for compatibility." 874 (declare (advertised-calling-convention (face &optional frame) "29.1"))
875 (interactive (list (read-face-name "Make which face non-bold" 875 (interactive (list (read-face-name "Make which face non-bold"
876 (face-at-point t)))) 876 (face-at-point t))))
877 (set-face-attribute face frame :weight 'normal)) 877 (set-face-attribute face frame :weight 'normal))
@@ -880,8 +880,8 @@ Argument NOERROR is ignored and retained for compatibility."
880(defun make-face-italic (face &optional frame _noerror) 880(defun make-face-italic (face &optional frame _noerror)
881 "Make the font of FACE be italic, if possible. 881 "Make the font of FACE be italic, if possible.
882FRAME nil or not specified means change face on all frames. 882FRAME nil or not specified means change face on all frames.
883Argument NOERROR is ignored and retained for compatibility.
884Use `set-face-attribute' for finer control of the font slant." 883Use `set-face-attribute' for finer control of the font slant."
884 (declare (advertised-calling-convention (face &optional frame) "29.1"))
885 (interactive (list (read-face-name "Make which face italic" 885 (interactive (list (read-face-name "Make which face italic"
886 (face-at-point t)))) 886 (face-at-point t))))
887 (set-face-attribute face frame :slant 'italic)) 887 (set-face-attribute face frame :slant 'italic))
@@ -889,8 +889,8 @@ Use `set-face-attribute' for finer control of the font slant."
889 889
890(defun make-face-unitalic (face &optional frame _noerror) 890(defun make-face-unitalic (face &optional frame _noerror)
891 "Make the font of FACE be non-italic, if possible. 891 "Make the font of FACE be non-italic, if possible.
892FRAME nil or not specified means change face on all frames. 892FRAME nil or not specified means change face on all frames."
893Argument NOERROR is ignored and retained for compatibility." 893 (declare (advertised-calling-convention (face &optional frame) "29.1"))
894 (interactive (list (read-face-name "Make which face non-italic" 894 (interactive (list (read-face-name "Make which face non-italic"
895 (face-at-point t)))) 895 (face-at-point t))))
896 (set-face-attribute face frame :slant 'normal)) 896 (set-face-attribute face frame :slant 'normal))
@@ -899,8 +899,8 @@ Argument NOERROR is ignored and retained for compatibility."
899(defun make-face-bold-italic (face &optional frame _noerror) 899(defun make-face-bold-italic (face &optional frame _noerror)
900 "Make the font of FACE be bold and italic, if possible. 900 "Make the font of FACE be bold and italic, if possible.
901FRAME nil or not specified means change face on all frames. 901FRAME nil or not specified means change face on all frames.
902Argument NOERROR is ignored and retained for compatibility.
903Use `set-face-attribute' for finer control of font weight and slant." 902Use `set-face-attribute' for finer control of font weight and slant."
903 (declare (advertised-calling-convention (face &optional frame) "29.1"))
904 (interactive (list (read-face-name "Make which face bold-italic" 904 (interactive (list (read-face-name "Make which face bold-italic"
905 (face-at-point t)))) 905 (face-at-point t))))
906 (set-face-attribute face frame :weight 'bold :slant 'italic)) 906 (set-face-attribute face frame :weight 'bold :slant 'italic))