diff options
| author | F. Jason Park | 2023-06-09 23:34:58 -0700 |
|---|---|---|
| committer | F. Jason Park | 2023-06-11 20:53:48 -0700 |
| commit | edfbdb3f1655b1a61fa7a060041e5e58f32bb4a5 (patch) | |
| tree | 8c9807a670a6f8552a5a2942128ebf1f80d5874d | |
| parent | 56e1922281d53ab0c28002a99b27c9a79807d430 (diff) | |
| download | emacs-edfbdb3f1655b1a61fa7a060041e5e58f32bb4a5.tar.gz emacs-edfbdb3f1655b1a61fa7a060041e5e58f32bb4a5.zip | |
Define missing groups for ERC modules
* lisp/erc/erc-imenu.el (erc-imenu): Define group even though there
aren't any associated faces or user options because `imenu' is a
global module, and `define-erc-module' calls `define-minor-mode',
which needs a group for its mode variable. This should have been
handled by bug#60954 but wasn't.
* lisp/erc/erc-sound.el (erc-sound): Move group definition above
module definition.
* lisp/erc/erc-spelling.el (erc-spelling): Define group.
| -rw-r--r-- | lisp/erc/erc-imenu.el | 4 | ||||
| -rw-r--r-- | lisp/erc/erc-sound.el | 8 | ||||
| -rw-r--r-- | lisp/erc/erc-spelling.el | 4 |
3 files changed, 12 insertions, 4 deletions
diff --git a/lisp/erc/erc-imenu.el b/lisp/erc/erc-imenu.el index 60df4e9ac8e..f053c6279b8 100644 --- a/lisp/erc/erc-imenu.el +++ b/lisp/erc/erc-imenu.el | |||
| @@ -41,6 +41,10 @@ | |||
| 41 | (require 'erc) | 41 | (require 'erc) |
| 42 | (require 'imenu) | 42 | (require 'imenu) |
| 43 | 43 | ||
| 44 | (defgroup erc-imenu nil | ||
| 45 | "Imenu integration for ERC." | ||
| 46 | :group 'erc) | ||
| 47 | |||
| 44 | (defun erc-unfill-notice () | 48 | (defun erc-unfill-notice () |
| 45 | "Return text from point to a computed end as a string unfilled. | 49 | "Return text from point to a computed end as a string unfilled. |
| 46 | Don't rely on this function, read it first!" | 50 | Don't rely on this function, read it first!" |
diff --git a/lisp/erc/erc-sound.el b/lisp/erc/erc-sound.el index 9da9202f0cf..083d72805df 100644 --- a/lisp/erc/erc-sound.el +++ b/lisp/erc/erc-sound.el | |||
| @@ -47,6 +47,10 @@ | |||
| 47 | 47 | ||
| 48 | (require 'erc) | 48 | (require 'erc) |
| 49 | 49 | ||
| 50 | (defgroup erc-sound nil | ||
| 51 | "Make ERC play bells and whistles while chatting with people." | ||
| 52 | :group 'erc) | ||
| 53 | |||
| 50 | ;;;###autoload(put 'ctcp-sound 'erc--module 'sound) | 54 | ;;;###autoload(put 'ctcp-sound 'erc--module 'sound) |
| 51 | ;;;###autoload(autoload 'erc-sound-mode "erc-sound") | 55 | ;;;###autoload(autoload 'erc-sound-mode "erc-sound") |
| 52 | (define-erc-module sound ctcp-sound | 56 | (define-erc-module sound ctcp-sound |
| @@ -61,10 +65,6 @@ and play sound files as requested." | |||
| 61 | 65 | ||
| 62 | (erc-define-catalog-entry 'english 'CTCP-SOUND "%n (%u@%h) plays %s:%m") | 66 | (erc-define-catalog-entry 'english 'CTCP-SOUND "%n (%u@%h) plays %s:%m") |
| 63 | 67 | ||
| 64 | (defgroup erc-sound nil | ||
| 65 | "Make ERC play bells and whistles while chatting with people." | ||
| 66 | :group 'erc) | ||
| 67 | |||
| 68 | (defcustom erc-play-sound t | 68 | (defcustom erc-play-sound t |
| 69 | "Play sounds when you receive CTCP SOUND requests." | 69 | "Play sounds when you receive CTCP SOUND requests." |
| 70 | :type 'boolean) | 70 | :type 'boolean) |
diff --git a/lisp/erc/erc-spelling.el b/lisp/erc/erc-spelling.el index 8e5424f4162..83eb849f1b4 100644 --- a/lisp/erc/erc-spelling.el +++ b/lisp/erc/erc-spelling.el | |||
| @@ -33,6 +33,10 @@ | |||
| 33 | (require 'erc) | 33 | (require 'erc) |
| 34 | (require 'flyspell) | 34 | (require 'flyspell) |
| 35 | 35 | ||
| 36 | (defgroup erc-spelling nil | ||
| 37 | "Flyspell integration for ERC." | ||
| 38 | :group 'erc) | ||
| 39 | |||
| 36 | ;;;###autoload(autoload 'erc-spelling-mode "erc-spelling" nil t) | 40 | ;;;###autoload(autoload 'erc-spelling-mode "erc-spelling" nil t) |
| 37 | (define-erc-module spelling nil | 41 | (define-erc-module spelling nil |
| 38 | "Enable flyspell mode in ERC buffers." | 42 | "Enable flyspell mode in ERC buffers." |