aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLars Ingebrigtsen2022-06-21 19:07:46 +0200
committerLars Ingebrigtsen2022-06-21 19:08:25 +0200
commitacf9dcdc51280933eba9f249e41ab41d2896aa93 (patch)
treef9e2b165ad4062a284221d6ac1643da0031422ad
parent1883e532d1aabbf3bb4085824f777382dc190d9c (diff)
downloademacs-acf9dcdc51280933eba9f249e41ab41d2896aa93.tar.gz
emacs-acf9dcdc51280933eba9f249e41ab41d2896aa93.zip
Check defface doc strings
* lisp/emacs-lisp/bytecomp.el (byte-compile-file-form-custom-declare-variable): We already warn about missing groups from byte-compile-normal-call, so this would be a double warning. (custom-declare-face) (byte-compile-file-form-custom-declare-face): Add doc string checking for defface.
-rw-r--r--lisp/emacs-lisp/bytecomp.el12
1 files changed, 6 insertions, 6 deletions
diff --git a/lisp/emacs-lisp/bytecomp.el b/lisp/emacs-lisp/bytecomp.el
index 198eb4df5c8..04c107a7cfa 100644
--- a/lisp/emacs-lisp/bytecomp.el
+++ b/lisp/emacs-lisp/bytecomp.el
@@ -1756,7 +1756,8 @@ It is too wide if it has any lines longer than the largest of
1756 (pcase (car form) 1756 (pcase (car form)
1757 ((or 'autoload 'custom-declare-variable 'defalias 1757 ((or 'autoload 'custom-declare-variable 'defalias
1758 'defconst 'define-abbrev-table 1758 'defconst 'define-abbrev-table
1759 'defvar 'defvaralias) 1759 'defvar 'defvaralias
1760 'custom-declare-face)
1760 (setq kind (nth 0 form)) 1761 (setq kind (nth 0 form))
1761 (setq name (nth 1 form)) 1762 (setq name (nth 1 form))
1762 (setq docs (nth 3 form))) 1763 (setq docs (nth 3 form)))
@@ -2705,11 +2706,10 @@ list that represents a doc string reference.
2705 (byte-compile-keep-pending form)) 2706 (byte-compile-keep-pending form))
2706 2707
2707(put 'custom-declare-variable 'byte-hunk-handler 2708(put 'custom-declare-variable 'byte-hunk-handler
2708 'byte-compile-file-form-custom-declare-variable) 2709 'byte-compile-file-form-defvar-function)
2709(defun byte-compile-file-form-custom-declare-variable (form) 2710
2710 (when (byte-compile-warning-enabled-p 'callargs) 2711(put 'custom-declare-face 'byte-hunk-handler
2711 (byte-compile-nogroup-warn form)) 2712 'byte-compile-docstring-style-warn)
2712 (byte-compile-file-form-defvar-function form))
2713 2713
2714(put 'require 'byte-hunk-handler 'byte-compile-file-form-require) 2714(put 'require 'byte-hunk-handler 'byte-compile-file-form-require)
2715(defun byte-compile-file-form-require (form) 2715(defun byte-compile-file-form-require (form)