diff options
| author | Eli Zaretskii | 2021-03-15 16:56:08 +0200 |
|---|---|---|
| committer | Eli Zaretskii | 2021-03-15 16:56:08 +0200 |
| commit | aabda4263bc2000a69e61e93a232e71f8afedec9 (patch) | |
| tree | 4649d448243c1da445e207b5f26fe786cd35e6f4 | |
| parent | 5e4ec4d3c944f586892e08ea4fb7715e0f6ac365 (diff) | |
| download | emacs-aabda4263bc2000a69e61e93a232e71f8afedec9.tar.gz emacs-aabda4263bc2000a69e61e93a232e71f8afedec9.zip | |
Prefer expand-file-name to concat in native-compilation code
* lisp/emacs-lisp/comp.el (comp-eln-load-path-eff):
* src/comp.c (Fcomp_el_to_eln_filename)
(eln_load_path_final_clean_up): Prefer expand-file-name to concat.
(Bug#43725)
| -rw-r--r-- | lisp/emacs-lisp/comp.el | 6 | ||||
| -rw-r--r-- | src/comp.c | 8 |
2 files changed, 7 insertions, 7 deletions
diff --git a/lisp/emacs-lisp/comp.el b/lisp/emacs-lisp/comp.el index 97efd1ab0c7..5a4a2f6ef15 100644 --- a/lisp/emacs-lisp/comp.el +++ b/lisp/emacs-lisp/comp.el | |||
| @@ -3691,9 +3691,9 @@ Prepare every function for final compilation and drive the C back-end." | |||
| 3691 | "Return a list of effective eln load directories. | 3691 | "Return a list of effective eln load directories. |
| 3692 | Account for `comp-load-path' and `comp-native-version-dir'." | 3692 | Account for `comp-load-path' and `comp-native-version-dir'." |
| 3693 | (mapcar (lambda (dir) | 3693 | (mapcar (lambda (dir) |
| 3694 | (concat (file-name-as-directory | 3694 | (expand-file-name comp-native-version-dir |
| 3695 | (expand-file-name dir invocation-directory)) | 3695 | (file-name-as-directory |
| 3696 | comp-native-version-dir)) | 3696 | (expand-file-name dir invocation-directory)))) |
| 3697 | comp-eln-load-path)) | 3697 | comp-eln-load-path)) |
| 3698 | 3698 | ||
| 3699 | (defun comp-trampoline-filename (subr-name) | 3699 | (defun comp-trampoline-filename (subr-name) |
diff --git a/src/comp.c b/src/comp.c index a79ee4ad87b..29b16c78ac0 100644 --- a/src/comp.c +++ b/src/comp.c | |||
| @@ -4121,8 +4121,8 @@ If BASE-DIR is nil use the first entry in `comp-eln-load-path'. */) | |||
| 4121 | base_dir = Fexpand_file_name (base_dir, Vinvocation_directory); | 4121 | base_dir = Fexpand_file_name (base_dir, Vinvocation_directory); |
| 4122 | 4122 | ||
| 4123 | return Fexpand_file_name (filename, | 4123 | return Fexpand_file_name (filename, |
| 4124 | concat2 (Ffile_name_as_directory (base_dir), | 4124 | Fexpand_file_name (Vcomp_native_version_dir, |
| 4125 | Vcomp_native_version_dir)); | 4125 | base_dir)); |
| 4126 | } | 4126 | } |
| 4127 | 4127 | ||
| 4128 | DEFUN ("comp--install-trampoline", Fcomp__install_trampoline, | 4128 | DEFUN ("comp--install-trampoline", Fcomp__install_trampoline, |
| @@ -4613,8 +4613,8 @@ eln_load_path_final_clean_up (void) | |||
| 4613 | { | 4613 | { |
| 4614 | Lisp_Object files_in_dir = | 4614 | Lisp_Object files_in_dir = |
| 4615 | internal_condition_case_5 (Fdirectory_files, | 4615 | internal_condition_case_5 (Fdirectory_files, |
| 4616 | concat2 (XCAR (dir_tail), | 4616 | Fexpand_file_name (Vcomp_native_version_dir, |
| 4617 | Vcomp_native_version_dir), | 4617 | XCAR (dir_tail)), |
| 4618 | Qt, build_string ("\\.eln\\.old\\'"), Qnil, | 4618 | Qt, build_string ("\\.eln\\.old\\'"), Qnil, |
| 4619 | Qnil, Qt, return_nil); | 4619 | Qnil, Qt, return_nil); |
| 4620 | FOR_EACH_TAIL (files_in_dir) | 4620 | FOR_EACH_TAIL (files_in_dir) |