diff options
| author | Stefan Kangas | 2025-01-26 20:04:07 +0100 |
|---|---|---|
| committer | Stefan Kangas | 2025-01-26 20:09:08 +0100 |
| commit | 6e2e7265a04f63f482db7fbdfd8e2519d8bfe03e (patch) | |
| tree | 9481b02cc364816c4bb47308685debd17560fc7f | |
| parent | b07c12ce59c96db753a1f8f3a829f9ab5514e35f (diff) | |
| download | emacs-6e2e7265a04f63f482db7fbdfd8e2519d8bfe03e.tar.gz emacs-6e2e7265a04f63f482db7fbdfd8e2519d8bfe03e.zip | |
Prefer static switch-case checking in pdumper
* src/pdumper.c (dump_fwd, dump_symbol, dump_drain_cold_data)
(dump_do_fixup, dump_anonymous_allocate_w32)
(dump_anonymous_allocate_posix, dump_map_file_w32, dump_map_file_posix)
(dump_do_emacs_relocation): Remove default clauses to allow static
checking using -Wswitch.
| -rw-r--r-- | src/pdumper.c | 19 |
1 files changed, 0 insertions, 19 deletions
diff --git a/src/pdumper.c b/src/pdumper.c index e7e6e2c392c..77d4407935e 100644 --- a/src/pdumper.c +++ b/src/pdumper.c | |||
| @@ -2390,8 +2390,6 @@ dump_fwd (struct dump_context *ctx, lispfwd fwd) | |||
| 2390 | case Lisp_Fwd_Kboard_Obj: | 2390 | case Lisp_Fwd_Kboard_Obj: |
| 2391 | offset = dump_fwd_kboard_obj (ctx, p); | 2391 | offset = dump_fwd_kboard_obj (ctx, p); |
| 2392 | break; | 2392 | break; |
| 2393 | default: | ||
| 2394 | emacs_abort (); | ||
| 2395 | } | 2393 | } |
| 2396 | 2394 | ||
| 2397 | return offset; | 2395 | return offset; |
| @@ -2523,8 +2521,6 @@ dump_symbol (struct dump_context *ctx, | |||
| 2523 | case SYMBOL_FORWARDED: | 2521 | case SYMBOL_FORWARDED: |
| 2524 | dump_field_fixup_later (ctx, &out, symbol, &symbol->u.s.val.fwd); | 2522 | dump_field_fixup_later (ctx, &out, symbol, &symbol->u.s.val.fwd); |
| 2525 | break; | 2523 | break; |
| 2526 | default: | ||
| 2527 | emacs_abort (); | ||
| 2528 | } | 2524 | } |
| 2529 | dump_field_lv (ctx, &out, symbol, &symbol->u.s.function, WEIGHT_NORMAL); | 2525 | dump_field_lv (ctx, &out, symbol, &symbol->u.s.function, WEIGHT_NORMAL); |
| 2530 | dump_field_lv (ctx, &out, symbol, &symbol->u.s.plist, WEIGHT_NORMAL); | 2526 | dump_field_lv (ctx, &out, symbol, &symbol->u.s.plist, WEIGHT_NORMAL); |
| @@ -3603,8 +3599,6 @@ dump_drain_cold_data (struct dump_context *ctx) | |||
| 3603 | dump_cold_native_subr (ctx, data); | 3599 | dump_cold_native_subr (ctx, data); |
| 3604 | break; | 3600 | break; |
| 3605 | #endif | 3601 | #endif |
| 3606 | default: | ||
| 3607 | emacs_abort (); | ||
| 3608 | } | 3602 | } |
| 3609 | } | 3603 | } |
| 3610 | 3604 | ||
| @@ -4069,8 +4063,6 @@ dump_do_fixup (struct dump_context *ctx, | |||
| 4069 | do_write = false; | 4063 | do_write = false; |
| 4070 | break; | 4064 | break; |
| 4071 | } | 4065 | } |
| 4072 | default: | ||
| 4073 | emacs_abort (); | ||
| 4074 | } | 4066 | } |
| 4075 | if (do_write) | 4067 | if (do_write) |
| 4076 | dump_write (ctx, &dump_value, sizeof (dump_value)); | 4068 | dump_write (ctx, &dump_value, sizeof (dump_value)); |
| @@ -4529,8 +4521,6 @@ dump_anonymous_allocate_w32 (void *base, | |||
| 4529 | mem_type = MEM_COMMIT; | 4521 | mem_type = MEM_COMMIT; |
| 4530 | mem_prot = PAGE_READWRITE; | 4522 | mem_prot = PAGE_READWRITE; |
| 4531 | break; | 4523 | break; |
| 4532 | default: | ||
| 4533 | emacs_abort (); | ||
| 4534 | } | 4524 | } |
| 4535 | 4525 | ||
| 4536 | ret = VirtualAlloc (base, size, mem_type, mem_prot); | 4526 | ret = VirtualAlloc (base, size, mem_type, mem_prot); |
| @@ -4569,8 +4559,6 @@ dump_anonymous_allocate_posix (void *base, | |||
| 4569 | case DUMP_MEMORY_ACCESS_READWRITE: | 4559 | case DUMP_MEMORY_ACCESS_READWRITE: |
| 4570 | mem_prot = PROT_READ | PROT_WRITE; | 4560 | mem_prot = PROT_READ | PROT_WRITE; |
| 4571 | break; | 4561 | break; |
| 4572 | default: | ||
| 4573 | emacs_abort (); | ||
| 4574 | } | 4562 | } |
| 4575 | 4563 | ||
| 4576 | int mem_flags = MAP_PRIVATE | MAP_ANONYMOUS; | 4564 | int mem_flags = MAP_PRIVATE | MAP_ANONYMOUS; |
| @@ -4663,7 +4651,6 @@ dump_map_file_w32 (void *base, int fd, off_t offset, size_t size, | |||
| 4663 | case DUMP_MEMORY_ACCESS_READWRITE: | 4651 | case DUMP_MEMORY_ACCESS_READWRITE: |
| 4664 | protect = PAGE_WRITECOPY; /* for Windows 9X */ | 4652 | protect = PAGE_WRITECOPY; /* for Windows 9X */ |
| 4665 | break; | 4653 | break; |
| 4666 | default: | ||
| 4667 | case DUMP_MEMORY_ACCESS_NONE: | 4654 | case DUMP_MEMORY_ACCESS_NONE: |
| 4668 | case DUMP_MEMORY_ACCESS_READ: | 4655 | case DUMP_MEMORY_ACCESS_READ: |
| 4669 | protect = PAGE_READONLY; | 4656 | protect = PAGE_READONLY; |
| @@ -4691,8 +4678,6 @@ dump_map_file_w32 (void *base, int fd, off_t offset, size_t size, | |||
| 4691 | case DUMP_MEMORY_ACCESS_READWRITE: | 4678 | case DUMP_MEMORY_ACCESS_READWRITE: |
| 4692 | map_access = FILE_MAP_COPY; | 4679 | map_access = FILE_MAP_COPY; |
| 4693 | break; | 4680 | break; |
| 4694 | default: | ||
| 4695 | emacs_abort (); | ||
| 4696 | } | 4681 | } |
| 4697 | 4682 | ||
| 4698 | ret = MapViewOfFileEx (section, | 4683 | ret = MapViewOfFileEx (section, |
| @@ -4735,8 +4720,6 @@ dump_map_file_posix (void *base, int fd, off_t offset, size_t size, | |||
| 4735 | mem_prot = PROT_READ | PROT_WRITE; | 4720 | mem_prot = PROT_READ | PROT_WRITE; |
| 4736 | mem_flags = MAP_PRIVATE; | 4721 | mem_flags = MAP_PRIVATE; |
| 4737 | break; | 4722 | break; |
| 4738 | default: | ||
| 4739 | emacs_abort (); | ||
| 4740 | } | 4723 | } |
| 4741 | 4724 | ||
| 4742 | if (base) | 4725 | if (base) |
| @@ -5603,8 +5586,6 @@ dump_do_emacs_relocation (const uintptr_t dump_base, | |||
| 5603 | memcpy (emacs_ptr_at (reloc.emacs_offset), &lv, sizeof (lv)); | 5586 | memcpy (emacs_ptr_at (reloc.emacs_offset), &lv, sizeof (lv)); |
| 5604 | break; | 5587 | break; |
| 5605 | } | 5588 | } |
| 5606 | default: | ||
| 5607 | fatal ("unrecognied relocation type %d", (int) reloc.type); | ||
| 5608 | } | 5589 | } |
| 5609 | } | 5590 | } |
| 5610 | 5591 | ||