diff options
| author | Basil L. Contovounesios | 2022-09-14 13:51:41 +0300 |
|---|---|---|
| committer | Basil L. Contovounesios | 2022-09-14 14:20:52 +0300 |
| commit | 6a5043e9f6dc8120f82d13ebde976df5f0a2ea73 (patch) | |
| tree | ad69642975297b9c48d5f3830fbdff38337b9bcc | |
| parent | 8c3b40254bfa29c843eb4ff967c5e6f7c717bb07 (diff) | |
| download | emacs-6a5043e9f6dc8120f82d13ebde976df5f0a2ea73.tar.gz emacs-6a5043e9f6dc8120f82d13ebde976df5f0a2ea73.zip | |
Fix more misleading cl-case quoting in tests
* test/lisp/dnd-tests.el (x-begin-drag):
* test/lisp/so-long-tests/so-long-tests-helpers.el
(so-long-tests-assert-active, so-long-tests-assert-reverted): Remove
misleading quoting in cl-case clauses (bug#51368).
| -rw-r--r-- | test/lisp/dnd-tests.el | 10 | ||||
| -rw-r--r-- | test/lisp/so-long-tests/so-long-tests-helpers.el | 12 |
2 files changed, 11 insertions, 11 deletions
diff --git a/test/lisp/dnd-tests.el b/test/lisp/dnd-tests.el index 88f6e694577..67b660fc124 100644 --- a/test/lisp/dnd-tests.el +++ b/test/lisp/dnd-tests.el | |||
| @@ -52,13 +52,13 @@ | |||
| 52 | ;; Verify that the action is valid and pretend the drag succeeded | 52 | ;; Verify that the action is valid and pretend the drag succeeded |
| 53 | ;; (by returning the action). | 53 | ;; (by returning the action). |
| 54 | (cl-ecase action | 54 | (cl-ecase action |
| 55 | ('XdndActionCopy action) | 55 | (XdndActionCopy action) |
| 56 | ('XdndActionMove action) | 56 | (XdndActionMove action) |
| 57 | ('XdndActionLink action) | 57 | (XdndActionLink action) |
| 58 | ;; These two are not technically valid, but x-begin-drag accepts | 58 | ;; These two are not technically valid, but x-begin-drag accepts |
| 59 | ;; them anyway. | 59 | ;; them anyway. |
| 60 | ('XdndActionPrivate action) | 60 | (XdndActionPrivate action) |
| 61 | ('XdndActionAsk 'XdndActionPrivate)))) | 61 | (XdndActionAsk 'XdndActionPrivate)))) |
| 62 | 62 | ||
| 63 | ;; This doesn't work during tests. | 63 | ;; This doesn't work during tests. |
| 64 | (defalias 'gui-set-selection | 64 | (defalias 'gui-set-selection |
diff --git a/test/lisp/so-long-tests/so-long-tests-helpers.el b/test/lisp/so-long-tests/so-long-tests-helpers.el index 852e7811cc3..79df532f899 100644 --- a/test/lisp/so-long-tests/so-long-tests-helpers.el +++ b/test/lisp/so-long-tests/so-long-tests-helpers.el | |||
| @@ -41,14 +41,14 @@ | |||
| 41 | (should (eq so-long--active t)) | 41 | (should (eq so-long--active t)) |
| 42 | ;; pcase fails here in Emacs 24. | 42 | ;; pcase fails here in Emacs 24. |
| 43 | (cl-case action | 43 | (cl-case action |
| 44 | ('so-long-mode | 44 | (so-long-mode |
| 45 | (should (eq major-mode 'so-long-mode)) | 45 | (should (eq major-mode 'so-long-mode)) |
| 46 | (so-long-tests-assert-overrides) | 46 | (so-long-tests-assert-overrides) |
| 47 | (so-long-tests-assert-preserved)) | 47 | (so-long-tests-assert-preserved)) |
| 48 | ('so-long-minor-mode | 48 | (so-long-minor-mode |
| 49 | (should (eq so-long-minor-mode t)) | 49 | (should (eq so-long-minor-mode t)) |
| 50 | (so-long-tests-assert-overrides)) | 50 | (so-long-tests-assert-overrides)) |
| 51 | ('longlines-mode | 51 | (longlines-mode |
| 52 | (should (eq longlines-mode t)))))) | 52 | (should (eq longlines-mode t)))))) |
| 53 | 53 | ||
| 54 | (defun so-long-tests-assert-reverted (action) | 54 | (defun so-long-tests-assert-reverted (action) |
| @@ -61,14 +61,14 @@ | |||
| 61 | (should (eq so-long--active nil)) | 61 | (should (eq so-long--active nil)) |
| 62 | ;; pcase fails here in Emacs 24. | 62 | ;; pcase fails here in Emacs 24. |
| 63 | (cl-case action | 63 | (cl-case action |
| 64 | ('so-long-mode | 64 | (so-long-mode |
| 65 | (should-not (eq major-mode 'so-long-mode)) | 65 | (should-not (eq major-mode 'so-long-mode)) |
| 66 | (so-long-tests-assert-overrides-reverted) | 66 | (so-long-tests-assert-overrides-reverted) |
| 67 | (so-long-tests-assert-preserved)) | 67 | (so-long-tests-assert-preserved)) |
| 68 | ('so-long-minor-mode | 68 | (so-long-minor-mode |
| 69 | (should-not (eq so-long-minor-mode t)) | 69 | (should-not (eq so-long-minor-mode t)) |
| 70 | (so-long-tests-assert-overrides-reverted)) | 70 | (so-long-tests-assert-overrides-reverted)) |
| 71 | ('longlines-mode | 71 | (longlines-mode |
| 72 | (should-not (eq longlines-mode t)))))) | 72 | (should-not (eq longlines-mode t)))))) |
| 73 | 73 | ||
| 74 | (defun so-long-tests-assert-and-revert (action) | 74 | (defun so-long-tests-assert-and-revert (action) |