diff options
| author | Eli Zaretskii | 2024-05-08 16:13:27 +0300 |
|---|---|---|
| committer | Eli Zaretskii | 2024-05-08 16:13:27 +0300 |
| commit | 3d65d4306b98efba59ffabe86d8c99e6f37cd8d2 (patch) | |
| tree | 52524ae5b425c50f0746a48704a7bd3ac85c0318 | |
| parent | b392169e541a29178d7ae20f329d48b3d2bd78cf (diff) | |
| download | emacs-3d65d4306b98efba59ffabe86d8c99e6f37cd8d2.tar.gz emacs-3d65d4306b98efba59ffabe86d8c99e6f37cd8d2.zip | |
Avoid errors in 'image-dired-tag-thumbnail'
* lisp/image/image-dired.el (image-dired-tag-thumbnail)
(image-dired-tag-thumbnail-remove): Move here from
image-dired-tags.el. (Bug#70821)
| -rw-r--r-- | lisp/image/image-dired-tags.el | 24 | ||||
| -rw-r--r-- | lisp/image/image-dired.el | 22 |
2 files changed, 22 insertions, 24 deletions
diff --git a/lisp/image/image-dired-tags.el b/lisp/image/image-dired-tags.el index 2b5248cb14b..54595adc147 100644 --- a/lisp/image/image-dired-tags.el +++ b/lisp/image/image-dired-tags.el | |||
| @@ -32,8 +32,6 @@ | |||
| 32 | 32 | ||
| 33 | (require 'image-dired-util) | 33 | (require 'image-dired-util) |
| 34 | 34 | ||
| 35 | (declare-function image-dired--with-marked "image-dired") | ||
| 36 | |||
| 37 | (defvar image-dired-dir) | 35 | (defvar image-dired-dir) |
| 38 | (defvar image-dired-thumbnail-storage) | 36 | (defvar image-dired-thumbnail-storage) |
| 39 | (defvar image-dired-tags-db-file) | 37 | (defvar image-dired-tags-db-file) |
| @@ -156,18 +154,6 @@ With prefix ARG, tag the file at point." | |||
| 156 | (cons x tag)) | 154 | (cons x tag)) |
| 157 | files)))) | 155 | files)))) |
| 158 | 156 | ||
| 159 | (defun image-dired-tag-thumbnail () | ||
| 160 | "Tag current or marked thumbnails." | ||
| 161 | (interactive nil image-dired-thumbnail-mode) | ||
| 162 | (let ((tag (completing-read | ||
| 163 | "Tags to add (separate tags with a semicolon): " | ||
| 164 | image-dired-tag-history nil nil nil 'image-dired-tag-history))) | ||
| 165 | (image-dired--with-marked | ||
| 166 | (image-dired-write-tags | ||
| 167 | (list (cons (image-dired-original-file-name) tag))) | ||
| 168 | (image-dired-update-property | ||
| 169 | 'tags (image-dired-list-tags (image-dired-original-file-name)))))) | ||
| 170 | |||
| 171 | ;;;###autoload | 157 | ;;;###autoload |
| 172 | (defun image-dired-delete-tag (arg) | 158 | (defun image-dired-delete-tag (arg) |
| 173 | "Remove tag for selected file(s). | 159 | "Remove tag for selected file(s). |
| @@ -181,16 +167,6 @@ With prefix argument ARG, remove tag from file at point." | |||
| 181 | (setq files (dired-get-marked-files))) | 167 | (setq files (dired-get-marked-files))) |
| 182 | (image-dired-remove-tag files tag))) | 168 | (image-dired-remove-tag files tag))) |
| 183 | 169 | ||
| 184 | (defun image-dired-tag-thumbnail-remove () | ||
| 185 | "Remove tag from current or marked thumbnails." | ||
| 186 | (interactive nil image-dired-thumbnail-mode) | ||
| 187 | (let ((tag (completing-read "Tag to remove: " image-dired-tag-history | ||
| 188 | nil nil nil 'image-dired-tag-history))) | ||
| 189 | (image-dired--with-marked | ||
| 190 | (image-dired-remove-tag (image-dired-original-file-name) tag) | ||
| 191 | (image-dired-update-property | ||
| 192 | 'tags (image-dired-list-tags (image-dired-original-file-name)))))) | ||
| 193 | |||
| 194 | (defun image-dired-write-comments (file-comments) | 170 | (defun image-dired-write-comments (file-comments) |
| 195 | "Write file comments specified by FILE-COMMENTS comments to database. | 171 | "Write file comments specified by FILE-COMMENTS comments to database. |
| 196 | FILE-COMMENTS is an alist on the following form: | 172 | FILE-COMMENTS is an alist on the following form: |
diff --git a/lisp/image/image-dired.el b/lisp/image/image-dired.el index 26d5811f159..00dc8e31d29 100644 --- a/lisp/image/image-dired.el +++ b/lisp/image/image-dired.el | |||
| @@ -1714,6 +1714,28 @@ Dired." | |||
| 1714 | (cons (list tag file) (cdr image-dired-tag-file-list)))) | 1714 | (cons (list tag file) (cdr image-dired-tag-file-list)))) |
| 1715 | (setq image-dired-tag-file-list (list (list tag file)))))) | 1715 | (setq image-dired-tag-file-list (list (list tag file)))))) |
| 1716 | 1716 | ||
| 1717 | (defun image-dired-tag-thumbnail-remove () | ||
| 1718 | "Remove tag from current or marked thumbnails." | ||
| 1719 | (interactive nil image-dired-thumbnail-mode) | ||
| 1720 | (let ((tag (completing-read "Tag to remove: " image-dired-tag-history | ||
| 1721 | nil nil nil 'image-dired-tag-history))) | ||
| 1722 | (image-dired--with-marked | ||
| 1723 | (image-dired-remove-tag (image-dired-original-file-name) tag) | ||
| 1724 | (image-dired-update-property | ||
| 1725 | 'tags (image-dired-list-tags (image-dired-original-file-name)))))) | ||
| 1726 | |||
| 1727 | (defun image-dired-tag-thumbnail () | ||
| 1728 | "Tag current or marked thumbnails." | ||
| 1729 | (interactive nil image-dired-thumbnail-mode) | ||
| 1730 | (let ((tag (completing-read | ||
| 1731 | "Tags to add (separate tags with a semicolon): " | ||
| 1732 | image-dired-tag-history nil nil nil 'image-dired-tag-history))) | ||
| 1733 | (image-dired--with-marked | ||
| 1734 | (image-dired-write-tags | ||
| 1735 | (list (cons (image-dired-original-file-name) tag))) | ||
| 1736 | (image-dired-update-property | ||
| 1737 | 'tags (image-dired-list-tags (image-dired-original-file-name)))))) | ||
| 1738 | |||
| 1717 | (defvar image-dired-slideshow-count 0 | 1739 | (defvar image-dired-slideshow-count 0 |
| 1718 | "Keeping track on number of images in slideshow.") | 1740 | "Keeping track on number of images in slideshow.") |
| 1719 | (make-obsolete-variable 'image-dired-slideshow-count "no longer used." "29.1") | 1741 | (make-obsolete-variable 'image-dired-slideshow-count "no longer used." "29.1") |