aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorF. Jason Park2025-10-29 22:43:12 -0700
committerF. Jason Park2025-11-02 20:25:27 -0800
commitf591d1c02745af9ce8cf4ed7dc4ada05ca4f822b (patch)
treea0567a792f901b5c03c6c926b9a3c7cc22ec4807
parentb01435306a36e4e75671fbe7bacea351f89947d5 (diff)
downloademacs-f591d1c02745af9ce8cf4ed7dc4ada05ca4f822b.tar.gz
emacs-f591d1c02745af9ce8cf4ed7dc4ada05ca4f822b.zip
; Skip erc-keep-place-indicator test on Emacs 27
* test/lisp/erc/erc-scenarios-base-reuse-buffers.el (erc-scenarios-common--base-reuse-buffers-channel-buffers): Extend some timeouts. * test/lisp/erc/erc-scenarios-keep-place-indicator.el (erc-scenarios-keep-place-indicator--follow): Prefer `ert-skip' here instead of an :unstable tag because ERC's tests can run locally on some systems with "SELECTOR=t".
-rw-r--r--test/lisp/erc/erc-scenarios-base-reuse-buffers.el6
-rw-r--r--test/lisp/erc/erc-scenarios-keep-place-indicator.el3
2 files changed, 5 insertions, 4 deletions
diff --git a/test/lisp/erc/erc-scenarios-base-reuse-buffers.el b/test/lisp/erc/erc-scenarios-base-reuse-buffers.el
index 860cd79be11..d9d8bdaa4de 100644
--- a/test/lisp/erc/erc-scenarios-base-reuse-buffers.el
+++ b/test/lisp/erc/erc-scenarios-base-reuse-buffers.el
@@ -107,21 +107,21 @@ Adapted from scenario clash-of-chans/uniquify described in Bug#48598:
107 107
108 (ert-info ("#chan@foonet is exclusive and not contaminated") 108 (ert-info ("#chan@foonet is exclusive and not contaminated")
109 (with-current-buffer "#chan/127.0.0.1" 109 (with-current-buffer "#chan/127.0.0.1"
110 (funcall expect 1 "<bob>") 110 (funcall expect 10 "<bob>")
111 (erc-d-t-absent-for 0.1 "<joe>") 111 (erc-d-t-absent-for 0.1 "<joe>")
112 (funcall expect 1 "strength to climb") 112 (funcall expect 1 "strength to climb")
113 (should (eq erc-server-process server-process-foo)))) 113 (should (eq erc-server-process server-process-foo))))
114 114
115 (ert-info ("#chan@barnet is exclusive and not contaminated") 115 (ert-info ("#chan@barnet is exclusive and not contaminated")
116 (with-current-buffer "#chan/127.0.0.1<2>" 116 (with-current-buffer "#chan/127.0.0.1<2>"
117 (funcall expect 1 "<joe>") 117 (funcall expect 10 "<joe>")
118 (erc-d-t-absent-for 0.1 "<bob>") 118 (erc-d-t-absent-for 0.1 "<bob>")
119 (funcall expect 1 "the loudest noise") 119 (funcall expect 1 "the loudest noise")
120 (should (eq erc-server-process server-process-bar)))) 120 (should (eq erc-server-process server-process-bar))))
121 121
122 (ert-info ("Part #chan@foonet") 122 (ert-info ("Part #chan@foonet")
123 (with-current-buffer "#chan/127.0.0.1" 123 (with-current-buffer "#chan/127.0.0.1"
124 (erc-d-t-search-for 1 "shake my sword") 124 (erc-d-t-search-for 10 "shake my sword")
125 (erc-cmd-PART "#chan") 125 (erc-cmd-PART "#chan")
126 (funcall expect 3 "You have left channel #chan") 126 (funcall expect 3 "You have left channel #chan")
127 (should-not (erc-get-channel-user (erc-current-nick))) 127 (should-not (erc-get-channel-user (erc-current-nick)))
diff --git a/test/lisp/erc/erc-scenarios-keep-place-indicator.el b/test/lisp/erc/erc-scenarios-keep-place-indicator.el
index 2e0babfd2ae..7ff668f0eda 100644
--- a/test/lisp/erc/erc-scenarios-keep-place-indicator.el
+++ b/test/lisp/erc/erc-scenarios-keep-place-indicator.el
@@ -35,7 +35,8 @@
35 ,@(and (getenv "ERC_TESTS_GRAPHICAL") '(:erc--graphical))) 35 ,@(and (getenv "ERC_TESTS_GRAPHICAL") '(:erc--graphical)))
36 36
37 ;; ERC's tests also run in external CI that exports this variable. 37 ;; ERC's tests also run in external CI that exports this variable.
38 (when (getenv "CI") 38 ;; Skip on 27 because `erc-scrolltobottom-all' currently requires 28+.
39 (when (or (getenv "CI") (< emacs-major-version 28))
39 (ert-skip "Times out intermittently")) 40 (ert-skip "Times out intermittently"))
40 41
41 (should-not erc-scrolltobottom-all) 42 (should-not erc-scrolltobottom-all)