emacs/test/src/xfaces-tests.el, branch scratch/alloc Emacs is the extensible, customizable, self-documenting real-time display editor. ; Add 2023 to copyright years. 2023-01-01T10:31:12+00:00 Eli Zaretskii 2023-01-01T10:31:12+00:00 cae528457cb862dc886a34240c9d4c73035b6659 






Don't accept whitespace or hex floats in rgbi: colour specs
2022-03-06T13:07:26+00:00

Mattias Engdegård

2022-03-06T09:50:27+00:00

6eeab90632506348a58d264eb3304625756c8659

`color-values-from-color-spec` (new in Emacs 28) erroneously accepted
leading whitespace and hex floats in rgbi: components.

Reported by Philip Kaludercic.

* src/xfaces.c (parse_float_color_comp): Disallow leading whitespace
and hex floats.
* test/src/xfaces-tests.el
(xfaces-internal-color-values-from-color-spec): Add test cases.





`color-values-from-color-spec` (new in Emacs 28) erroneously accepted
leading whitespace and hex floats in rgbi: components.

Reported by Philip Kaludercic.

* src/xfaces.c (parse_float_color_comp): Disallow leading whitespace
and hex floats.
* test/src/xfaces-tests.el
(xfaces-internal-color-values-from-color-spec): Add test cases.







; Add 2022 to copyright years.
2022-01-01T07:45:51+00:00

Eli Zaretskii

2022-01-01T07:45:51+00:00

19dcb237b5b02b36580294ab309124f346a66024












; Minor stylistic checkdoc fixes in test/**/*.el
2021-09-26T15:53:23+00:00

Stefan Kangas

2021-09-25T23:53:56+00:00

8bb28e740dd2cc8058d7833dd60b0ef9a8765c1b












Update copyright year to 2021
2021-01-01T09:13:56+00:00

Paul Eggert

2021-01-01T09:13:56+00:00

ba05d005e5a81bc123ad8da928b1bccb6b160e7a

Run "TZ=UTC0 admin/update-copyright".





Run "TZ=UTC0 admin/update-copyright".







Minor improvements as followup to recent RGB string-parsing change
2020-06-22T15:32:01+00:00

Eli Zaretskii

2020-06-22T15:32:01+00:00

30ff2433b16dba2c4e36c6eda6f808c6f2cb46d1

* src/xfaces.c (Finternal_color_values_from_color_spec): Rename to...
(Fcolor_values_from_color_spec): ...this.  Callers changed.
Rename the argument to SPEC and improve the doc string.
(parse_color_spec, parse_float_color_comp, parse_hex_color_comp):
Improve commentary.
(parse_color_spec): Rename the argument S to SPEC.

* etc/NEWS: Mention 'color-values-from-color-spec'.





* src/xfaces.c (Finternal_color_values_from_color_spec): Rename to...
(Fcolor_values_from_color_spec): ...this.  Callers changed.
Rename the argument to SPEC and improve the doc string.
(parse_color_spec, parse_float_color_comp, parse_hex_color_comp):
Improve commentary.
(parse_color_spec): Rename the argument S to SPEC.

* etc/NEWS: Mention 'color-values-from-color-spec'.







Consolidate #RGB string parsers
2020-06-21T19:22:26+00:00

Mattias Engdegård

2020-06-12T16:12:37+00:00

9fe2bdb88a4ebd4b2286c1c2a2a2ba7411af01b6

Use a single parser of color strings in the #RGB, rgb:R/G/B and
rgbi:R/G/B formats, replacing four existing ones.  Previously,
error-checking was spotty, handling of the rgbi: format not always
present, and normalization of the result was sometimes incorrect.

* src/dispextern.h: New prototype.
* src/xfaces.c (parse_hex_color_comp, parse_float_color_comp)
(parse_color_spec, Finternal-color_values_from_color_spec): New functions.
* test/src/xfaces-tests.el (xfaces-internal-color-values-from-color-spec):
New test.
* lisp/term/tty-colors.el (tty-color-standard-values):
Use internal-color-values-from-color-spec, replacing old parser.
* src/nsterm.m (ns_get_color):
* src/w32fns.c (x_to_w32_color):
* src/xterm.c (x_parse_color): Use parse_color_spec, replacing old
parsers.
(HEX_COLOR_NAME_LENGTH): Remove #define.





Use a single parser of color strings in the #RGB, rgb:R/G/B and
rgbi:R/G/B formats, replacing four existing ones.  Previously,
error-checking was spotty, handling of the rgbi: format not always
present, and normalization of the result was sometimes incorrect.

* src/dispextern.h: New prototype.
* src/xfaces.c (parse_hex_color_comp, parse_float_color_comp)
(parse_color_spec, Finternal-color_values_from_color_spec): New functions.
* test/src/xfaces-tests.el (xfaces-internal-color-values-from-color-spec):
New test.
* lisp/term/tty-colors.el (tty-color-standard-values):
Use internal-color-values-from-color-spec, replacing old parser.
* src/nsterm.m (ns_get_color):
* src/w32fns.c (x_to_w32_color):
* src/xterm.c (x_parse_color): Use parse_color_spec, replacing old
parsers.
(HEX_COLOR_NAME_LENGTH): Remove #define.







; * test/src/xfaces-tests.el (xfaces-color-distance): Fix bug id
2020-06-04T08:56:20+00:00

Mattias Engdegård

2020-06-04T08:55:16+00:00

4fff6502368e87b3c031589a1a96267243f868b0












Make color-distance symmetric and more accurate
2020-06-03T17:09:33+00:00

Mattias Engdegård

2020-06-02T20:31:14+00:00

7e8c1a671872ef8e45057f25912594cf548639ab

* src/xfaces.c (color_distance): Don't throw away the low 8 bits of
the colours, and make the function symmetric (bug41544)
(Fcolor_distance): Add caution about this not being a true metric.
* test/src/xfaces-tests.el: New file.





* src/xfaces.c (color_distance): Don't throw away the low 8 bits of
the colours, and make the function symmetric (bug41544)
(Fcolor_distance): Add caution about this not being a true metric.
* test/src/xfaces-tests.el: New file.