* test/lisp/textmodes/ispell-tests/ispell-tests.el (ispell/ispell-accept-buffer-local-defs/simple): Don't treat Aspell as Ispell even if it pretends to be. (Bug#80165)
Some of the fixes are to continue to use American rather than British spelling. * doc/misc/modus-themes.org (my-modus-themes-engraved-faces): Fix misspelled ‘:foreground’s. * etc/themes/modus-themes.el (modus-themes-faces): Fix misspelled ‘modus-themes-bold’. * lisp/emacs-lisp/rx.el (rx--normalize-char-pattern): Rename from rx--normalise-char-pattern. (rx--optimize-or-args): Rename from rx--optimise-or-args. * lisp/frame.el (frame--special-parameters): Fix misspelled "right-divider-width". * lisp/net/tramp.el (tramp-fingerprint-prompt-regexp): Use American spelling “centered”, to match current libfprintf. * lisp/org/org-fold-core.el (org-fold-core--optimize-for-huge-buffers): Rename from org-fold-core--optimise-for-huge-buffers. (org-fold-core-update-optimization): Rename from org-fold-core-update-optimisation, leaving an alias behind. (org-fold-core-remove-optimization): Rename from org-fold-core-remove-optimisation, leaving an alias behind. * lisp/org/org.el (org-advertized-archive-subtree): This alias is now obsolete. * lisp/play/zone.el (zone-ignored-buffers): Fix misspelling of ‘zone--buffer-encrypted-p’. * lisp/progmodes/csharp-mode.el (csharp-ts-mode-faces): Fix misspelling of ‘csharp’ group. * lisp/vc/vc.el (vc-clonable-backends-custom-type): Rename from vc-cloneable-backends-custom-type, leaving an alias behind. * test/lisp/emacs-lisp/bytecomp-tests.el: (bytecomp-tests--warn-arity-non-compiled-callee): Rename from bytecomp-tests--warn-arity-noncompiled-callee. (bytecomp-test-defface-spec): Reword a deliberate misspelling of “default” that is so common I don’t want it to pollute the spelling dictionary. * test/lisp/emacs-lisp/package-vc-tests.el: (package-vc-tests-preserve-artifacts): Rename from package-vc-tests-preserve-artifacts. * test/lisp/eshell/em-prompt-tests.el: (em-prompt-test/forward-backward-paragraph-1): Reword a deliberate misspelling of “goodbye” that is so common I don’t want it to pollute the spelling dictionary.
Simplify fill-tests.el by grouping similar tests in the same erts file. Move the test code into the erts files, so it is closer to the test cases, which provides context. Add basic test cases for common filling operations and for the scenarios described in Bug#79575. * test/lisp/textmodes/fill-tests.el (fill-test-end-period) (fill-test-haskell): Rename from `test-fill-end-period' and `test-fill-haskell' to follow the same naming convention of the other tests. (fill-test-fill-region-as-paragraph-default) (fill-test-fill-region-as-paragraph-semlf) (fill-test-fill-region-as-paragraph, fill-test-fill-region) (fill-test-fill-paragraph, fill-test-fill-paragraph-semlf): Group tests and move test code into erts files. (fill-test-fill-paragraph-semlf-emacs-lisp-mode) (fill-test-fill-paragraph-semlf-c-mode) (fill-test-fill-paragraph-semlf-org-mode) (fill-test-fill-paragraph-semlf-markdown-mode): Rename from `fill-test-semlf-emacs-lisp-mode', `fill-test-semlf-c-mode', `fill-test-semlf-org-mode' and `fill-test-semlf-markdown-mode'. Move test code into erts files. (fill-test-semlf, fill-test-semlf-fill-region) (fill-test-semlf-justify) (fill-test-semlf-sentence-end-double-space) (fill-test-semlf-fill-column) (fill-test-semlf-punctuation-marks, fill-test-semlf-twice) (fill-test-semlf-fill-prefix, fill-test-semlf-indented-block) (fill-test-semlf-revert): Delete tests since they are now grouped with other tests. * test/lisp/textmodes/fill-resources/fill-paragraph.erts: * test/lisp/textmodes/fill-resources/fill-paragraph-semlf.erts: * test/lisp/textmodes/fill-resources/fill-region-as-paragraph.erts: * test/lisp/textmodes/fill-resources/fill-region-as-paragraph-default.erts: * test/lisp/textmodes/fill-resources/fill-region-as-paragraph-semlf.erts: Add test cases for the function specified in the file name, including tests for the scenarios described in the bug report. * test/lisp/textmodes/fill-resources/fill-region.erts: Add test case for custom `fill-region-as-paragraph-function', include test code in the test specification. * test/lisp/textmodes/fill-resources/fill-paragraph-semlf-c-mode.erts: * test/lisp/textmodes/fill-resources/ fill-paragraph-semlf-emacs-lisp-mode.erts: * test/lisp/textmodes/fill-resources/fill-paragraph-semlf-markdown-mode.erts: * test/lisp/textmodes/fill-resources/fill-paragraph-semlf-org-mode.erts: Rename from semlf-*-mode.erts, prefix test names with the tested function and include test code in the test specification. * test/lisp/textmodes/fill-resources/semlf-fill-column.erts: * test/lisp/textmodes/fill-resources/semlf-fill-prefix.erts: * test/lisp/textmodes/fill-resources/semlf-fill-region.erts: * test/lisp/textmodes/fill-resources/semlf-fill-region-as-paragraph.erts: * test/lisp/textmodes/fill-resources/semlf-indented-block.erts: * test/lisp/textmodes/fill-resources/semlf-justify.erts: * test/lisp/textmodes/fill-resources/semlf-punctuation-marks.erts: * test/lisp/textmodes/fill-resources/semlf-revert.erts: * test/lisp/textmodes/fill-resources/semlf-sentence-end-double-space.erts: * test/lisp/textmodes/fill-resources/semlf-twice.erts: * test/lisp/textmodes/fill-resources/semlf.erts: Delete files. (Bug#79575)
* lisp/textmodes/ispell.el (ispell-add-per-file-word-list): Deal with `comment-end' in a way that works for comments that don’t nest. We proceed as follows: when `comment-end' is non-empty, we only ever insert one start and one end comment, the first time we add a local word. This works with both C-style (which don’t nest) and Rust-style comments (which do). If we’re using line comments (i.e. comments that only have a `comment-start'), then continue to insert one on each line. * test/lisp/textmodes/ispell-tests/ispell-tests.el (ispell/ispell-add-per-file-word-list/nxml): Adjust test. Bug#79871
* test/lisp/textmodes/ispell-resources/fake-aspell-new.bash Error with a broken dictionary. * test/lisp/textmodes/ispell-tests/ispell-tests-common.el (ispell-tests--constants/nonexistent-dictionary): Add. (ispell-tests--some-valid-dictionary): Give fallback dictionary. * test/lisp/textmodes/ispell-tests/ispell-tests.el (ispell/ispell-accept-buffer-local-defs/received-file): Use proper broken dictionary.
Fixes bug#79477 and bug#79514 * test/lisp/textmodes/ispell-tests/ispell-hunspell-tests.el (ispell-tests-hunspell--hunspell-working): Implement checker. (ispell/hunspell/ispell-word/russian/check-only): Add skip-check. (ispell/hunspell/ispell-word/english/check-only): Add skip-check. (ispell/hunspell/ispell-word/language-switch/check-only): Add skip-check. (ispell/hunspell/ispell-word/russian/check-only/wrong-language): Add skip-check. (ispell/hunspell/ispell-word/multilang): Add skip-check. * test/lisp/textmodes/ispell-tests/ispell-tests-common.el (fake-aspell-path): Improve checking that an engine works. (ispell-tests--letopt): Make restoring variables more robust, rename to a local name. Add debug spec. (ispell-tests--with-ispell-global-dictionary): Rename to a local name Add debug spec. (ispell-tests--some-valid-dictionary): Add a selector for a safe dictionary. (ispell/ispell-accept-buffer-local-defs/received-file): Add. (ispell-tests--constants/english/correct-list): Add. (ispell-tests--constants/english/correct-one): Add. (ispell-tests--constants/english/wrong): Add. (ispell-tests--constants/russian/correct): Add. (ispell-tests--constants/russian/wrong): Add. (ispell-tests--constants/completion): Add. * test/lisp/textmodes/ispell-tests/ispell-tests.el (ispell/ispell-buffer-local-words/ispell-buffer-session-localwords): reverse letopt and with-ispell-dictionary. (ispell/ispell-buffer-local-words/ispell-words-keyword): reverse letopt and with-ispell-dictionary. (ispell/ispell-complete-word-interior-frag/simple): reverse letopt and with-ispell-dictionary. (ispell/ispell-complete-word/ispell-completion-at-point): reverse letopt and with-ispell-dictionary. (ispell/ispell-init-process/works-with-home): reverse letopt and with-ispell-dictionary. (ispell/ispell-kill-ispell): reverse letopt and with-ispell-dictionary. * test/lisp/textmodes/ispell-resources/fake-aspell-new.bash: Add comments on unused function. Replace echo with printf.
* test/lisp/textmodes/ispell-resources/fake-aspell-new.bash: Avoid using associative arrays since they are not available in old bash versions that come with some systems (bug#79177).