emacs/test/lisp/erc, branch features/user-directory Emacs is the extensible, customizable, self-documenting real-time display editor. Don't send empty lines for unknown commands in ERC 2021-11-06T18:13:35+00:00 F. Jason Park 2021-06-13T09:15:55+00:00 1b1d387b96ebeb8330a76240db0cda6b8cefdf1f * lisp/erc/erc.el (erc-cmd-default): prevent excess trailing newlines from being sent. * test/lisp/erc/erc-tests.el: Update `erc-process-input-line' test to check for excess line feeds with unknown commands. 
* lisp/erc/erc.el (erc-cmd-default): prevent excess trailing newlines
from being sent.

* test/lisp/erc/erc-tests.el: Update `erc-process-input-line' test to
check for excess line feeds with unknown commands.
Don't send empty lines for implicit targets in ERC 2021-11-06T02:09:43+00:00 F. Jason Park 2021-11-06T02:09:43+00:00 4d656ea5ff7ba79315af42e159254867bfd157ad * erc.el (erc-send-input-line): Previously, any line typed into a query or channel buffer without an explicit user-command handler (meaning most lines), would be sent twice because a trailing newline (linefeed) would be appended. This has been verified by checking IRCd server logs. IRCds won't return an error upon receiving an empty message, but they also won't forward them to channel subscribers and DM pals. * erc-tests.el: Add test for erc-process-input-line, which also indirectly tests erc-send-input-line. It also tests the command lookup and dispatch facility (bug#50008). 
* erc.el (erc-send-input-line): Previously, any line typed into a
query or channel buffer without an explicit user-command
handler (meaning most lines), would be sent twice because a trailing
newline (linefeed) would be appended. This has been verified by
checking IRCd server logs. IRCds won't return an error upon receiving
an empty message, but they also won't forward them to channel
subscribers and DM pals.

* erc-tests.el: Add test for erc-process-input-line, which also
indirectly tests erc-send-input-line. It also tests the command
lookup and dispatch facility (bug#50008).
; Minor stylistic checkdoc fixes in test/**/*.el 2021-09-26T15:53:23+00:00 Stefan Kangas 2021-09-25T23:53:56+00:00 8bb28e740dd2cc8058d7833dd60b0ef9a8765c1b 






Change the erc debug logging format to be more repeatable
2021-09-16T13:35:55+00:00

F. Jason Park

2021-09-16T13:35:55+00:00

426c5fdfb240f101c3f3ee6e001684c1f82c790f

* erc.el (erc-debug-irc-protocol): Fix line-ending mismatch between
incoming and outgoing logger lines without changing interface. Do this
by adding carriage returns to the latter to improve machine
readability. Change printed peer labels to most accurately reflect
logical endpoints.

(erc-debug-irc-protocol-time-format): Add new variable to support
timestamps in protocol logger output.

(erc-debug-irc-protocol-version): Add new variable to help tooling
track logging format independent of ERC and Emacs versions.

(erc-toggle-debug-irc-protocol): Add headers to protocol-log buffer
to aid future bug-reproduction tools. Clean up overlong lines (bug#50009).





* erc.el (erc-debug-irc-protocol): Fix line-ending mismatch between
incoming and outgoing logger lines without changing interface. Do this
by adding carriage returns to the latter to improve machine
readability. Change printed peer labels to most accurately reflect
logical endpoints.

(erc-debug-irc-protocol-time-format): Add new variable to support
timestamps in protocol logger output.

(erc-debug-irc-protocol-version): Add new variable to help tooling
track logging format independent of ERC and Emacs versions.

(erc-toggle-debug-irc-protocol): Add headers to protocol-log buffer
to aid future bug-reproduction tools. Clean up overlong lines (bug#50009).







Fix erc nick trimming
2021-09-16T13:25:18+00:00

F. Jason Park

2021-09-16T13:25:18+00:00

fb2971e18e2d945574a1ff53cae39b861e974989

* lisp/erc/erc.el (erc-lurker-maybe-trim): Prevent warning from
showing up in third-party code using this function by autoloading
rx.el when needed.  Remove trailing chars appended for uniquifying
purposes when a nick is already taken. Special thanks to Mattias
Engdegård for making this more respectable (Bug#50005).

* test/lisp/erc/erc-tests.el: Add tests for the above and require
erc-networks.





* lisp/erc/erc.el (erc-lurker-maybe-trim): Prevent warning from
showing up in third-party code using this function by autoloading
rx.el when needed.  Remove trailing chars appended for uniquifying
purposes when a nick is already taken. Special thanks to Mattias
Engdegård for making this more respectable (Bug#50005).

* test/lisp/erc/erc-tests.el: Add tests for the above and require
erc-networks.







Fix mistake in test for erc-ring-previous-command
2021-09-16T13:20:59+00:00

F. Jason Park

2021-09-16T13:20:59+00:00

492fd05ac21f10efc82a93eed23bdd4532bbb0b1

* test/lisp/erc/erc-tests.el (erc-ring-previous-command):
The variable erc-send-completed-hook was previously set to nil
permanently, which would affect other tests (bug#50005).





* test/lisp/erc/erc-tests.el (erc-ring-previous-command):
The variable erc-send-completed-hook was previously set to nil
permanently, which would affect other tests (bug#50005).







Accept string argument in erc-add-to-input-ring
2021-02-27T04:35:40+00:00

F. Jason Park

2021-02-27T04:35:40+00:00

c9f5c314ad2243ab98b4f779d8abfb87499aa3aa

* lisp/erc/erc-ring.el: (erc-add-to-input-ring)
(erc-previous-command): Use existing API to grab input.
* test/lisp/erc/erc-tests.el: (erc-ring-previous-command)
See (bug#46339).





* lisp/erc/erc-ring.el: (erc-add-to-input-ring)
(erc-previous-command): Use existing API to grab input.
* test/lisp/erc/erc-tests.el: (erc-ring-previous-command)
See (bug#46339).







Update copyright year to 2021
2021-01-01T09:13:56+00:00

Paul Eggert

2021-01-01T09:13:56+00:00

ba05d005e5a81bc123ad8da928b1bccb6b160e7a

Run "TZ=UTC0 admin/update-copyright".





Run "TZ=UTC0 admin/update-copyright".







Remove redundant requires of 'font-core'
2020-12-03T07:51:15+00:00

Stefan Kangas

2020-12-03T07:51:15+00:00

cf90856946827d6a5c87c6e79e312fdd0becf899

* lisp/ibuffer.el:
* test/lisp/erc/erc-track-tests.el: Don't require 'font-core'; it is
preloaded since version 22.1.





* lisp/ibuffer.el:
* test/lisp/erc/erc-track-tests.el: Don't require 'font-core'; it is
preloaded since version 22.1.







Make the erc /ignore command prompt for a timeout
2020-08-05T08:27:40+00:00

Lars Ingebrigtsen

2020-08-05T08:27:40+00:00

a59296d9984023960453322ff7d664ec79250f7a

* lisp/erc/erc.el (erc--unignore-user): Separate into own function
(bug#40137).
(erc-cmd-IGNORE): Ask if the user wants a timeout.
(erc--read-time-period): New function.





* lisp/erc/erc.el (erc--unignore-user): Separate into own function
(bug#40137).
(erc-cmd-IGNORE): Ask if the user wants a timeout.
(erc--read-time-period): New function.