emacs/src/pdumper.c, branch scratch/posix-spawn Emacs is the extensible, customizable, self-documenting real-time display editor. Unbreak build after commit 1a0a11f7d2d1dbecb9f754b1e129d50e489058e6. 2020-12-20T23:17:56+00:00 Philipp Stephani 2020-12-20T23:17:56+00:00 174607e5ff014fb68bea4945f6199e8da1261788 The commit only changed a comment in 'struct buffer', so the portable dumper doesn't need to be adapted. * src/pdumper.c (dump_buffer): Update hash for 'struct buffer'. 
The commit only changed a comment in 'struct buffer', so the portable
dumper doesn't need to be adapted.

* src/pdumper.c (dump_buffer): Update hash for 'struct buffer'.
Unbreak compilation with CHECK_STRUCTS. 2020-11-22T22:22:50+00:00 Philipp Stephani 2020-11-22T22:22:50+00:00 edd949a3eb8907eed84eab30e170cc138a5b2d41 Commit 3963aea4f4a22da0c1fb8ca8ca80b59c58373811 modified the ‘buffer’ structure, but didn’t adapt the hash. * src/pdumper.c (dump_buffer): Update buffer hash. 
Commit 3963aea4f4a22da0c1fb8ca8ca80b59c58373811 modified the ‘buffer’
structure, but didn’t adapt the hash.

* src/pdumper.c (dump_buffer): Update buffer hash.
Capitalize portable dump messages. 2020-11-14T12:33:07+00:00 Philipp Stephani 2020-11-14T12:30:53+00:00 b13e87c35bb0215c211a456b8bc3184bf16eb5de We capitalize all other messages during the dump, so capitalize the "dump mode" and "dumping fingerprint" ones as well for consistency. * src/pdumper.c (Fdump_emacs_portable): Capitalize fingerprint message prefix. * lisp/loadup.el: Capitalize "dump mode" message. 
We capitalize all other messages during the dump, so capitalize the
"dump mode" and "dumping fingerprint" ones as well for consistency.

* src/pdumper.c (Fdump_emacs_portable): Capitalize fingerprint message
prefix.

* lisp/loadup.el: Capitalize "dump mode" message.
; Fix typos 2020-09-21T12:26:42+00:00 Stefan Kangas 2020-09-21T11:29:10+00:00 462dbc1cb2c59eaca9c9344636b8af29462370a0 






Fix assertion violation in pdumper.c
2020-08-17T16:30:40+00:00

Eli Zaretskii

2020-08-17T16:30:02+00:00

3a17b9f265fd6d42e82f649533027b4531f9dabf

* src/pdumper.c (pdumper_find_object_type_impl): When checking
last_mark_bits, require the offset to be less than
discardable_start, not cold_start.  This fixes a typo introduced in
2020-08-14T21:33:21Z!eggert@cs.ucla.edu (Bug#42832).





* src/pdumper.c (pdumper_find_object_type_impl): When checking
last_mark_bits, require the offset to be less than
discardable_start, not cold_start.  This fixes a typo introduced in
2020-08-14T21:33:21Z!eggert@cs.ucla.edu (Bug#42832).







Fix bus error on Debian bullseye
2020-08-14T22:51:52+00:00

Paul Eggert

2020-08-14T21:33:21+00:00

4ecc2ba01db5029c42d3b7f1418a021cccf2dc67

Problem reported by Lars Ingebrigtsen, and problem diagnosis
and most of this patch by Pip Cet (Bug#42832).
* src/pdumper.c (dump_bitsets_init): Rename from dump_bitset_init.
All callers changed.  Initialize two bitsets with a single malloc
call.
(struct pdumper_loaded_dump_private): New member last_mark_bits.
(pdumper_find_object_type_impl): Return PDUMPER_NO_OBJECT if
the last_mark_bits’ bit is clear.
(pdumper_set_marked_impl): Assert that the last_mark_bits’
bit is set.
(pdumper_clear_marks_impl): Save mark_bits into
last_mark_bits before clearing mark_bits.
Co-authored-by: Pip Cet <pipcet@gmail.com>





Problem reported by Lars Ingebrigtsen, and problem diagnosis
and most of this patch by Pip Cet (Bug#42832).
* src/pdumper.c (dump_bitsets_init): Rename from dump_bitset_init.
All callers changed.  Initialize two bitsets with a single malloc
call.
(struct pdumper_loaded_dump_private): New member last_mark_bits.
(pdumper_find_object_type_impl): Return PDUMPER_NO_OBJECT if
the last_mark_bits’ bit is clear.
(pdumper_set_marked_impl): Assert that the last_mark_bits’
bit is set.
(pdumper_clear_marks_impl): Save mark_bits into
last_mark_bits before clearing mark_bits.
Co-authored-by: Pip Cet <pipcet@gmail.com>







Don’t warn about integer conversion in pdumper.c
2020-08-12T01:36:37+00:00

Paul Eggert

2020-08-12T01:35:44+00:00

4491a55ac3c4e85a64e47519c8670ba23ae8d2f6

Problem reported by Juanma Barranquero in:
https://lists.gnu.org/r/emacs-devel/2020-08/msg00279.html
and a similar glitch was reported by Eli Zaretskii (Bug#36597#67).
* src/pdumper.c: Remove -Wconversion pragma.
(ALLOW_IMPLICIT_CONVERSION, DISALLOW_IMPLICIT_CONVERSION):
Remove.  All uses removed.  Although -Wconversion may have
been helpful when writing pdumper.c it is now causing more
trouble than it’s worth here (just as in the rest of Emacs).
(dump_read_all): Avoid no-longer-necessary use of ‘size_t’
rather than ‘int’.





Problem reported by Juanma Barranquero in:
https://lists.gnu.org/r/emacs-devel/2020-08/msg00279.html
and a similar glitch was reported by Eli Zaretskii (Bug#36597#67).
* src/pdumper.c: Remove -Wconversion pragma.
(ALLOW_IMPLICIT_CONVERSION, DISALLOW_IMPLICIT_CONVERSION):
Remove.  All uses removed.  Although -Wconversion may have
been helpful when writing pdumper.c it is now causing more
trouble than it’s worth here (just as in the rest of Emacs).
(dump_read_all): Avoid no-longer-necessary use of ‘size_t’
rather than ‘int’.







Unbreak build with --enable-checking=all
2020-08-11T18:22:32+00:00

Philipp Stephani

2020-08-11T18:20:44+00:00

ccb5556b44f10124c7dd6c230a6d817fa83b9690

Commit 16a16645f524c62f7906036b0e383e4247b58de7 has only changed a
comment in ‘struct Lisp_Hash_Table’, so the portable dumper doesn’t
need to be adapted.

* src/pdumper.c (dump_hash_table): Update hash code for ‘struct
Lisp_Hash_Table’.





Commit 16a16645f524c62f7906036b0e383e4247b58de7 has only changed a
comment in ‘struct Lisp_Hash_Table’, so the portable dumper doesn’t
need to be adapted.

* src/pdumper.c (dump_hash_table): Update hash code for ‘struct
Lisp_Hash_Table’.







Prefer make_nil_vector to make-vector with nil
2020-08-11T17:30:05+00:00

Paul Eggert

2020-08-11T17:29:02+00:00

669aeafbd14b0ebb824bacba0a6b3daad30847a9

* src/pdumper.c (hash_table_thaw): Pacify -Wconversion so
we can use make_nil_vector again.
* src/timefns.c (syms_of_timefns): Prefer make_nil_vector
to make_vector with Qnil.





* src/pdumper.c (hash_table_thaw): Pacify -Wconversion so
we can use make_nil_vector again.
* src/timefns.c (syms_of_timefns): Prefer make_nil_vector
to make_vector with Qnil.







Fix MinGW build broken by recent pdumper changes.
2020-08-11T16:59:17+00:00

Eli Zaretskii

2020-08-11T16:59:17+00:00

b5b7f6eb88d6588f6150c34e1405457f062538bb

* src/pdumper.c (hash_table_thaw): Use Fmake_vector.  Suggested by
Pip Cet <pipcet@gmail.com>.
(dump_trace): Declare ATTRIBUTE_FORMAT_PRINTF, not
ATTRIBUTE_FORMAT((__printf__), so that we pick the right attribute
for MinGW.





* src/pdumper.c (hash_table_thaw): Use Fmake_vector.  Suggested by
Pip Cet <pipcet@gmail.com>.
(dump_trace): Declare ATTRIBUTE_FORMAT_PRINTF, not
ATTRIBUTE_FORMAT((__printf__), so that we pick the right attribute
for MinGW.