emacs/lwlib, branch scratch/track-changes Emacs is the extensible, customizable, self-documenting real-time display editor. Revert "Add new `swap` macro and use it" 2024-01-06T07:28:14+00:00 Po Lu 2024-01-06T07:28:14+00:00 657275529e31226bbc6c92eb7f7af887474a0bb8 typeof is an extension which does not exist in Standard C, so macros using it are unsuitable for inclusion in Emacs. This reverts commit 37889523278fe65733938fb11c3701898309961c. 
typeof is an extension which does not exist in Standard C, so macros
using it are unsuitable for inclusion in Emacs.

This reverts commit 37889523278fe65733938fb11c3701898309961c.
Add new `swap` macro and use it 2024-01-06T07:22:08+00:00 Stefan Kangas 2024-01-06T07:22:08+00:00 37889523278fe65733938fb11c3701898309961c A `swap` macro prevents programming errors and is more concise. It is a natural addition to our existing `min` and `max` macros. * src/lisp.h (swap): New macro. * lwlib/xlwmenu.c (draw_shadow_rectangle, draw_shadow_rhombus): * src/androidterm.c (android_get_surrounding_text): * src/buffer.c (Fmake_overlay, modify_overlay, Fmove_overlay): * src/dispnew.c (swap_glyphs_in_rows, reverse_rows): * src/editfns.c (Finsert_buffer_substring) (Fcompare_buffer_substrings): * src/eval.c (run_hook_wrapped_funcall): * src/fns.c (extract_data_from_object): * src/regex-emacs.c (forall_firstchar_1): * src/textconv.c (textconv_query, get_extracted_text) (get_surrounding_text): * src/textprop.c (validate_interval_range) (verify_interval_modification): * src/w32uniscribe.c (OTF_INT16_VAL): * src/xfaces.c (load_face_colors): * src/xterm.c (SWAPCARD32): Prefer using above macro to open-coding. 
A `swap` macro prevents programming errors and is more concise.
It is a natural addition to our existing `min` and `max` macros.

* src/lisp.h (swap): New macro.
* lwlib/xlwmenu.c (draw_shadow_rectangle, draw_shadow_rhombus):
* src/androidterm.c (android_get_surrounding_text):
* src/buffer.c (Fmake_overlay, modify_overlay, Fmove_overlay):
* src/dispnew.c (swap_glyphs_in_rows, reverse_rows):
* src/editfns.c (Finsert_buffer_substring)
(Fcompare_buffer_substrings):
* src/eval.c (run_hook_wrapped_funcall):
* src/fns.c (extract_data_from_object):
* src/regex-emacs.c (forall_firstchar_1):
* src/textconv.c (textconv_query, get_extracted_text)
(get_surrounding_text):
* src/textprop.c (validate_interval_range)
(verify_interval_modification):
* src/w32uniscribe.c (OTF_INT16_VAL):
* src/xfaces.c (load_face_colors):
* src/xterm.c (SWAPCARD32): Prefer using above macro to open-coding.
; Add 2024 to copyright years 2024-01-02T01:47:10+00:00 Po Lu 2024-01-02T01:47:10+00:00 8e1c56ae46754dd7baedff49a464f078f0e9912d 






Fix dependency bug when building lwlib
2023-01-14T07:39:51+00:00

Paul Eggert

2023-01-14T02:22:47+00:00

1b9ffd281162794e71a7e6a4d26cfbb3991c0cde

* lwlib/Makefile.in (DEPFLAGS): Use OBJS to calculate dependency
file names, not ALLOBJS.  This fixes a typo introduced
in 2015-05-15 "Replace AC_SUBST_FILE in configure with include in
Makefiles" that caused lwlib/*.o to not be rebuilt sometimes
when that was needed.





* lwlib/Makefile.in (DEPFLAGS): Use OBJS to calculate dependency
file names, not ALLOBJS.  This fixes a typo introduced
in 2015-05-15 "Replace AC_SUBST_FILE in configure with include in
Makefiles" that caused lwlib/*.o to not be rebuilt sometimes
when that was needed.







; Add 2023 to copyright years.
2023-01-01T10:31:12+00:00

Eli Zaretskii

2023-01-01T10:31:12+00:00

cae528457cb862dc886a34240c9d4c73035b6659












Fix unlikely core dump with Xaw
2022-08-26T01:30:10+00:00

Paul Eggert

2022-08-23T23:25:40+00:00

97067349a8d75ab720ff2e98653a6b21f60b221e

* lwlib/lwlib-Xaw.c (make_dialog): Don’t dump core if calloc fails.
Caught with --enable-gcc-warnings.





* lwlib/lwlib-Xaw.c (make_dialog): Don’t dump core if calloc fails.
Caught with --enable-gcc-warnings.







Fix calculation of default highlightForeground in the lucid menu bar
2022-07-20T11:06:27+00:00

Po Lu

2022-07-20T11:05:58+00:00

05a022c36e4177842dd6a4f3e24c2ed1776dbb66

* lwlib/xlwmenu.c (xlwMenuResources, display_menu_item)
(make_drawing_gcs, make_shadow_gcs, openXftFont, XlwMenuRealize)
(XlwMenuSetValues): Use -1 as the default for
highlight_foreground.  Replace that with the normal foreground
when creating GCs.  Reported by Colin Baxter
<m43cap@yandex.com>.





* lwlib/xlwmenu.c (xlwMenuResources, display_menu_item)
(make_drawing_gcs, make_shadow_gcs, openXftFont, XlwMenuRealize)
(XlwMenuSetValues): Use -1 as the default for
highlight_foreground.  Replace that with the normal foreground
when creating GCs.  Reported by Colin Baxter
<m43cap@yandex.com>.







Colored menu highlight in Lucid backend
2022-07-16T10:59:09+00:00

Manuel Giraud

2022-07-11T09:14:08+00:00

38f9e9cb2c04af38a609e7d0a812f0809458125b

* lwlib/xlwmenuP.h:
* lwlib/xlwmenu.h:
* lwlib/xlwmenu.c: Introduce resources to handle colored highlighting
of menu entries.
* doc/emacs/xresources.texi (Lucid Resources): Documentation.





* lwlib/xlwmenuP.h:
* lwlib/xlwmenu.h:
* lwlib/xlwmenu.c: Introduce resources to handle colored highlighting
of menu entries.
* doc/emacs/xresources.texi (Lucid Resources): Documentation.







; * lwlib/xlwmenu.c (make_shadow_gcs): Remove "a = a" pattern.
2022-07-11T10:09:13+00:00

Manuel Giraud

2022-07-11T10:09:13+00:00

d8225e9fa1e68ff4e38f149838ae0a72853b2f2b

* lwlib/xlwmenu.c (make_shadow_gcs): Remove code that sets a value
to itself (bug#56479).





* lwlib/xlwmenu.c (make_shadow_gcs): Remove code that sets a value
to itself (bug#56479).







Fix recent change to xlwmenu.c
2022-06-21T14:14:49+00:00

Po Lu

2022-06-21T14:14:49+00:00

a4dcc8b9a94466c792be3743760a4a45cf6e1e61

* lwlib/xlwmenu.c (ungrab_all): Ungrab keyboard if it was
grabbed.  This handles `lucid--menu-grab-keyboard' changing
while the menu is open.

(XlwMenuDestroy):
(pop_up_menu): Record if the keyboard was grabbed.





* lwlib/xlwmenu.c (ungrab_all): Ungrab keyboard if it was
grabbed.  This handles `lucid--menu-grab-keyboard' changing
while the menu is open.

(XlwMenuDestroy):
(pop_up_menu): Record if the keyboard was grabbed.