emacs/lisp/erc, branch scratch/native-comp-cl Emacs is the extensible, customizable, self-documenting real-time display editor. Remove some compat code from erc 2020-08-19T09:32:56+00:00 Lars Ingebrigtsen 2020-08-19T09:32:56+00:00 87ded4c96d70dbe6841244a959e2969f8b1e2ec4 * lisp/erc/erc.el (erc-mode): next-line-add-newlines is always defined, so remove the check. 
* lisp/erc/erc.el (erc-mode): next-line-add-newlines is always
defined, so remove the check.
Remove some compat code from erc-track.el 2020-08-18T09:23:47+00:00 Lars Ingebrigtsen 2020-08-18T09:23:47+00:00 128b04fca08f791a4eba64e8c1fe3429df7e822f * lisp/erc/erc-track.el (erc-track-remove-from-mode-line) (erc-track-add-to-mode-line): Remove check for mode-line-modes, which is always bound. 
* lisp/erc/erc-track.el (erc-track-remove-from-mode-line)
(erc-track-add-to-mode-line): Remove check for mode-line-modes,
which is always bound.
Add `message' to erc-match.el highlight types 2020-08-15T02:12:02+00:00 Amin Bandali 2020-08-15T01:54:48+00:00 e365b9ab7b989c0587c0f2c0f05d35b4d67920dd * lisp/erc/erc-match.el (erc-current-nick-highlight-type, erc-pal-highlight-type, erc-fool-highlight-type, erc-keyword-highlight-type, erc-dangerous-host-highlight-type): Add `message' type for highlighting the entire message but not the sender's nick. (erc-match-message): Check for the new `message' highlight type and propertize the message (not including the nick) accordingly. * etc/NEWS: Announce the addition of the `message' highlight type. 
* lisp/erc/erc-match.el (erc-current-nick-highlight-type,
erc-pal-highlight-type, erc-fool-highlight-type,
erc-keyword-highlight-type, erc-dangerous-host-highlight-type): Add
`message' type for highlighting the entire message but not the
sender's nick.
(erc-match-message): Check for the new `message' highlight type and
propertize the message (not including the nick) accordingly.
* etc/NEWS: Announce the addition of the `message' highlight type.
Make erc-compat.el obsolete 2020-08-13T23:31:54+00:00 Stefan Kangas 2020-08-12T17:32:52+00:00 32cb84974faac7cecdd82e154f7cae9ac0ee8320 * lisp/erc/erc-compat.el: Move from here... * lisp/obsolete/erc-compat.el: ...to here. * lisp/erc/erc-backend.el: * lisp/erc/erc-pcomplete.el: * lisp/erc/erc-stamp.el: * lisp/erc/erc-track.el: * lisp/erc/erc.el: Don't require 'erc-compat'. * lisp/erc/erc-backend.el (erc-decode-string-from-target): * lisp/erc/erc-dcc.el (pcomplete/erc-mode/DCC): * lisp/erc/erc-fill.el (erc-fill-mode): * lisp/erc/erc-goodies.el (erc-controls-interpret): * lisp/erc/erc-log.el (erc-log-setup-logging): * lisp/erc/erc-notify.el (erc-notify-QUIT): * lisp/erc/erc.el (erc-startup-file-list, define-erc-module) (erc-canonicalize-server-name, erc-cmd-SV, erc-banlist-update) (erc-group-list, erc-seconds-to-string): Adjust callers. * lisp/erc/erc.el: Require cl-lib and format-spec. * etc/NEWS: Add entry announcing erc-compat.el being marked as obsolete. 
* lisp/erc/erc-compat.el: Move from here...
* lisp/obsolete/erc-compat.el: ...to here.
* lisp/erc/erc-backend.el:
* lisp/erc/erc-pcomplete.el:
* lisp/erc/erc-stamp.el:
* lisp/erc/erc-track.el:
* lisp/erc/erc.el: Don't require 'erc-compat'.

* lisp/erc/erc-backend.el (erc-decode-string-from-target):
* lisp/erc/erc-dcc.el (pcomplete/erc-mode/DCC):
* lisp/erc/erc-fill.el (erc-fill-mode):
* lisp/erc/erc-goodies.el (erc-controls-interpret):
* lisp/erc/erc-log.el (erc-log-setup-logging):
* lisp/erc/erc-notify.el (erc-notify-QUIT):
* lisp/erc/erc.el (erc-startup-file-list, define-erc-module)
(erc-canonicalize-server-name, erc-cmd-SV, erc-banlist-update)
(erc-group-list, erc-seconds-to-string): Adjust callers.
* lisp/erc/erc.el: Require cl-lib and format-spec.

* etc/NEWS: Add entry announcing erc-compat.el being marked as
obsolete.
Add support for italic text in ERC 2020-08-12T17:39:07+00:00 Amin Bandali 2020-08-12T17:33:36+00:00 2b69a4df78fcca44387368583e170db860f0013b * lisp/erc/erc-goodies.el (erc-italic-face): New face for italic text. (erc-controls-interpret), (erc-controls-highlight): Add `italicp'. (erc-controls-remove-regexp), (erc-controls-highlight-regexp): Handle C-] for italic. (erc-controls-propertize): Add `italicp' argument and use it to conditionally propertize text with the new `erc-italic-face'. * etc/NEWS: Announce italic text support. 
* lisp/erc/erc-goodies.el (erc-italic-face): New face for italic text.
(erc-controls-interpret), (erc-controls-highlight): Add `italicp'.
(erc-controls-remove-regexp),
(erc-controls-highlight-regexp): Handle C-] for italic.
(erc-controls-propertize): Add `italicp' argument and use it to
conditionally propertize text with the new `erc-italic-face'.
* etc/NEWS: Announce italic text support.
Fix erc-reuse-buffers behavior 2020-08-12T11:09:40+00:00 Mingde (Matthew) Zeng 2020-08-12T11:09:35+00:00 88567ca8ecb505a59157af6338ebe355a304182b * lisp/erc/erc.el (erc-generate-new-buffer-name): Fixes behavior 1, also determines if the '#channel/server' buffer already exists and will reuse that buffer when joining on the same server. Additionally when creating a new buffer with '#channel/serverB', the existing buffer '#channel' on 'severA' will be renamed to '#channel/serverA' for the sake of consistency (bug#40121). * lisp/erc/erc-join.el (erc-autojoin-channels): The logic is simplified ensuring that when autojoining channels specified in erc-autojoin-channels-alist, if there exists an erc buffer with the same channel name but a different server, it will create a new buffer to join the channel. The current logic is very weak that will skip joining same channel on different servers altogether. By the definition of erc-reuse-buffers, if non-nil it should create a new buffer when joining channels with same names on different servers. The current behavior of erc-reuse-buffers is: 1. when non-nil, it will always reuse the same channel buffer, resulting in server A's channel gets reconnected to the channel with the same name of server B. 2. when nil, the buffer-name of the joined channel is '#channel/server'. However if one tries to '/join #channel' from the server buffer, it creates a new empty buffer with buffer-name '#channel', instead of opening the already-joined channel buffer. 
* lisp/erc/erc.el (erc-generate-new-buffer-name): Fixes behavior 1,
also determines if the '#channel/server' buffer already exists
and will reuse that buffer when joining on the same
server. Additionally when creating a new buffer with
'#channel/serverB', the existing buffer '#channel' on 'severA' will be
renamed to '#channel/serverA' for the sake of consistency (bug#40121).

* lisp/erc/erc-join.el (erc-autojoin-channels): The logic is
simplified ensuring that when autojoining channels specified in
erc-autojoin-channels-alist, if there exists an erc buffer with the
same channel name but a different server, it will create a new buffer
to join the channel. The current logic is very weak that will skip
joining same channel on different servers altogether.

By the definition of erc-reuse-buffers, if non-nil it should create a
new buffer when joining channels with same names on different
servers. The current behavior of erc-reuse-buffers is:
1. when non-nil, it will always reuse the same channel buffer,
resulting in server A's channel gets reconnected to the channel with
the same name of server B.
2. when nil, the buffer-name of the joined channel is
'#channel/server'. However if one tries to '/join #channel' from the
server buffer, it creates a new empty buffer with buffer-name
'#channel', instead of opening the already-joined channel buffer.
Make more erc function aliases obsolete 2020-08-07T12:02:01+00:00 Stefan Kangas 2020-08-07T11:54:50+00:00 7ed61d6193629fa88d348221db3f1df7130a8bd3 * lisp/erc/erc-compat.el (erc-propertize, erc-view-mode-enter) (erc-function-arglist, erc-delete-dups) (erc-replace-regexp-in-string): Make these aliases obsolete. * lisp/erc/erc-capab.el (erc-capab-identify-add-prefix) (erc-capab-identify-remove/set-identified-flag): * lisp/erc/erc-dcc.el (erc-dcc-chat-parse-output) (erc-dcc-unquote-filename, pcomplete/erc-mode/DCC): * lisp/erc/erc-list.el (erc-list-menu-mode, erc-list-button) (erc-list-make-string): * lisp/erc/erc-log.el (erc-log-standardize-name): * lisp/erc/erc-match.el (erc-log-matches-make-buffer): * lisp/erc/erc-networks.el (erc-server-select): * lisp/erc/erc.el (erc-message-english-PART) (erc-update-mode-line-buffer, erc-format-my-nick) (erc-format-@nick, erc-get-user-mode-prefix, erc-display-prompt) (erc-part-reason-zippy, erc-quit-reason-zippy, erc-get-arglist) (erc-toggle-debug-irc-protocol, erc-log-irc-protocol) (erc-migrate-modules): Adjust callers. 
* lisp/erc/erc-compat.el (erc-propertize, erc-view-mode-enter)
(erc-function-arglist, erc-delete-dups)
(erc-replace-regexp-in-string): Make these aliases obsolete.

* lisp/erc/erc-capab.el (erc-capab-identify-add-prefix)
(erc-capab-identify-remove/set-identified-flag):
* lisp/erc/erc-dcc.el (erc-dcc-chat-parse-output)
(erc-dcc-unquote-filename, pcomplete/erc-mode/DCC):
* lisp/erc/erc-list.el (erc-list-menu-mode, erc-list-button)
(erc-list-make-string):
* lisp/erc/erc-log.el (erc-log-standardize-name):
* lisp/erc/erc-match.el (erc-log-matches-make-buffer):
* lisp/erc/erc-networks.el (erc-server-select):
* lisp/erc/erc.el (erc-message-english-PART)
(erc-update-mode-line-buffer, erc-format-my-nick)
(erc-format-@nick, erc-get-user-mode-prefix, erc-display-prompt)
(erc-part-reason-zippy, erc-quit-reason-zippy, erc-get-arglist)
(erc-toggle-debug-irc-protocol, erc-log-irc-protocol)
(erc-migrate-modules): Adjust callers.
Further fix for erc-generate-new-buffer-name 2020-08-05T09:13:51+00:00 Kevin Brubeck Unhammer 2020-08-05T09:13:51+00:00 c72b734c917f635fac09f691e91d3391b00b96f2 * lisp/erc/erc.el (erc-generate-new-buffer-name): Fix buffer name generation when there's two networks on the same server:port (bug#40121). 
* lisp/erc/erc.el (erc-generate-new-buffer-name): Fix buffer name
generation when there's two networks on the same
server:port (bug#40121).
Make the erc /ignore command prompt for a timeout 2020-08-05T08:27:40+00:00 Lars Ingebrigtsen 2020-08-05T08:27:40+00:00 a59296d9984023960453322ff7d664ec79250f7a * lisp/erc/erc.el (erc--unignore-user): Separate into own function (bug#40137). (erc-cmd-IGNORE): Ask if the user wants a timeout. (erc--read-time-period): New function. 
* lisp/erc/erc.el (erc--unignore-user): Separate into own function
(bug#40137).
(erc-cmd-IGNORE): Ask if the user wants a timeout.
(erc--read-time-period): New function.
Fix erc bug when there's two channels with the same name 2020-08-02T07:43:41+00:00 Lars Ingebrigtsen 2020-08-02T07:43:41+00:00 6f94c2405f4c82b63da19de89549aff1fad7e594 * lisp/erc/erc.el (erc-generate-new-buffer-name): Fix logic when there's two channels with the same name from two different servers (bug#40121). 
* lisp/erc/erc.el (erc-generate-new-buffer-name): Fix logic when
there's two channels with the same name from two different servers
(bug#40121).