This is done simply so as to avoid scattering nadvice's code into
`simple.el` and `cl-print.el`.
* lisp/loadup.el ("emacs-lisp/nadvice"): Move down after "simple".
* lisp/help.el (help-command-error-confusable-suggestions): Make it
call `command-error-default`.
(command-error-function): Replace the top-level call to `add-function`
with a simple `setq` since `add-function` is not available at this
stage any more.
* lisp/emacs-lisp/nadvice.el (interactive-form) <advice>:
(cl-print-object) <advice>: Rename from `advice--get-interactive-form`
and `advice--cl-print-object`.
* lisp/emacs-lisp/cl-print.el (cl-print-object) <advice>:
* lisp/simple.el (interactive-form) <advice>: Move to `nadvice.el`.
(pre-redisplay-function): Replace the top-level call to `add-function`
with a simple `setq` since `add-function` is not available at this
stage any more.
* lisp/emacs-lisp/cl-generic.el: Use `oclosure-object` instead of `advice`
as representative of the OClosure specializers to prefill the dispatcher table.
This is done simply so as to avoid scattering nadvice's code into
`simple.el` and `cl-print.el`.
* lisp/loadup.el ("emacs-lisp/nadvice"): Move down after "simple".
* lisp/help.el (help-command-error-confusable-suggestions): Make it
call `command-error-default`.
(command-error-function): Replace the top-level call to `add-function`
with a simple `setq` since `add-function` is not available at this
stage any more.
* lisp/emacs-lisp/nadvice.el (interactive-form) <advice>:
(cl-print-object) <advice>: Rename from `advice--get-interactive-form`
and `advice--cl-print-object`.
* lisp/emacs-lisp/cl-print.el (cl-print-object) <advice>:
* lisp/simple.el (interactive-form) <advice>: Move to `nadvice.el`.
(pre-redisplay-function): Replace the top-level call to `add-function`
with a simple `setq` since `add-function` is not available at this
stage any more.
* lisp/emacs-lisp/cl-generic.el: Use `fcr-object` instead of `advice`
as representative of the FCR specializers to prefill the dispatcher table.
Kmacros used to be represented as a triplet (MAC COUNTER FORMAT), and then wrapped into a lambda to turn them into commands. Replace the triplet with an OClosure so it's directly executable. Take advantage of the change to promote the key-description format where applicable. * lisp/kmacro.el (kmacro): New OClosure type, to replace both `kmacro-function` and the (MAC COUNTER FORMAT) representation of kmacros. (kmacro-p): Adjust. (kmacro-ring-head): Use `kmacro` constructor. (kmacro-push-ring): Add backward compatibility code for old list representation. (kmacro-view-ring-2nd, kmacro-start-macro, kmacro-view-macro): (kmacro-split-ring-element): Adjust to new representation. (kmacro-exec-ring-item): Redefine as obsolete alias. (kmacro-call-ring-2nd, kmacro-end-or-call-macro): Simplify accordingly. (kmacro-function): Delete OClosure type. (kmacro): Rename from `kmacro-lambda-form` and streamline calling convention. Use `execute-kbd-macro` rather than `kmacro-exec-ring-item`. (kmacro-lambda-form, kmacro-extract-lambda): Rewrite and mark as obsolete. (cl-print-object): Use the key-description format and skip the counter and format parts if they're trivial. (kmacro-bind-to-key, kmacro-name-last-macro): Simplify. * test/lisp/kmacro-tests.el (kmacro-tests-kmacro-bind-to-single-key): Suppress obsoletion warning. (kmacro-tests-name-last-macro-bind-and-rebind): Tighten the check a tiny bit. (kmacro-tests--cl-print): Adjust to the new key-description output. * lisp/macros.el (macro--string-to-vector): New function. (insert-kbd-macro): Use it, and change the generated code to use `kmacro` and the key-description format. * lisp/edmacro.el (edit-kbd-macro): Adjust to new representation. (edmacro-finish-edit): Use `kmacro` constructor.
Kmacros used to be represented as a triplet (MAC COUNTER FORMAT), and then wrapped into a lambda to turn them into commands. Replace the triplet with an FCR so it's directly executable. Take advantage of the change to promote the key-description format where applicable. * lisp/kmacro.el (kmacro): New FCR type, to replace both `kmacro-function` and the (MAC COUNTER FORMAT) representation of kmacros. (kmacro-p): Adjust. (kmacro-ring-head): Use `kmacro` constructor. (kmacro-push-ring): Add backward compatibility code for old list representation. (kmacro-view-ring-2nd, kmacro-start-macro, kmacro-view-macro): (kmacro-split-ring-element): Adjust to new representation. (kmacro-exec-ring-item): Redefine as obsolete alias. (kmacro-call-ring-2nd, kmacro-end-or-call-macro): Simplify accordingly. (kmacro-function): Delete FCR type. (kmacro): Rename from `kmacro-lambda-form` and streamline calling convention. Use `execute-kbd-macro` rather than `kmacro-exec-ring-item`. (kmacro-lambda-form, kmacro-extract-lambda): Rewrite and mark as obsolete. (cl-print-object): Use the key-description format and skip the counter and format parts if they're trivial. (kmacro-bind-to-key, kmacro-name-last-macro): Simplify. * test/lisp/kmacro-tests.el (kmacro-tests-kmacro-bind-to-single-key): Suppress obsoletion warning. (kmacro-tests-name-last-macro-bind-and-rebind): Tighten the check a tiny bit. (kmacro-tests--cl-print): Adjust to the new key-description output. * lisp/macros.el (macro--string-to-vector): New function. (insert-kbd-macro): Use it, and change the generated code to use `kmacro` and the key-description format. * lisp/edmacro.el (edit-kbd-macro): Adjust to new representation. (edmacro-finish-edit): Use `kmacro` constructor.
* src/buffer.c (Frename_buffer): Call `uniquify--rename-buffer-advice`. * lisp/files.el (create-file-buffer): Call`uniquify--create-file-buffer-advice`. * lisp/uniquify.el (uniquify--rename-buffer-advice) (uniquify--create-file-buffer-advice): Don't add them as advice any more. Adjust their calling convention accordingly.
* src/buffer.c (Frename_buffer): Call `uniquify--rename-buffer-advice`. * lisp/files.el (create-file-buffer): Call`uniquify--create-file-buffer-advice`. * lisp/uniquify.el (uniquify--rename-buffer-advice) (uniquify--create-file-buffer-advice): Don't add them as advice any more. Adjust their calling convention accordingly.